From: wangyufen <wangyufen@huawei.com>
To: Quentin Monnet <quentin@isovalent.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <andrii@kernel.org>,
<martin.lau@linux.dev>, <song@kernel.org>, <yhs@fb.com>,
<john.fastabend@gmail.com>, <kpsingh@kernel.org>,
<sdf@google.com>, <haoluo@google.com>, <jolsa@kernel.org>,
<davem@davemloft.net>, <kuba@kernel.org>, <hawk@kernel.org>,
<nathan@kernel.org>, <ndesaulniers@google.com>, <trix@redhat.com>
Cc: <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <llvm@lists.linux.dev>
Subject: Re: [bpf-next v4 2/3] bpftool: Update doc (add auto_attach to prog load)
Date: Wed, 21 Sep 2022 15:15:01 +0800 [thread overview]
Message-ID: <d937796a-48da-50b1-52ce-23aa3d022bf2@huawei.com> (raw)
In-Reply-To: <6bed1b34-3e92-2deb-94b5-9c194c6c7e6c@isovalent.com>
在 2022/9/20 23:12, Quentin Monnet 写道:
> Tue Sep 13 2022 03:54:46 GMT+0100 (British Summer Time) ~ Wang Yufen
> <wangyufen@huawei.com>
>> Add auto_attach optional to prog load|loadall for supporting
>> one-step load-attach-pin_link.
>>
>> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
>> ---
>> tools/bpf/bpftool/Documentation/bpftool-prog.rst | 12 ++++++++++--
>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/bpf/bpftool/Documentation/bpftool-prog.rst b/tools/bpf/bpftool/Documentation/bpftool-prog.rst
>> index eb1b2a2..463f895 100644
>> --- a/tools/bpf/bpftool/Documentation/bpftool-prog.rst
>> +++ b/tools/bpf/bpftool/Documentation/bpftool-prog.rst
>> @@ -31,7 +31,7 @@ PROG COMMANDS
>> | **bpftool** **prog dump xlated** *PROG* [{**file** *FILE* | **opcodes** | **visual** | **linum**}]
>> | **bpftool** **prog dump jited** *PROG* [{**file** *FILE* | **opcodes** | **linum**}]
>> | **bpftool** **prog pin** *PROG* *FILE*
>> -| **bpftool** **prog** { **load** | **loadall** } *OBJ* *PATH* [**type** *TYPE*] [**map** {**idx** *IDX* | **name** *NAME*} *MAP*] [**dev** *NAME*] [**pinmaps** *MAP_DIR*]
>> +| **bpftool** **prog** { **load** | **loadall** } *OBJ* *PATH* [**type** *TYPE*] [**map** {**idx** *IDX* | **name** *NAME*} *MAP*] [**dev** *NAME*] [**pinmaps** *MAP_DIR*] [**auto_attach**]
>> | **bpftool** **prog attach** *PROG* *ATTACH_TYPE* [*MAP*]
>> | **bpftool** **prog detach** *PROG* *ATTACH_TYPE* [*MAP*]
>> | **bpftool** **prog tracelog**
>> @@ -131,7 +131,7 @@ DESCRIPTION
>> contain a dot character ('.'), which is reserved for future
>> extensions of *bpffs*.
>>
>> - **bpftool prog { load | loadall }** *OBJ* *PATH* [**type** *TYPE*] [**map** {**idx** *IDX* | **name** *NAME*} *MAP*] [**dev** *NAME*] [**pinmaps** *MAP_DIR*]
>> + **bpftool prog { load | loadall }** *OBJ* *PATH* [**type** *TYPE*] [**map** {**idx** *IDX* | **name** *NAME*} *MAP*] [**dev** *NAME*] [**pinmaps** *MAP_DIR*] [**auto_attach**]
>> Load bpf program(s) from binary *OBJ* and pin as *PATH*.
>> **bpftool prog load** pins only the first program from the
>> *OBJ* as *PATH*. **bpftool prog loadall** pins all programs
>> @@ -150,6 +150,14 @@ DESCRIPTION
>> Optional **pinmaps** argument can be provided to pin all
>> maps under *MAP_DIR* directory.
>>
>> + If **auto_attach** is specified program will be attached
>> + before pin. 1)in that case, only the link (representing the program
> "1)in" -> "In"
>
>> + attached to its hook) is pinned, not the program as such, so the
>> + path won't show in "bpftool prog show -f", only show in
> Let's use markup instead of quotes around the commands please, **bpftool
> prog show -f** and **bpftool link show -f** (below).
>
>> + "bpftool link show -f", and 2)this only works when bpftool (libbpf)
> ", and 2)this..." -> ". Also, this..."
>
>> + is able to infer all necessary information from the object file,
>> + in particular, it's not supported for all program types.
>> +
>> Note: *PATH* must be located in *bpffs* mount. It must not
>> contain a dot character ('.'), which is reserved for future
>> extensions of *bpffs*.
> Apart from the formatting nits above, looks good, thank you.
Thanks， will send v5
next prev parent reply other threads:[~2022-09-21 7:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 2:54 [bpf-next v4 1/3] bpftool: Add auto_attach for bpf prog load|loadall Wang Yufen
2022-09-13 2:54 ` [bpf-next v4 2/3] bpftool: Update doc (add auto_attach to prog load) Wang Yufen
2022-09-20 15:12 ` Quentin Monnet
2022-09-21 7:15 ` wangyufen [this message]
2022-09-13 2:54 ` [bpf-next v4 3/3] bpftool: Update the bash completion(add " Wang Yufen
2022-09-20 15:12 ` Quentin Monnet
2022-09-20 15:09 ` [bpf-next v4 1/3] bpftool: Add auto_attach for bpf prog load|loadall Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d937796a-48da-50b1-52ce-23aa3d022bf2@huawei.com \
--to=wangyufen@huawei.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.lau@linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=trix@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®