From: Shuah Khan <shuahkh@osg.samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
balbi@kernel.org, gregkh@linuxfoundation.org, kgene@kernel.org,
krzk@kernel.org
Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] usb: dwc3-exynos fix axius clock error path to do cleanup
Date: Tue, 10 Jan 2017 17:38:44 -0700 [thread overview]
Message-ID: <d937dbc2-5883-775e-8c32-56750cbbbb4c@osg.samsung.com> (raw)
In-Reply-To: <006ab225-6e16-b1d7-567c-d1f236702589@osg.samsung.com>
On 01/10/2017 05:32 PM, Javier Martinez Canillas wrote:
> Hello Shuah,
>
> On 01/10/2017 09:30 PM, Shuah Khan wrote:
>
> [snip]
>
>>>> clk_disable_unprepare(exynos->axius_clk);
>>>> +axius_clk_err:
>>>
>>> This label isn't consistent with the others, I know the errN aren't great
>>> so what about changing those to meaningful names in a preparatory patch?
>>>
>>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> Best regards,
>>>
>>
>> Javier,
>>
>> Right they aren't consistent. Changing them all to a better naming scheme
>> will have be done in another cleanup patch in my opinion. I don't want to
>> include cleanup in this fix.
>>
>
> I didn't mean to be done in the same patch, that's why I said in another
> preparatory patch.
Yes. I can send the cleanup patch.
-- Shuah
prev parent reply other threads:[~2017-01-11 0:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 23:05 Shuah Khan
2017-01-11 0:27 ` Javier Martinez Canillas
2017-01-11 0:30 ` Shuah Khan
2017-01-11 0:32 ` Javier Martinez Canillas
2017-01-11 0:38 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d937dbc2-5883-775e-8c32-56750cbbbb4c@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®