From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from www.kot-begemot.co.uk (ns1.kot-begemot.co.uk [217.160.28.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61E121E1DE5 for ; Thu, 28 May 2026 08:21:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.160.28.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779956512; cv=none; b=ucp4d47v5/yY/aE2LAFJ4BR68/Qy9TxZgNIy6A2R0Bsge+QyVo5a3RPXEpUQbqn6FgyvKiG63vjOi4fTc6DkTNifwE44+AaJzZlkEyfcpZfervkK8XOJ+Pr4LPQjoCawd5HP4a9q277tdCXTR6tCMUu6KND0L1xydlO8f4bzJiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779956512; c=relaxed/simple; bh=zOah9N8nTMmzPPPY7FPEjRyd6MXLaOXTIYNz/SrRLj0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lwCFA5/9SJsSfkRMnCPod9cM3IUA2Rw8YB43jiJT1g+o9dxt4pwQh5zNkuNg+YsU9aZKkUSoDxcChc/A6U6VdOO26jt5D1imNQPyS48aR4wZ5RX3YsTG62znETiu5Jev58VxSr1AxrgQLPUs6+aMIGkLhjefAThwhWvvfHVcDvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cambridgegreys.com; spf=pass smtp.mailfrom=cambridgegreys.com; arc=none smtp.client-ip=217.160.28.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cambridgegreys.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cambridgegreys.com Received: from [192.168.17.6] (helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1wSVzo-000QP6-W7; Thu, 28 May 2026 08:21:41 +0000 Received: from [192.168.21.56] by jain.kot-begemot.co.uk with esmtp (Exim 4.98.2) (envelope-from ) id 1wSUVk-00000001e5R-38z3; Thu, 28 May 2026 09:21:40 +0100 Message-ID: Date: Thu, 28 May 2026 09:21:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] um: vector: avoid NULL queue dereference in legacy RX mode To: Johannes Berg , Henry Barreto , Richard Weinberger Cc: Tiwei Bie , linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, Henry Barreto References: <20260527213524.45903-1-contato@henrybarreto.dev> <21c2c12a804d662d74c3518267d90e045223583e.camel@sipsolutions.net> Content-Language: en-US From: Anton Ivanov In-Reply-To: <21c2c12a804d662d74c3518267d90e045223583e.camel@sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 X-Spam-Score: -1.0 X-Clacks-Overhead: GNU Terry Pratchett On 28/05/2026 09:17, Johannes Berg wrote: > On Thu, 2026-05-28 at 09:00 +0100, Anton Ivanov wrote: >>> So ... you're effectively saying that the tap transport has been broken >>> since 6.12, released ~1.5 years ago. >> The one I use is raw :) It is the most useful. > Right. > >> Tap badly needs someone to expose the socket which the kernel uses to implement it. I started writing a kernel helper at some point, but never finished it. It should be able to produce "stupid speeds" with it. >> >> And, yes indeed, this was broken by 612a8c8e0b43ba7e3d0e51f6f76a5fec4912d439 / 2024-07-05 which by the look of it I did not test for tap. >> > Yeah, I guess I'm just thinking that clearly nobody uses it, the > infrastructure isn't there (as you say), and it was broken for a rather > long time now and nobody complained (that we know of.) That part of the code also gets hit if you turn off vector RX or TX from the command line, so the patch is needed anyway. > > So ... is it worth even keeping it? I'm fine either way, just wondering. > > johannes > > -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/