mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Armin Wolf <W_Armin@gmx.de>, Huisong Li <lihuisong@huawei.com>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org,
	netdev@vger.kernel.org, linux-rtc@vger.kernel.org,
	oss-drivers@corigine.com, linux-rdma@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, linuxarm@huawei.com,
	jdelvare@suse.com, kernel@maidavale.org, pauk.denis@gmail.com,
	james@equiv.tech, sudeep.holla@arm.com, cristian.marussi@arm.com,
	matt@ranostay.sg, mchehab@kernel.org, irusskikh@marvell.com,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, saeedm@nvidia.com,
	leon@kernel.org, tariqt@nvidia.com, louis.peens@corigine.com,
	hkallweit1@gmail.com, kabel@kernel.org, hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com, alexandre.belloni@bootlin.com,
	krzk@kernel.org, jonathan.cameron@huawei.com,
	zhanjie9@hisilicon.com, zhenglifeng1@huawei.com,
	liuyonglong@huawei.com
Subject: Re: [PATCH v1 00/21] hwmon: Fix the type of 'config' in struct hwmon_channel_info to u64
Date: Tue, 21 Jan 2025 09:37:52 -0800	[thread overview]
Message-ID: <d945ddc0-06e9-4ca3-a9c3-c19dd9457d15@roeck-us.net> (raw)
In-Reply-To: <Z4_XQQ0tkD1EkOJ4@shell.armlinux.org.uk>

On 1/21/25 09:20, Russell King (Oracle) wrote:
[ ... ]
> 
> 1. convert *all* drivers that defines a config array to be defined by
>     their own macro in hwmon.h, and then switch that macro to make the
>     definitions be a u64 array at the same time as switching struct
>      hwmon_channel_info.config
> 
> 2. convert *all* drivers to use HWMON_CHANNEL_INFO() unconditionally,
>     and switch that along with struct hwmon_channel_info.config.
> 
> 3. add a new member to struct hwmon_channel_info such as
>     "const u64 *config64" and then gradually convert drivers to use it.
>     Once everyone is converted over, then remove "const u32 *config",
>     optionally rename "config64" back to "config" and then re-patch all
>     drivers. That'll be joyful, with multiple patches to drivers that
>     need to be merged in sync with hwmon changes - and last over several
>     kernel release cycles.
> 

Alternatively, add another sensor type for the overflowing field, such as
hwmon_power_2 (or whatever), and use it for the additional attributes.

> This is not going to be an easy change!
> 

Neither is it necessary at this time.

Guenter


  reply	other threads:[~2025-01-21 17:37 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21  6:44 Huisong Li
2025-01-21  6:44 ` [PATCH v1 01/21] " Huisong Li
2025-01-21 17:05   ` Russell King (Oracle)
2025-01-21 17:32     ` Guenter Roeck
2025-01-22  3:34     ` lihuisong (C)
2025-01-21  6:45 ` [PATCH v1 02/21] media: video-i2c: Use HWMON_CHANNEL_INFO macro to simplify code Huisong Li
2025-01-21  6:45 ` [PATCH v1 03/21] net: aquantia: " Huisong Li
2025-01-21  6:45 ` [PATCH v1 04/21] net: nfp: " Huisong Li
2025-01-21  6:45 ` [PATCH v1 05/21] net: phy: marvell: " Huisong Li
2025-01-21  6:45 ` [PATCH v1 06/21] net: phy: marvell10g: " Huisong Li
2025-01-21  6:45 ` [PATCH v1 07/21] rtc: ab-eoz9: " Huisong Li
2025-01-21  6:45 ` [PATCH v1 08/21] rtc: ds3232: " Huisong Li
2025-01-21  6:45 ` [PATCH v1 09/21] w1: w1_therm: w1: " Huisong Li
2025-01-21  6:45 ` [PATCH v1 10/21] net: phy: aquantia: " Huisong Li
2025-01-21  6:45 ` [PATCH v1 11/21] hwmon: (asus_wmi_sensors) Fix type of 'config' in struct hwmon_channel_info to u64 Huisong Li
2025-01-21  6:45 ` [PATCH v1 12/21] hwmon: (hp-wmi-sensors) " Huisong Li
2025-01-21  6:45 ` [PATCH v1 13/21] hwmon: (mr75203) Fix the " Huisong Li
2025-01-21  6:45 ` [PATCH v1 14/21] hwmon: (pwm-fan) " Huisong Li
2025-01-21  6:45 ` [PATCH v1 15/21] hwmon: (scmi-hwmon) " Huisong Li
2025-01-21  6:45 ` [PATCH v1 16/21] hwmon: (tmp401) " Huisong Li
2025-01-21  6:45 ` [PATCH v1 17/21] hwmon: (tmp421) " Huisong Li
2025-01-21  6:45 ` [PATCH v1 18/21] net/mlx5: " Huisong Li
2025-01-21  6:45 ` [PATCH v1 19/21] platform/x86: dell-ddv: " Huisong Li
2025-01-21 12:18   ` Ilpo Järvinen
2025-01-22  5:57     ` lihuisong (C)
2025-01-21  6:45 ` [PATCH v1 20/21] hwmon: (asus-ec-sensors) " Huisong Li
2025-01-21  6:45 ` [PATCH v1 21/21] hwmon: (lm90) " Huisong Li
2025-01-21  7:47 ` [PATCH v1 00/21] hwmon: " Krzysztof Kozlowski
2025-01-21  8:14   ` lihuisong (C)
2025-01-22  7:51     ` Krzysztof Kozlowski
2025-01-22 14:36       ` Guenter Roeck
2025-01-21 14:12 ` Armin Wolf
2025-01-21 14:50   ` Guenter Roeck
2025-01-21 17:20     ` Russell King (Oracle)
2025-01-21 17:37       ` Guenter Roeck [this message]
2025-01-22  4:06       ` lihuisong (C)
2025-01-22  2:52     ` lihuisong (C)
2025-01-22  3:19       ` Guenter Roeck
2025-01-22  3:36         ` lihuisong (C)
2025-01-22  2:34   ` lihuisong (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d945ddc0-06e9-4ca3-a9c3-c19dd9457d15@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=W_Armin@gmx.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=arm-scmi@vger.kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hdegoede@redhat.com \
    --cc=hkallweit1@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=irusskikh@marvell.com \
    --cc=james@equiv.tech \
    --cc=jdelvare@suse.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kabel@kernel.org \
    --cc=kernel@maidavale.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=lihuisong@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxarm@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=louis.peens@corigine.com \
    --cc=matt@ranostay.sg \
    --cc=mchehab@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=pauk.denis@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=sudeep.holla@arm.com \
    --cc=tariqt@nvidia.com \
    --cc=zhanjie9@hisilicon.com \
    --cc=zhenglifeng1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®