From: Bart Van Assche <bvanassche@acm.org>
To: Li Lingfeng <lilingfeng@huaweicloud.com>,
axboe@kernel.dk, hch@lst.de, jack@suse.cz,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: yukuai1@huaweicloud.com, yukuai3@huawei.com, houtao1@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com,
lilingfeng3@huawei.com
Subject: Re: [PATCH v2] block: Fix lockdep warning in blk_mq_mark_tag_wait
Date: Thu, 15 Aug 2024 17:52:41 -0700 [thread overview]
Message-ID: <d9513e0b-d70e-449d-95c0-99aa9a605e36@acm.org> (raw)
In-Reply-To: <20240815024736.2040971-1-lilingfeng@huaweicloud.com>
On 8/14/24 7:47 PM, Li Lingfeng wrote:
> @@ -56,11 +57,11 @@ void __blk_mq_tag_busy(struct blk_mq_hw_ctx *hctx)
> return;
> }
>
> - spin_lock_irq(&tags->lock);
> + spin_lock_irqsave(&tags->lock, flags);
> users = tags->active_queues + 1;
> WRITE_ONCE(tags->active_queues, users);
> blk_mq_update_wake_batch(tags, users);
> - spin_unlock_irq(&tags->lock);
> + spin_unlock_irqrestore(&tags->lock, flags);
> }
>
> /*
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2024-08-16 0:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 2:47 Li Lingfeng
2024-08-15 3:34 ` Ming Lei
2024-08-15 3:51 ` Yu Kuai
2024-08-16 0:52 ` Bart Van Assche [this message]
2024-08-16 1:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9513e0b-d70e-449d-95c0-99aa9a605e36@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=houtao1@huawei.com \
--cc=jack@suse.cz \
--cc=lilingfeng3@huawei.com \
--cc=lilingfeng@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®