Re: [PATCH v7 0/2] spi-geni-qcom: Add SPI device mode support for GENI based QuPv3

[Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>]

Hi,

LGTM...


On 7/14/2023 9:52 AM, Praveen Talari wrote:
> This series adds spi device mode functionality to geni based Qupv3.
> The common header file contains spi slave related registers and masks.
>
> Praveen Talari (2):
>    soc: qcom: geni-se: Add SPI Device mode support for GENI based QuPv3
>    spi: spi-geni-qcom: Add SPI Device mode support for GENI based QuPv3
> ---
> v6 -> v7:
> - Corrected author mail
>
> v5 -> v6:
> - Added code comments
> - Dropped get_spi_master api
>
> v4 -> v5:
> - Addressed review comments in driver
>
> v3 -> v4:
> - Used existing property spi-slave
> - Hence dropped dt-binding changes
>
> v2 -> v3:
> - Modified commit message
> - Addressed comment on dt-binding
>
> v1 -> v2:
> - Added dt-binding change for spi slave
> - Modified commit message
> - Addressed review comments in driver
>
>   drivers/spi/spi-geni-qcom.c      | 53 ++++++++++++++++++++++++++++----
>   include/linux/soc/qcom/geni-se.h |  9 ++++++
>   2 files changed, 56 insertions(+), 6 deletions(-)


Reviewed-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>