From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D021C433EF for ; Tue, 19 Oct 2021 11:16:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 434F160F22 for ; Tue, 19 Oct 2021 11:16:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235430AbhJSLSx (ORCPT ); Tue, 19 Oct 2021 07:18:53 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:4005 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235411AbhJSLSv (ORCPT ); Tue, 19 Oct 2021 07:18:51 -0400 Received: from fraeml714-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4HYWLT6wwcz67rNM; Tue, 19 Oct 2021 19:12:49 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml714-chm.china.huawei.com (10.206.15.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 19 Oct 2021 13:16:36 +0200 Received: from [10.47.85.98] (10.47.85.98) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 19 Oct 2021 12:16:35 +0100 Subject: Re: [PATCH v2 04/21] perf pmu: Make pmu_event tables const. To: Ian Rogers , Andi Kleen , "Jiri Olsa" , Namhyung Kim , Kajol Jain , "Paul A . Clarke" , "Arnaldo Carvalho de Melo" , Riccardo Mancini , Kan Liang , Peter Zijlstra , "Ingo Molnar" , Mark Rutland , "Alexander Shishkin" , Kees Cook , Sami Tolvanen , "Nick Desaulniers" , Andrew Morton , Jacob Keller , "Zhen Lei" , ToastC , "Joakim Zhang" , Felix Fietkau , Jiapeng Chong , Song Liu , "Fabian Hemmer" , Alexander Antonov , Nicholas Fraser , Adrian Hunter , Denys Zagorui , Wan Jiabing , Thomas Richter , "Sumanth Korikkar" , Heiko Carstens , , , "Andrew Kilroy" CC: Stephane Eranian References: <20211015172132.1162559-1-irogers@google.com> <20211015172132.1162559-5-irogers@google.com> From: John Garry Message-ID: Date: Tue, 19 Oct 2021 12:19:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20211015172132.1162559-5-irogers@google.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.85.98] X-ClientProxiedBy: lhreml718-chm.china.huawei.com (10.201.108.69) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/10/2021 18:21, Ian Rogers wrote: - bouncing Changbin Du and Jin Yao > Make lookup nature of data structures clearer through their type. Reduce > scope of architecture specific pmu_event tables by making them static. > > Suggested-by: John Garry > Acked-by: Andi Kleen > Signed-off-by: Ian Rogers Reviewed-by: John Garry BTW, We seem to be using > 80 char per line now. Well in metricgroup.h anyway, from a brief check. I know checkpatch.pl is ok with this now, but some maintainers aren't. Just saying. Thanks, John