From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C7FA1C84D3 for ; Thu, 3 Jul 2025 06:43:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751524987; cv=none; b=gya2W6FuT5qYS6A+XmFHBEa6SFOxGtifQAYI/q/Rjhdcj1w2j8rgGeifAMdHR1t9VAI0/AkwC9Y/mH61RrNW1SEnjb0AoRQwHzDjiswhfDB/sjKM1c8Yu1Dz4p+ou/fT6HU6OM0sspaBHUGPX53nkbNbE5svlY/PDzZeaxEVigg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751524987; c=relaxed/simple; bh=vg2iwTJiNNxDrQJk9ghjUNWMqhC5MEgoT67RQnthPVs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eEBlwkSIbvirBEExvMwrwAMWVxwEliqkbMhOEV7OJlHsWlTyi0CJ9PVkbXSVwMcBwjmYsXogiToaMWx1aaVD7bfvYgw/eeVpVagHy3illbY+YrN4lfF2QW5XShlq8tUabKwbinv6CGBUt/Q/mWTPhk0b9QvBY3MH/LuFI5zf6BM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=a9opwIbr; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=SGWpyY+4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=a9opwIbr; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=SGWpyY+4; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="a9opwIbr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="SGWpyY+4"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="a9opwIbr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="SGWpyY+4" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8D5DA1F458; Thu, 3 Jul 2025 06:43:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751524983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+mXypbc+hm1gV4LXs6vEAVEpiNAdYcGIxeg4GCc0Wqs=; b=a9opwIbrihxmR1SRxS2ypfYhACES5CDboCEjIDD8gSFXLbjlYz3JrdIuh84mNUJx8aPTsB /fkMs5SpnbgJJJ/ygtm70fgqDEy5Gcl75uH5LweP7dpce4TdYBNMnRAVsAcj63Yyrmev9N lc5cCpNHLIe5xzlxLk6sMxd29CtHbx0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751524983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+mXypbc+hm1gV4LXs6vEAVEpiNAdYcGIxeg4GCc0Wqs=; b=SGWpyY+47OtdjPpHpdbDaOUUkEru82/GZF80wYI+h5TGKuHf0K8DMaQJknQDIhSbQ/CM5r v14i8dKmx2XqIiDQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=a9opwIbr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SGWpyY+4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751524983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+mXypbc+hm1gV4LXs6vEAVEpiNAdYcGIxeg4GCc0Wqs=; b=a9opwIbrihxmR1SRxS2ypfYhACES5CDboCEjIDD8gSFXLbjlYz3JrdIuh84mNUJx8aPTsB /fkMs5SpnbgJJJ/ygtm70fgqDEy5Gcl75uH5LweP7dpce4TdYBNMnRAVsAcj63Yyrmev9N lc5cCpNHLIe5xzlxLk6sMxd29CtHbx0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751524983; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+mXypbc+hm1gV4LXs6vEAVEpiNAdYcGIxeg4GCc0Wqs=; b=SGWpyY+47OtdjPpHpdbDaOUUkEru82/GZF80wYI+h5TGKuHf0K8DMaQJknQDIhSbQ/CM5r v14i8dKmx2XqIiDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 96AB91368E; Thu, 3 Jul 2025 06:43:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id h1rXInUmZmj3TAAAD6G6ig (envelope-from ); Thu, 03 Jul 2025 06:43:01 +0000 Message-ID: Date: Thu, 3 Jul 2025 08:43:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 05/10] scsi: Use block layer helpers to constrain queue affinity To: Daniel Wagner , Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , "Michael S. Tsirkin" Cc: Aaron Tomlin , "Martin K. Petersen" , Thomas Gleixner , Costa Shulyupin , Juri Lelli , Valentin Schneider , Waiman Long , Ming Lei , Frederic Weisbecker , Mel Gorman , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, storagedev@microchip.com, virtualization@lists.linux.dev, GR-QLogic-Storage-Upstream@marvell.com References: <20250702-isolcpus-io-queues-v7-0-557aa7eacce4@kernel.org> <20250702-isolcpus-io-queues-v7-5-557aa7eacce4@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20250702-isolcpus-io-queues-v7-5-557aa7eacce4@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWELVE(0.00)[25]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Level: X-Spam-Flag: NO X-Rspamd-Queue-Id: 8D5DA1F458 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: -4.51 On 7/2/25 18:33, Daniel Wagner wrote: > Ensure that IRQ affinity setup also respects the queue-to-CPU mapping > constraints provided by the block layer. This allows the SCSI drivers > to avoid assigning interrupts to CPUs that the block layer has excluded > (e.g., isolated CPUs). > > Signed-off-by: Daniel Wagner > --- > drivers/scsi/fnic/fnic_isr.c | 7 +++++-- > drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 1 + > drivers/scsi/megaraid/megaraid_sas_base.c | 5 ++++- > drivers/scsi/mpi3mr/mpi3mr_fw.c | 6 +++++- > drivers/scsi/mpt3sas/mpt3sas_base.c | 5 ++++- > drivers/scsi/pm8001/pm8001_init.c | 1 + > drivers/scsi/qla2xxx/qla_isr.c | 1 + > drivers/scsi/smartpqi/smartpqi_init.c | 7 +++++-- > 8 files changed, 26 insertions(+), 7 deletions(-) > All of these drivers are not aware of CPU hotplug, and as such will not be notified when the number of CPUs changes. But you use 'blk_mq_online_queue_affinity()' for all of these drivers. Wouldn't 'blk_mq_possible_queue_affinit()' a better choice here to insulate against CPU hotplug effects? Also some drivers which are using irq affinity (eg aacraid, lpfc) are missing from these conversions. Why? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich