From: Siddh Raman Pant <code@siddh.me>
To: syzbot+bbe84a4010eeea00982d@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [net?] [nfc?] KASAN: slab-use-after-free Read in nfc_alloc_send_skb
Date: Mon, 13 Nov 2023 17:34:21 +0530 [thread overview]
Message-ID: <d9657547-fbd2-43cc-ba78-e1cf308eb954@siddh.me> (raw)
In-Reply-To: <000000000000cb112e0609b419d3@google.com>
#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c
index 645677f84dba..bc97cd6971bd 100644
--- a/net/nfc/llcp_sock.c
+++ b/net/nfc/llcp_sock.c
@@ -795,6 +795,11 @@ static int llcp_sock_sendmsg(struct socket *sock, struct msghdr *msg,
return -ENODEV;
}
+ if (sk->sk_state != LLCP_CONNECTED) {
+ release_sock(sk);
+ return -ENOTCONN;
+ }
+
if (sk->sk_type == SOCK_DGRAM) {
DECLARE_SOCKADDR(struct sockaddr_nfc_llcp *, addr,
msg->msg_name);
@@ -810,11 +815,6 @@ static int llcp_sock_sendmsg(struct socket *sock, struct msghdr *msg,
msg, len);
}
- if (sk->sk_state != LLCP_CONNECTED) {
- release_sock(sk);
- return -ENOTCONN;
- }
-
release_sock(sk);
return nfc_llcp_send_i_frame(llcp_sock, msg, len);
next prev parent reply other threads:[~2023-11-13 12:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 8:36 syzbot
2023-11-13 12:04 ` Siddh Raman Pant [this message]
2023-11-13 13:33 ` syzbot
2023-11-13 12:43 ` Siddh Raman Pant
2023-11-13 13:48 ` syzbot
2023-11-14 12:06 ` Siddh Raman Pant
2023-11-14 12:31 ` syzbot
2023-11-16 16:55 ` Siddh Raman Pant
2023-11-17 12:48 ` Krzysztof Kozlowski
2023-11-17 13:17 ` Siddh Raman Pant
2023-11-25 17:17 ` Siddh Raman Pant
2023-11-25 17:33 ` syzbot
2023-11-25 18:18 ` Siddh Raman Pant
2023-11-25 18:54 ` syzbot
2023-11-25 19:06 ` Siddh Raman Pant
2023-11-25 19:45 ` syzbot
2023-12-02 14:12 ` Siddh Raman Pant
2023-12-02 14:37 ` syzbot
2023-12-02 14:14 ` Siddh Raman Pant
2023-12-02 14:56 ` syzbot
2023-12-03 18:22 ` Siddh Raman Pant
2023-12-03 18:46 ` syzbot
2023-12-09 9:27 ` Siddh Raman Pant
2023-12-09 9:44 ` syzbot
2023-12-12 18:11 ` Siddh Raman Pant
2023-12-12 18:48 ` syzbot
2023-12-17 12:40 ` Siddh Raman Pant
2023-12-17 13:08 ` syzbot
2023-12-18 19:00 ` Siddh Raman Pant
2023-12-19 1:26 ` syzbot
[not found] <tencent_226A496623B3645B9762576606DE537BE305@qq.com>
2023-11-09 13:02 ` syzbot
[not found] <tencent_074AC2742F77F567E83C53362096E4365C09@qq.com>
2023-11-09 13:51 ` syzbot
[not found] <tencent_F3556E8C96D4E90EEEAACFF07A626DBC2D0A@qq.com>
2023-11-09 14:30 ` syzbot
[not found] <tencent_EA791774C6CBD367236D297003A84441F705@qq.com>
2023-11-09 14:51 ` syzbot
[not found] <20231109190331.107211-1-kdipendra88@gmail.com>
2023-11-09 19:19 ` syzbot
[not found] <20231110005229.2333509-1-lizhi.xu@windriver.com>
2023-11-10 1:12 ` syzbot
[not found] <20231110063236.964222-1-lizhi.xu@windriver.com>
2023-11-10 9:57 ` syzbot
[not found] <tencent_86284A9674717691670C3DBF360C96CA3609@qq.com>
2023-11-10 11:56 ` syzbot
[not found] <20231110113921.1500-1-hdanton@sina.com>
2023-11-10 12:19 ` syzbot
[not found] <tencent_EA64176726C1D373637A296B63AB444FD705@qq.com>
2023-11-10 12:47 ` syzbot
[not found] <f8bda66b-bb17-4bf8-b97a-4f7f0788d28f@siddh.me>
2023-12-09 10:20 ` syzbot
[not found] ` <aa9e49a1-7450-4df4-8848-8b2b5a868c28@siddh.me>
2023-12-09 11:03 ` syzbot
2023-12-11 8:44 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9657547-fbd2-43cc-ba78-e1cf308eb954@siddh.me \
--to=code@siddh.me \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+bbe84a4010eeea00982d@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®