mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v2] iio: bme680_i2c: Remove ACPI support
Date: Fri, 7 May 2021 06:34:33 -0700	[thread overview]
Message-ID: <d966a55e-65e0-cbb0-6c4e-4339f577b18e@roeck-us.net> (raw)
In-Reply-To: <20210507103154.00006763@Huawei.com>

On 5/7/21 2:31 AM, Jonathan Cameron wrote:
> On Wed,  5 May 2021 20:43:32 -0700
> Guenter Roeck <linux@roeck-us.net> wrote:
> 
>> With CONFIG_ACPI=n and -Werror, 0-day reports:
>>
>> drivers/iio/chemical/bme680_i2c.c:46:36: error:
>> 	'bme680_acpi_match' defined but not used
>>
>> Apparently BME0680 is not a valid ACPI ID. Remove it and with it
>> ACPI support from the bme680_i2c driver.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> A note for these is that I'll change the patch titles when applying.
> We aren't removing ACPI support from the drivers, we are simply
> removing the ACPI ID table entries.  For most of these PRP0001 magic
> will work just fine with the OF table.  That's probably the
> right way for small companies etc to use these in products without
> having to jump through the hoops of getting an ACPI ID.
> 

Ok, no problem. I'll keep that in mind if I hit any others.

Thanks,
Guenter

  reply	other threads:[~2021-05-07 13:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06  3:43 Guenter Roeck
2021-05-06  8:29 ` Hans de Goede
2021-05-06  9:28 ` Andy Shevchenko
2021-05-06 13:37   ` Guenter Roeck
2021-05-06 13:42     ` Hans de Goede
2021-05-06 13:50       ` Guenter Roeck
2021-05-06 14:31         ` Andy Shevchenko
2021-05-06 14:37           ` Joe Perches
2021-05-06 14:27     ` Andy Shevchenko
2021-05-07  9:31 ` Jonathan Cameron
2021-05-07 13:34   ` Guenter Roeck [this message]
2021-05-08  3:09   ` Guenter Roeck
     [not found]     ` <CAHp75Vfa3GT9bnimxw7EJsJyRF8HZP3PGsUNikSScuNiU4qArg@mail.gmail.com>
2021-05-08  9:41       ` Hans de Goede
2021-05-08  9:47         ` Hans de Goede
2021-05-08 15:24       ` Guenter Roeck
2021-05-08 15:51 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d966a55e-65e0-cbb0-6c4e-4339f577b18e@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®