From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66A601F1518 for ; Fri, 13 Mar 2026 08:42:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773391335; cv=none; b=u7VJv7la28hLy4QDuGc2jEu8nfkYlHv76pcCf6bQFJGkq8bpf7E36XE2d9I+PWyzEzaqgycOzMGwpMVTLVAzc3oU2d6KVJ57+helyeW6t8KlqrnAfFd9/fLHG9gUv4NAtmpwafIotKSWcU/9n/OXpyT6NYs/aCFvV5XOG+j4IM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773391335; c=relaxed/simple; bh=Ve6PiNcc143QryIJ7dyWVRwxS8jTgcoxh6k942QCyYk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=du+DE/rH8Jg6Bz4pA2ZqVUipNa4oHXth48C1gV4zgvj7In3KdEl5fX1Mjyu+Ud4vqgoQuUPpIQtxi8TZPUl2snivmN7kfBNQQsXR/URroJXAiRZW2GOKvEyvPIt5j1sPr+igfRh6P6X3Akghk6heqhEeAkJw4Wnq4aGUO38673Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IEHPwd3M; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gq3iY43v; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IEHPwd3M"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gq3iY43v" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D5tkM33342956 for ; Fri, 13 Mar 2026 08:42:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ysaCnoNXBJd5CGrL7Xb3oAj5KBlRFnMyUSTWqYDXj70=; b=IEHPwd3MKzoKEP51 LIKfGxQqvR/eLpVKJfkiATsODhEvatKFmry8eSM0wMMWVLVMy3axoLqak9C5UYNP 1cWkE3Jtf3zXOFL1mrC+ctTsnaJ3+wamp1vjoS7/cVglFftCNdSsmYQfWazYcUiM R02aWkRr/GYmP3/n4JMfzK66pa/AXH0JJvNTcsUfH7HmDUMVf47ERN9v8cy5Wp6O r/D5plU0nHHJ6TwgslupTGSlvejAWeQQA6JA34mG/odJeBnHUiAeuuzmDI+onYhL AF6uZ8ZSIcqUqirWjDzqepwXy40GWGU0fR2VhLriYgHIL+R8nJvGND1cx/RJYUmJ FlgiNg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cus9w40eq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 08:42:13 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-829942cf9deso1557970b3a.0 for ; Fri, 13 Mar 2026 01:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773391332; x=1773996132; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ysaCnoNXBJd5CGrL7Xb3oAj5KBlRFnMyUSTWqYDXj70=; b=Gq3iY43vtRSgg2Qf7C3a3VIKgopoD8OBtDsp5rfy4QyQbk3XzwyquYyClacPJv5FvP WI8KgB3+NIgocAB9vqkpLU4JtYQYlRVd+u3hqolQYs7IPWXcXWh6pPbzNtiTjaQgjq1E Lm3udcY6CVsHgn0IJqCi9p4v3jhRWBCdAn/QAqcdUFEfuB8iOGrzMFIxIGjQSYQBJLKJ wXvU4htkUe9oJ1VgQMHO+1HHb5Vx2MzY0TmVCl743uvcbFJehiY+rleA990w8AsoLAW7 0/ckHwpVPZx5pZzLW+3ghejvn+EsjONWPdHNrzjpax8ViHgbBRntc5M59WGern5/Qjam bZjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773391332; x=1773996132; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ysaCnoNXBJd5CGrL7Xb3oAj5KBlRFnMyUSTWqYDXj70=; b=HtnD5FQ0NR90ylA1Ai//E9MmRH7m9GzYYUXrWHpVQ6cInsoh3nCt0cRBHou8mr1TUL 0j4CZFJwREeKhyYq8d3VmSFNV65N6p2k+CwZip6Hf/T2+j2T2ilfAXWyJkc4g3R2JuC/ m/0yty1d6QrkL9NDZZJKQU7RZKe0dxz/61RYEG90sL8uVUG3dluFxzcJKeuwBJvX/gcM j8s8FRIdMh3MB/kyAGLnvy873INYFGlXRfVv2DDbSPIRKrT5vzj716KdsuHuMagKlDRE dXLSf5vrO+y2UzWw4gDRKhtgf1OKK8M5MfVbqMf31LIaMODQz/WjhZBOvYmVNTzw1ZjZ R+OA== X-Forwarded-Encrypted: i=1; AJvYcCXNX1lN/2PVIagqvT/UpmonpBEoiU0yOCinXrUq0OguojinG4XwuzH+xmgm0rtqJVDeT2x5VAYi64OzjXc=@vger.kernel.org X-Gm-Message-State: AOJu0YxHpqzJgXV1+1uI4RkY7vAe0nYPf88iKkPqepN0de459AlaszG7 E/KufTsvlFyrMzEwj3ms557aQcwgLRjz9/mRJR5MyZXFNTNghiaEcbEcVjLHzlR6hTaz34KaL3B 5bLzKaSV6AdUo0nMRxDq1Q5+yui0h9EIe15d1MsyQkmoiW787Rmy4yP0tXXpBzc1GHwEPrU2IFB s= X-Gm-Gg: ATEYQzzpjJbjujTtaZkhdGWMaatr6Kaz79KyIkYVTDoIdxBDRcMzG/jDY771Z7qzm41 aWCcoOnICsoF7tFZzyjvUrd1TPjFsFhhFkwSO/YU9DudQr+Rx2PFC84IvpaOHuypZSOeXegsNbl XkqLa7N+5b4+PKbDNpfhLLk0Huefj1MaiiebIQbO58oauIq7ngrf6MIbDtB6xUCfpen8ZGNEDIN 6i7GI4Y0I4rbzOrzt0d0HErnLLM+fsraNXEPDAjilE5a8vWps60Q19z5sgJ5jkpx03KUvspyVbB 7pQ2qXUbHnqO5R0vKLtx76UOBj7Z2DLMg5RylUwW+6ulTXWnvFFob1AIPkSeurIaIfzP+SeBWHc KAJ/CiKPJF02ncsCkXOmvwce/xKcbSX0JFeBr6jMF2TZmn8Q+vNoxhvl2qD7jx3cGH2c= X-Received: by 2002:a05:6a00:409b:b0:827:2eff:a29e with SMTP id d2e1a72fcca58-82a1988e77emr2262729b3a.34.1773391331864; Fri, 13 Mar 2026 01:42:11 -0700 (PDT) X-Received: by 2002:a05:6a00:409b:b0:827:2eff:a29e with SMTP id d2e1a72fcca58-82a1988e77emr2262700b3a.34.1773391331400; Fri, 13 Mar 2026 01:42:11 -0700 (PDT) Received: from [10.152.203.161] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a072414f8sm5428282b3a.4.2026.03.13.01.42.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 01:42:10 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 14:12:03 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/9] clk: qcom: add Global Clock controller (GCC) driver for IPQ5210 SoC To: Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Linus Walleij , Konrad Dybcio , Ulf Hansson , Robert Marko , Guru Das Srinagesh , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-mmc@vger.kernel.org References: <20260311-ipq5210_boot_to_shell-v1-0-fe857d68d698@oss.qualcomm.com> <20260311-ipq5210_boot_to_shell-v1-2-fe857d68d698@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: zSBfa4xXwX1UCy7AZUL6Wv2jF1cgB0B5 X-Authority-Analysis: v=2.4 cv=IIIPywvG c=1 sm=1 tr=0 ts=69b3cde5 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=xo8W07fJ9kZJw7rHU1gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA2NiBTYWx0ZWRfXxO6hFBDB10b3 x6sX+pgcRAtfwSB+K59Z1i6GjMpTivEhQIAikxPyB9GhGaRIspiIyxtf1ieIV33lR47d6T23W84 PMEvdrEex3wdRcol1Fc7oatFtcePoJhBnqAzrSoa3+ww1XbOUfbt/8ssvZrR3I6/KqNjt1qkmXc CiyIyrV8mUNQB0RlGiBRnXUX3CiyA9iOXHTOWShHPBAquN918j4YgMza1ULNYGOr4HrmNLrsU2a yDngUWdle0g3a0WrGSEoGMhpiG9f6QUORkWKbMgU1m0ezYT3ds5anz4SbcuFcK7fZEVZTvFvRNq CGBMMrk2K405pNpYphhWpkdGvuxA30MnYiYqfhWPc5lL6mbvCRFrAUK7mIwpMf+sf5TXdCuEh9J 8xm+i0kT1Kp17Gg+AtSNDYYcDuaEskKTNqhzCHq+uKHX3Vsh3lknLJzTDo8TAqM77Ts68oxsnr1 KysCxZ1CV6eKHNh94cw== X-Proofpoint-ORIG-GUID: zSBfa4xXwX1UCy7AZUL6Wv2jF1cgB0B5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130066 On 3/11/2026 8:20 PM, Dmitry Baryshkov wrote: > On Wed, Mar 11, 2026 at 03:15:44PM +0530, Kathiravan Thirumoorthy wrote: >> Add support for the global clock controller found on IPQ5210 SoC. >> >> Signed-off-by: Kathiravan Thirumoorthy >> --- >> drivers/clk/qcom/Kconfig | 8 + >> drivers/clk/qcom/Makefile | 1 + >> drivers/clk/qcom/gcc-ipq5210.c | 2641 ++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 2650 insertions(+) >> >> + >> +static struct clk_alpha_pll gpll4_main = { >> + .offset = 0x22000, >> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT_EVO], >> + .clkr = { >> + .enable_reg = 0xb000, >> + .enable_mask = BIT(2), >> + .hw.init = &(const struct clk_init_data) { >> + .name = "gpll4_main", >> + .parent_data = &gcc_parent_data_xo, >> + .num_parents = 1, >> + .ops = &clk_alpha_pll_ops, >> + .flags = CLK_IS_CRITICAL, > comment, why? Sure, let me add something like below in the next spin. Will that be okay? /*  * There are no consumers for this source in kernel yet,  * (will be added soon), so the clock framework  * disables this source. But some of the clocks  * initialized by boot loaders uses this source. So we  * need to keep this clock ON. Add the  * CLK_IS_CRITICAL flag so the clock will not be  * disabled. Once the consumer in kernel is added, we  * can get rid of this flag.  */ Thanks, Kathiravan T. > >> + }, >> + }, >> +};