From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75D6E3B19B5 for ; Mon, 14 Sep 2026 08:08:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789373296; cv=none; b=W0M9YNDz2Elr4TAt+X4jIsQLkMUCSmyIpLYCxR5hOXyKRwSmCqkKCHq4XhepjU/7kdAKs2RY27klFIkHtPuigqcGkUkEoSUMBIRNF40pe/VsSOGfEkXzATICR6r1RDO1DOfhnvmiD8V6gNVoCFM0wO6cAKSAQWbsbLNZ47nAoMA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789373296; c=relaxed/simple; bh=oI7VifzfMn1zpU+IkOS28i03E+y/fe9j1/M0UgR7+Lk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PJ0BWrmJwaopP4WAr514JZLRpVrUBuy6CbTzh6Y7M3/+fwtbBIcr4XeBbkFO9hJ6UHRyJDmrYSRVO91cnp2EzheDlJqfu3KHumS6cA4Lg4UxDBbdC6g284kz4ss2xUsO6VBGoSPGXsqTpE/tPnhyEHsJxrvUu+Z/FRw4vITGg5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=imN5fpI9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OwPAjXb2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="imN5fpI9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OwPAjXb2" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68E5jQZQ3842847 for ; Mon, 14 Sep 2026 08:08:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LrqX32EnO3d4Uq7N4G8r4oWD6xf4vvdnOcV1PMGcjmU=; b=imN5fpI9OinQuYhs Zm681p87GeCmBBbnNrsmV+rIMI3TIs9DAG63YrWCk4+cv0xplTeOssEsSTDfC3gf FCNFkRpVuiiMue+2+16QSY29pGduwe4c/flZYQiz319NL316w0em1y4KIKl06OL/ u2MXHvKc5c56927lq1UFY9JfkW6h+5Y+Z0U3tTjODp0iBg3MFfp6HGTpyanRduDA i3eyhMEZ8GiqvjdxD6f8NIqJOlbILvDpmPHlps9/YS8PZiZtAVCBD+s+XXO1GUHs xh3zfbtYP708s+YalzI0KsFeFwZirB9r+Hw/RW+tNtajftA+MONIeBeMqbQgbWRN B6AEvA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmy9c5npf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 14 Sep 2026 08:08:13 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-9103df70f2fso6512636d6.1 for ; Mon, 14 Sep 2026 01:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789373293; x=1789978093; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LrqX32EnO3d4Uq7N4G8r4oWD6xf4vvdnOcV1PMGcjmU=; b=OwPAjXb2A4xP9gygAdxqJ/Ng21PoaCCP0MOK/+uEThWHgxbCl2jw4rS5vvpVbrITf5 3RXB1XfqswCnstgHJft8RY6HlZaD4VvUMGbEcoehbX9XX7irSQzl7IpRfXk71opK2H73 K1p5dmHX68mCtw4cmAZjxfVSScJrhv65orH0Pla9OS7aBjjY6kgs+BVSeyA2d4N+5DyG ijOS1XwmwEyBLp93Sch/ujJGn6zdFAh1439S1FSK6nOEoXjaHwUTmYrr9EUAyZ8b6qyH EOCQ/u/C5zqm9qniPhosZh2w1zZ1chbdURPI2Km6APjSvWRgu0Kfow5XEj73dkXYCcAv 88bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789373293; x=1789978093; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LrqX32EnO3d4Uq7N4G8r4oWD6xf4vvdnOcV1PMGcjmU=; b=mLAisHgYSm7zseYT9tXGU7PlF/yNfXEJMZBLVi7KlS9+CKVgPVhL1fgW25SkyWhXmb Wi2b/tdzQrtLjVbuKiqAWK4rookpkSziyVLOs/HM8/0bQ6D/ZdSx8rFKo2wylPzNW4ss FSfbc64OPm5jadJKsetU+iknRDekOSLsr9XYG6Q9BhEqQGCMvj0gl/6255NnRRQ2guB9 C8+qOOodh+DDHEM0+iCtbwhgiR23/W7vBvD6HBEdWS63h/fuwdAOjojc7jViY4wOqh6K 1tEin36mrxjVdAlCtdM9bCO6R/XbmAtb8M7HUwil2BQMKhBBiOI8U1pa68BxweWdVAfB HluA== X-Forwarded-Encrypted: i=1; AKwUvBxw0T0Y2jLAx2G2AB2g18dg303lX+fC0+8O6+J5YT+taHnbtNoFq+vNVDR66talMcY33Y8KYIi4MDYW0x0=@vger.kernel.org X-Gm-Message-State: AFuF++kC1t3Eb6A476oD2li8Pt76QssFA8EkeNXgGvT8pQlpP3qCBK6b RW6NQquIirubryFQ/xcP+GB9XxyrodbtV+hJy0+q+xAKocxLl7ZzoqhSvqTQIV4IZkxxrsBxnqP e2OKm0aXkVp4h4GJQhDYEbsIysBAROE9nAhHll5ZxNljHpvYqq/NNOc2mwJbr2FL2cl0= X-Gm-Gg: AYBFou0FRv9vaAgRWQTOELt2dDosI4tgVhQbPhtQAwRu1vDZFYsysbsE+GmftE6hlio mh5Xbqx+2E0XG5S6OPbfIUR4sIrCpAQ9o8ufyhcnqAseJVoQQRxKnE/UnBlPhiJkFVAwNsdKPP5 ebmtUIBuM6l132uY+qxTqNBb8A7/aWnYtbrxIoBVxSuoiY1nwUwmOTPJNoLbeTZzZW/wHArpMjn hpKgCYH53EDa4550z5bFzeiPr1pbqXfWkId3k7hV/MU4K+QysSzSoyRpOiGSskjW5rujwNgztpl J38QB0TPA9MmRqUP6/AzsZQ709J91kb8DrifPgdipLmvK7mYfpfMv+eZAxcZh42ssRisWVbX8Oy zPpat61ldYzIBA+A15Wergw== X-Received: by 2002:a05:6214:410b:b0:90e:9616:d7ac with SMTP id 6a1803df08f44-9122e67e91dmr18605646d6.4.1789373292971; Mon, 14 Sep 2026 01:08:12 -0700 (PDT) X-Received: by 2002:a05:6214:410b:b0:90e:9616:d7ac with SMTP id 6a1803df08f44-9122e67e91dmr18605436d6.4.1789373292507; Mon, 14 Sep 2026 01:08:12 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2966067345sm391067666b.32.2026.09.14.01.08.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Sep 2026 01:08:11 -0700 (PDT) Message-ID: Date: Mon, 14 Sep 2026 10:08:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/17] phy: qcom: edp: Add Nord PHY power-on and reset state-machine callbacks To: Nabige Aala , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kuogee Hsieh Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Ritesh Kumar , Mahadevan P References: <20260911-nord-drv-dt-v1-0-e25c073cf1b6@oss.qualcomm.com> <20260911-nord-drv-dt-v1-11-e25c073cf1b6@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260911-nord-drv-dt-v1-11-e25c073cf1b6@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: aawMJBLsSwhdLsf9zNLzgmlzdZK2OZPt X-Proofpoint-GUID: aawMJBLsSwhdLsf9zNLzgmlzdZK2OZPt X-Authority-Analysis: v=2.4 cv=c5Y+0h9l c=1 sm=1 tr=0 ts=6aa7ab6d cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=vbpSL41SLP_TpwptBaYA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE0MDExNCBTYWx0ZWRfX3zYIXdJj3bmu lezFO9f1nNcXJHOnZD8SAPlvOyMUXKnPG2Z+MM6TqVpF04v9AGpqxPNeL5rti23KvwWGFIcfXaw PTmW4Q5/V1yVDLvKHik/uwEaD7umgg8WUBqNenu0NwYdvG8XYEQwDiX3jW0ChV8y2mO2syyP/8c z+/FpfDlg89U8//zr1LjiKcvRryFhi9mkvRtmlbGDZ0ZG5Iu3NPhr6lRNgKwBaHiCedphWPmGtc cYdrvB2uF1Zto6yNhiYfZO61vgLbi4ToDo3u3hnHKv34WihEb1pxSXopbIUZUbc4eboE0w2+tHq HIyNLBxbz7UhIbJxKm+cn5tqmRMGTcQ+aM7NsKQAYTcFK0b/xvBpBsU7g5RMbUv+REbC7W0g1mI k9z4jxoV/VDJ4LiEY3sy/ilNOp6Jrj2BRT4cPfFkjQkbY5uvuol6XCmBnff4EeSXZohoOPgyuS4 KfCQZdOZZsx9l9p7rcw== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE0MDExNCBTYWx0ZWRfXyWMFcfhfqN8+ zmAzmUoZ70qKfkcfhPmS/aGwFt48XKStqY0BtdT5gR24HPN/zb7kb51QCTkk2J5UzRvrdhBAlHh 5bMcFrS4R2LK760Mt3DyS5Kw05VVljE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-14_02,2026-09-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609140114 On 9/11/26 5:36 PM, Nabige Aala wrote: > From: Ritesh Kumar > > Nord relocates the QSERDES COM CMN_STATUS and C_READY_STATUS registers > so the generic sequences cannot be reused. Add > qcom_edp_phy_power_on_nord() which powers down all lanes and polls > CMN_STATUS_NORD (0x1d0), and qcom_edp_phy_com_resetsm_cntrl_nord() > which triggers the reset SM and polls C_READY_STATUS_NORD (0x1f8). > > Signed-off-by: Ritesh Kumar > Signed-off-by: Nabige Aala > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c > index 64878398f43c..6cac4b55b66f 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -1612,6 +1612,31 @@ static const struct qcom_edp_swing_pre_emph_cfg nord_dp_swing_pre_emph_cfg = { > }; > > > +static int qcom_edp_phy_power_on_nord(const struct qcom_edp *edp) This commit introduces compile warnings (-Wunused-function) > +{ > + u32 val; > + > + writel(DP_PHY_PD_CTL_PWRDN | DP_PHY_PD_CTL_AUX_PWRDN | > + DP_PHY_PD_CTL_LANE_0_1_PWRDN | DP_PHY_PD_CTL_LANE_2_3_PWRDN | > + DP_PHY_PD_CTL_PLL_PWRDN | DP_PHY_PD_CTL_DP_CLAMP_EN, > + edp->edp + DP_PHY_PD_CTL); > + writel(0xfc, edp->edp + DP_PHY_MODE); > + > + return readl_poll_timeout(edp->pll + DP_QSERDES_V8_COM_CMN_STATUS_NORD, > + val, val & BIT(7), 5, 200); > +} > + > +static int qcom_edp_phy_com_resetsm_cntrl_nord(const struct qcom_edp *edp) > +{ > + u32 val; > + > + writel(0x20, edp->pll + DP_QSERDES_V8_COM_RESETSM_CNTRL); > + > + return readl_poll_timeout(edp->pll + DP_QSERDES_V8_COM_C_READY_STATUS_NORD, > + val, val & BIT(0), 500, 10000); > +} > + > + Double \n Konrad