From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C210537A825 for ; Tue, 21 Jul 2026 08:11:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784621506; cv=none; b=sODAziDC7dqwQk53HjPHMLJFtZQHYFZ9gWSwYUs4SC/u6ZacwscqyAh3iMd5Nwi7g8vehlMxK+7nf7Dme31rRrR45ib9e/KupVo5Q42ol99Rk+j9unGMg2klXFJA8zHa00C8ENjAYqlQITRPs1jXozMmbf7GeG3UZAvoEgLTq/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784621506; c=relaxed/simple; bh=Ji6hFGQvBj2zF7FE7vbkIkExGu/cONKSyGaXjsPWo6Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eqYN3gui0Wkqs/0ZXWsAom1ffQTdA2ufiOsT5ilGiJLJ/WyVS2WxtA5a7ri/2ukbJuQkubwyfuD4yXqbBFQjPBz1c1B1C0kHipa8Ex+uiltbCs05KBIcdOHSmTGEeJXcRaiodI3Tgb87W0XZz2IwfjCvbcKt+cpid7PgGeHhFRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=b/zlQRLO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h/qFnKyc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="b/zlQRLO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h/qFnKyc" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66L7vHMG091328 for ; Tue, 21 Jul 2026 08:11:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cBqUUB9b9W14Exf/ItpHRFEySzEIgcyc3Upy0OSEqCM=; b=b/zlQRLOLRxZmV/O xm+DGgaHr0GZRPln36reUSZxtvYSMgLCH30n/Rd32nLU31No5GX0sRlQAz32xUBj qatPBMZWDzQ6r4rTHsByxN2gEIWTkYsFnoD5UTmF6gCflSvZwW2yxJ6h1ZsC6rk1 jUq1k5Hn0kA+KiKk9extp0FVgplRplLutIFhYtgs3/Z1hXfgRSzKnuj5yc1RR0mN 6cjm/hjXsRorjZ9s3AmMyKYGsAjB2LksieLGITWYXgqyY/Caohju9KtsgQ+MtVXf lwAbnUFtC/2HPy8pz1BzNs5lz/iQ3I5d0SAM4nXhzRvtCGuQ90FR4PuyyKq6JqKV RHC+xQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj01a9946-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 08:11:43 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e4ecd1ae4so166076485a.2 for ; Tue, 21 Jul 2026 01:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784621503; x=1785226303; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cBqUUB9b9W14Exf/ItpHRFEySzEIgcyc3Upy0OSEqCM=; b=h/qFnKycI85hasL+7mQYlwxg11trUKhb8jWDTTVPLZpg2mPlLPno39uv6uexVusKR1 xN88BuMZP1/r8ZwHcTIvmap/v7VWKdMBDqb+aH5NUHmLIqrVmQICdLdLAkiW01XBNh9V qLZKW40Jsr71ut2quN1EbYd4X0J4osod01PN+W930+DsmilVecvT8xM/IPC8itYuXlv+ UVgqvdgEEOKdyoxnQdVtJHg7PRuQQkBevS6WO2mvyozUVZI7Zeo63GvTKZRPbcxUfxS4 bJ6BlOdh0fIMh1v0elQhoQyK9H1ZVnVVW+27WSZ3csUfl2sHO1lsz08i1nBBIKGlPK0k S9KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784621503; x=1785226303; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cBqUUB9b9W14Exf/ItpHRFEySzEIgcyc3Upy0OSEqCM=; b=NJ5pj51h2B4yUqGKN/Svmr9S8lMZx5vvkzcmqTB1PZpcUmHICVxNWLiBJK49tF9CcM 0K4p5h9AtpurPeaOvz4ZCA9LJ4dRrDyqT5gySHxPaXmxai8Y8twJr3JlkHDjisW47fBb kXQjRGPuYUj8Sjah7g1sbgL9XLRhnmXdxPmbz8t7i9AwzLhr6+CuL7MRVbb7a8x4QYUJ v68a5ZE76ISnYLgn+JCmMJNf8BgOtPFmUCs/kFat7rZs77ETrfkoaWWnwYPPdRYeWemT skdlyHzKEGt4g2OAeFlvyzb/vveMlSDg3cO4zIwtZWILdu1E80fIJPxCtkziT2rI3Y6i 8w2w== X-Forwarded-Encrypted: i=1; AHgh+RrATuUXUNL4FTZeJMZwHXswV/8OMxDw/zmbtC4tuZzt6mgK+E9eICYTMubtektJDJkH1IBvblSYp0MalRs=@vger.kernel.org X-Gm-Message-State: AOJu0YxuKAnLyklWHQDZMQwS88toj/B/LSaTC4m78+zBIT11xAtWAxl9 rNdSDtNgO1kiBs7nfWrq4JFeROeYXTwyxgqFOHot4oQxIo1rlLYR3IXofp6Nkrnv3rx4Vtusrem WM6hj7ldiUjsRXTy+VFkNqnrRNhpLptlJ8Kwrak2XZRkyKfz7GGrZ2p92EF/28CUc/Pc= X-Gm-Gg: AfdE7cmnsENYOW1/OJhUm3x020xXfARaC3PP6XDdvePVcU9TJCD3FgrIG1iA2MPyT7G GSVtTLN29R0Dz7Hze7sjX8EG6g0Qsk8S7spAIWB4kPHDZKHBgFK4fGupb3d2n1y/6lNqYYccS+Z Jo5EQ24RUv2p8CWY9GLHgu7UAoeDJInc4fj5d2WdolakfIuiE0hd/QgImevN1hpJUpSZuP9g6Zv WuFHKMImDV+O0x3PWyLJTMjGC2xSeapblg+xLTDnQTLBv+m8X8Eyp+7HHU4DcarVy2gu9YNlIjE G1BSM8NmjWpEOLO2PKgrHPsFwD7DO4C2Ktg4rorxFYdUMNLpRngSiHc6WwewY/ZenxF4EAcXyDA OVMC4+Abt927Y66vh+j8JV8Tp X-Received: by 2002:a05:620a:1986:b0:926:e8e6:3c28 with SMTP id af79cd13be357-930b4329f29mr1587146085a.7.1784621502943; Tue, 21 Jul 2026 01:11:42 -0700 (PDT) X-Received: by 2002:a05:620a:1986:b0:926:e8e6:3c28 with SMTP id af79cd13be357-930b4329f29mr1587143685a.7.1784621502534; Tue, 21 Jul 2026 01:11:42 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1712a5fa23sm556382066b.39.2026.07.21.01.11.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 01:11:41 -0700 (PDT) Message-ID: Date: Tue, 21 Jul 2026 10:11:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] media: qcom: camss: Report hardware version via media controller To: Loic Poulain Cc: Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260717-camss-version-v1-0-7ed71fea95e8@oss.qualcomm.com> <20260717-camss-version-v1-4-7ed71fea95e8@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=BL6DalQG c=1 sm=1 tr=0 ts=6a5f29bf cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=dNYAEBq0_u_y8s8JZjsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDA4NSBTYWx0ZWRfX5PoX4dpXaQAs I8SXVG9Hgnd6yMc7DLEXqEBq24E19IX9iAiHZa+9JnCL525NHaNLcnZKiAHU8wpsIAVyzcEnkKs SmXajjmg53eXtprAlXiWVLLj7TrCB98rfXPGj/JkJiYhLItgYkd7C8zZ5yy68yn4/nBS1sJrLpX RFjsgsTituOfi6LEcos9YhXAdiXAnxehVnf74FopI9Z5LLo0TmPV8nw+AyNONZcyI77bLNIKFCE gnUCebiEK5NeBoPAuA2gaNd3pS44zENvPUHjhc6cm28c0b8jd5BITcOboSXNuvPC6aI7a+/XYvO D9QoU7jVpoveuji/QM9mpCy5vfMMVENb9BSSGAI6wGxZH2NlU4sdVUI12aZgSe1dagJ74igALGV 2fnmvR7mhirJx0nGk3HJvnJTPxIhP9uuzeSrsmoqZlc7xtHtfQGVjYg063uo0aSCUMT37XSzySS /GONHo7rD1qJEBbAf8Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDA4NSBTYWx0ZWRfXzP8hCYF2WpBd sQe4L+UvelKQhpMQ7fk+iocpFo6KFG3zZEFS0QgKH/vYlxsgyUYQ2SW7BeZw7Mp+BbkzII+4Y4B 5xqSoOuzB+hHh/g6YXUkEus3z0fIh+M= X-Proofpoint-ORIG-GUID: wB-nyCgeZEGjBC4i3-pF6-tvTBAwAC7C X-Proofpoint-GUID: wB-nyCgeZEGjBC4i3-pF6-tvTBAwAC7C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 malwarescore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210085 On 7/21/26 9:55 AM, Loic Poulain wrote: > On Mon, Jul 20, 2026 at 11:12 AM Konrad Dybcio > wrote: >> >> On 7/17/26 4:20 PM, Loic Poulain wrote: >>> Populate media_dev.hw_revision with the top-level CAMSS hardware version >>> so that user space can query the exact hardware variant through the media >>> controller (e.g. via media-ctl or MEDIA_IOC_DEVICE_INFO). This can help >>> identify the platform variant and adapt behaviour accordingly, for example >>> allowing libcamera to apply quirks or enable features that cannot be >>> discovered through standard V4L2 or media-controller APIs. >> >> [...] >> >>> +static void camss_read_version(struct camss *camss) >>> +{ >>> + u32 hw_version; >>> + >>> + if (!camss->top_base || !camss->res->pm_clks[0]) >>> + return; >>> + >>> + if (pm_runtime_resume_and_get(camss->dev)) >>> + return; >>> + >>> + hw_version = readl_relaxed(camss->top_base + CAMSS_HW_VERSION); >>> + >>> + pm_runtime_put_sync(camss->dev); >> >> I think non-sync is fine here > > Using asynchronous PM may result in the runtime suspend ("work") never > being executed if the probe function fails later (read version called > from probe). From my understanding, a subsequent pm_runtime_disable() > in the error path would cancel the pending suspend request, leaving > the runtime PM state in a non-symmetrical (unbalanced) state. Got it Konrad