From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC6AC433EF for ; Mon, 13 Jun 2022 21:40:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347415AbiFMVkd (ORCPT ); Mon, 13 Jun 2022 17:40:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234145AbiFMVkb (ORCPT ); Mon, 13 Jun 2022 17:40:31 -0400 Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BF9526DF; Mon, 13 Jun 2022 14:40:31 -0700 (PDT) Received: by mail-qk1-x736.google.com with SMTP id l192so2907819qke.13; Mon, 13 Jun 2022 14:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UlM+CjsQsvnlIzI7YJk0mgvDOIWQBkpMOR1+7OF1hHk=; b=VoS6foXu6pPH+uNF4FO1/2Kj2D0fU4up4Ag89DxC1cgBHdtd+xhTNGW8WiiUHNRRHR 39ENvgeUZF4nSJeuOUXvuWJzCdV8dmcnk+eiyc0SpFjFWWwZnXYm2G2fVTd6f2OGAWvg FIoY30Z8Lfn1EDAcLkGei3+Xz2y1KQ0TlA18AorOPy6Mf+HCCMlVUMqlDZmtpT7xUa4U dZcKQ1ZTIHHj51akLGQn4LOMZQY0H20b3cdlocbSrgmS5Md26ArwyaGnZUz/uLsetRlS dDhYp66032OHqufLh/hI4ZOScAxP9g/t7rWSskpTy9KwHzMtMO2FETpm06RAdOOoqQac c5TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UlM+CjsQsvnlIzI7YJk0mgvDOIWQBkpMOR1+7OF1hHk=; b=h6oFGlZNrCGl1hRgohndzaEE0li45RzgthwRD1d2uCOmOaraRVBpXA7ewtc/SGQpo8 DTaevQbLbtKRxU5ZBkYNkeHRU3Fko7kO19ABKuEs50EGclu3zZ3WwtFxkdGtaBo9mfhE t32Rn6CC4gV0zJ3ET95qRsP4dsEF1htL2NQ9QRjtHhkHLccFLFFR1Y+bMkx2U25vv/bO tQUOeY4uWVNyyqNBD39sa02NMt/1kZaVgaVjbh0JxQ2ih72z+oAVtDeh1B1sImdQNSMu yFkSo3f8/8vFHJDg8D5ltKKgTotCX3Qg6YGTFgpDtpY0SFb3qz2wiyrtdFDBJBap8Pte ZF9Q== X-Gm-Message-State: AOAM530S1ThlRpFhYuv8xYFgcBGNzWiRC3Fj0R/LZ6L7wUZJFlONIwp1 FNB0k6yy6LePcejrsQw2LgE= X-Google-Smtp-Source: ABdhPJwyEVaKmQX/qbSw6rap8a7P4wMumpVUdU6UeAYUevHyF5Ku6BkvK8tVjJLtP84AZRb0VGz3/Q== X-Received: by 2002:a05:620a:22d3:b0:6a7:2202:62ba with SMTP id o19-20020a05620a22d300b006a7220262bamr1725887qki.148.1655156430164; Mon, 13 Jun 2022 14:40:30 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id r145-20020a37a897000000b006a760640118sm7130943qke.27.2022.06.13.14.40.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jun 2022 14:40:29 -0700 (PDT) Message-ID: Date: Mon, 13 Jun 2022 14:39:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] net: bgmac: Fix an erroneous kfree() in bgmac_remove() Content-Language: en-US To: Christophe JAILLET , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Florian Fainelli Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org References: From: Florian Fainelli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/13/22 13:53, Christophe JAILLET wrote: > 'bgmac' is part of a managed resource allocated with bgmac_alloc(). It > should not be freed explicitly. > > Remove the erroneous kfree() from the .remove() function. > > Fixes: 34a5102c3235 ("net: bgmac: allocate struct bgmac just once & don't copy it" > Signed-off-by: Christophe JAILLET Reviewed-by: Florian Fainelli -- Florian