From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA8CE403E96; Thu, 4 Jun 2026 11:32:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780572754; cv=none; b=usCDSjOPle0L8hfTg5RoZ+75y0VJlansI6FTNDyP9x6tOWwHCgKgO5NX8epiX74nXutgqO3sBQP1lLAt1Iz0VJ38BdjNtXgF9kj46Fcjwa5SyaZhCnEdo7eXcBounulnPM45O3LTEMIX0pn6jf6HHxt1JLHtDgbT3MfEmlGPkFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780572754; c=relaxed/simple; bh=xgYhSIRkRCyGHcQ00YeIGdZi+nwkSmB8ruuyjumdStg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=AgB5egjH0o4JWiu99jh2O+tsWLDoZAtG18usVZq18ymx+TgkcfsGPTXhZQ8L9ZhTDqBNo8jSY7lUfl6wUQ1GCqy5+cuzHQpsokMqrbyTJ7nKWDl9zWPysGRiAVMHCcpjL+KMtISKV25oHAlKxdhANNJTPAzIGMaAcdyehlsiEtk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=permerror header.from=sipsolutions.net; spf=none smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=Nw1A/aRp; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=permerror header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="Nw1A/aRp" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=iwSQI2qEXuEwf5G/fvDUmnFuMZLEfDqOI0sQhCWIuV0=; t=1780572752; x=1781782352; b=Nw1A/aRpzvrGf4NAvyKc7HURcurB9bai8fiYy6hhiTtQCgA UxVDq1Sndea3eqF/S4+S4KfCOaXW6GNV0jodHQl8swlqWAqgm9YDmlIgtouWAvSbm+Tk6PemWOpqE NtND3ZznGs5blzzPIPq/Zla1gnBV+iLdY43YXbXswYWtl2M5xwzfPQ+bnM+LVGJUyIcgWUFpF1TEL O4G0HxoX9qLQUHdfgM6uTrrLSAMW5LPiWrirk32je4YF8eaM3hIxJoZgog7+WFIicap1folotoEhH zUwO6WR5CrPeKH96pTgbY90fQsb5k50HUbDyhVLw0+XuxTPK/fUbUrl0SijAeiww==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from ) id 1wV6JJ-00000000SVz-3cDW; Thu, 04 Jun 2026 13:32:30 +0200 Message-ID: Subject: Re: [PATCH wireless-next v2 02/31] wifi: mm81x: add command.c From: Johannes Berg To: Lachlan Hodges , Dan Callaghan , Arien Judge Cc: ayman.grais@morsemicro.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 04 Jun 2026 13:32:29 +0200 In-Reply-To: <20260430045615.334669-3-lachlan.hodges@morsemicro.com> (sfid-20260430_065648_587462_38077D88) References: <20260430045615.334669-1-lachlan.hodges@morsemicro.com> <20260430045615.334669-3-lachlan.hodges@morsemicro.com> (sfid-20260430_065648_587462_38077D88) Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Thu, 2026-04-30 at 14:55 +1000, Lachlan Hodges wrote: >=20 > +#define INIT_CMD_HDR(_req, _cmd, _vif_id) \ > + ((struct host_cmd_header){ \ > + .flags =3D cpu_to_le16(0), \ nit: you probably don't need the zeroes nit2: maybe you want to use tabs instead of spaces > + if (!cmd_q) > + /* No control pageset, not supported by FW */ > + return -ENODEV; have to say I'm not a huge fan of this style, it always flares up a warning in my head at first "are there missing braces?" ;-) johannes