From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6AF7C10F27 for ; Tue, 10 Mar 2020 14:11:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 883C520674 for ; Tue, 10 Mar 2020 14:11:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727218AbgCJOLW (ORCPT ); Tue, 10 Mar 2020 10:11:22 -0400 Received: from mail.itouring.de ([188.40.134.68]:51186 "EHLO mail.itouring.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbgCJOLW (ORCPT ); Tue, 10 Mar 2020 10:11:22 -0400 X-Greylist: delayed 523 seconds by postgrey-1.27 at vger.kernel.org; Tue, 10 Mar 2020 10:11:21 EDT Received: from tux.applied-asynchrony.com (p5B07E2B3.dip0.t-ipconnect.de [91.7.226.179]) by mail.itouring.de (Postfix) with ESMTPSA id D06EA416B9E5; Tue, 10 Mar 2020 15:02:37 +0100 (CET) Received: from [192.168.100.223] (ragnarok.applied-asynchrony.com [192.168.100.223]) by tux.applied-asynchrony.com (Postfix) with ESMTP id 7AF8EF01606; Tue, 10 Mar 2020 15:02:37 +0100 (CET) Subject: Re: [PATCH 5.4 000/168] 5.4.25-stable review To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: linux@roeck-us.net, shuah@kernel.org, stable@vger.kernel.org, Paolo Valente References: <20200310123635.322799692@linuxfoundation.org> From: =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= Organization: Applied Asynchrony, Inc. Message-ID: Date: Tue, 10 Mar 2020 15:02:37 +0100 MIME-Version: 1.0 In-Reply-To: <20200310123635.322799692@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/10/20 1:37 PM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.4.25 release. This fails to compile due to broken patch 001/168: "block, bfq: get a ref to a group when adding it to a service tree": .. block/bfq-wf2q.c: In function 'bfq_get_entity': ./include/linux/kernel.h:994:51: error: 'struct bfq_group' has no member named 'entity' .. The calls to bfq_get_entity::bfqg_and_blkg_get and bfq_forget_entity::bfqg_and_blkg_put in bfq-wf2q.c need to be wrapped in #ifdef CONFIG_BFQ_GROUP_IOSCHED, otherwise the build will fail when CONFIG_BFQ_GROUP_IOSCHED is not enabled. This horribly error-prone #ifdef mess was finally removed in upstream commit 4d8340d0d4d9. For 5.4 we'll either need that as well or add them back. -h