From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C7BD3126B2 for ; Wed, 11 Feb 2026 11:51:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770810665; cv=none; b=pF3vax/SDhwBC+CZMqJMSlAPqxgFmdwHeR3X7tHoaF5mCZtz2olf63FkAuRFUM5Vwn771egzH+C5pd8sP5R/fiFrv7T8+kQtDj3fPjeWHO888OzPlQVHS8MBtRW0hTZVHh8OBVeKelXT3pdILhnGYJ0CGyU7hK1v0j4KFQNLIc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770810665; c=relaxed/simple; bh=Y1GRaTb+Cluqy6zy9whCvgKV50Qh0FqspXSE8R7HZ7Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GT1BBrjpCYechdVE95vxmu6spV/34Coqa/8qC4gqTjjnEKehzAtEBWetYSVWPAqvzFi3mfA6o0e969SqOLUxdEQAyRv9TFN6uXrPqyqZYIuNkgp4oDU1pUYdSHLN+M4zb/fKwz1WhA+XfrLeSvoDuyfQKIXrsL+tYbnLqbcnYgI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CFTGDkli; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VydUHVGK; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CFTGDkli"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VydUHVGK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770810663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RhSjZw86q7JLL8KRuEhtDk2hOfqYGgb3WkEvn7xqpfk=; b=CFTGDkligYSXLCiP9M57emplBlwqTcJhS91Xs6OZLaHU4XGjLXAyGZtZ9GYGOwzmUDRRdc 7nn4EcapSvTRD1XYrsitu8WNkfigP/32Fj0YWDXqNPSyKAlyLDRaj3sgtldorFiaspA2qO GPJRl8Pb/pN5/4XlsCqzvoBTU72epJ0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-eBPKy9z8PAiXxOuO-Xy_jQ-1; Wed, 11 Feb 2026 06:51:01 -0500 X-MC-Unique: eBPKy9z8PAiXxOuO-Xy_jQ-1 X-Mimecast-MFC-AGG-ID: eBPKy9z8PAiXxOuO-Xy_jQ_1770810661 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47ee432070aso48112755e9.1 for ; Wed, 11 Feb 2026 03:51:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770810660; x=1771415460; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RhSjZw86q7JLL8KRuEhtDk2hOfqYGgb3WkEvn7xqpfk=; b=VydUHVGKvbWGpKLFalSVT/DRb+mZFIC++bXDGH2GigWl99JcSPoTTim/2dCyHEvBp1 EucBenZI4XDhBoEBzUH9U4efFxoVgJ46zIUtWqwpWxZ7e8psOmRgkSBfkl8ebbBVVBXn 4FGTy2goVa/QtFKDsRVkDyCKArcwXDbdYU+/XZJvEDZgR4uTvxhYjy0JY5PXpvqR0JlR qHJjmziIbpH3qRHVQGSaDrFDljKVhX9t88wPd5D0mEpCRWrTiBXpTvUbtqjdcDTlx2Gp bOoc6RLED5ekIpFaLOhnTWqa/nv4Ov7PYROWOja92UfS1Yo+xqL8CvFlCHu86uNZplE4 Ptww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770810660; x=1771415460; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RhSjZw86q7JLL8KRuEhtDk2hOfqYGgb3WkEvn7xqpfk=; b=g65O8pR0VlaibEIfpItwtDD8XhbP5Y5phufGBvW0TSOdTUhxe52ffP+SGpG+kqzuar VTnuqu7LEHAQOqacGBWLPfgwh7zUNnh7FQFeGRLTS023kk6vhrnJTkdjVcL1RpGqhzzh /Swuj8a0Hc7f75fDUNfOrAIXY16j8uq+WqYPAZu27h2sz5viBwMFGYl+Ms/ePLhMLdk7 aPSulaTGnzZqL3/RaEymj0Xuecgi3bNgri5I90B0+9/b9Y4QBkNiOsN/Lx8WJQXZrFXH 6cpkoQMTErHrUm4pls8cXq+zEXfgHI59D9JgR1kcXjVLfRjPzT8TM7xbOOK8Zhf/taKE 0jrw== X-Forwarded-Encrypted: i=1; AJvYcCXSqA06mSyw97TIeuIcbvKPv1Tkqz9bNgecP+VSY8gT5+9eSJsmrjo8s9XXrHoyPB3ARylRrhFpVdjzSnQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyOvSpqG9f7qrDBBwIMrVRjG90M9REU8TTwH5HC96BiSb6jKbEX R7AFAnXNoXo1HV5VvMQRBFuByuZblKv8iEaSgGFHCFEk0XvDcUn6zJ/gTTlMfUpWCrzCS23h0x1 OP9zyVQe7Tc7hyPbuUWohTNwFajbPncOyZNzzaMEuqi9hwKI0AtYQ0qUGeUzMuO0btQ== X-Gm-Gg: AZuq6aKiUQlZlOdIE2eyXleztGoSeT1kXbFnRpQV+EWdk5+vRxK0o/IqDa+ODqdUxim WiQGW0MV7twaQV94eV6isUTxBgNohrf/6C8EYkgNJkfV1TUu8ZP3mZgyD+opOe5m8RyHAwMzKTB MJ8VedbJFsgst36EJeS46C7/+V8KnWaSTlDyb96AI6kjQvOPgdojwWW79vE2GJF1z8vsMlEDa0P TpvMyObvqN3PxjPskrJ1GVliw88QbMsVgkIJuOaqXIzEcUykzt7yXxkZYl+rFmw+Cg/82y/8cW6 HusI9EbSryBpa3CeWP+QfkmSurAdP8HqLVhoBN6N5kOGNjXj9ynxDAcRafW9fU++FMBLBZyt2fp SfJNGyXNMfEm9JpjdcEepvXg3NQ== X-Received: by 2002:a05:600c:3baa:b0:483:129e:b573 with SMTP id 5b1f17b1804b1-4835b952e38mr29532755e9.18.1770810660586; Wed, 11 Feb 2026 03:51:00 -0800 (PST) X-Received: by 2002:a05:600c:3baa:b0:483:129e:b573 with SMTP id 5b1f17b1804b1-4835b952e38mr29532495e9.18.1770810660222; Wed, 11 Feb 2026 03:51:00 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.220]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d82a4c4sm226143895e9.10.2026.02.11.03.50.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Feb 2026 03:50:59 -0800 (PST) Message-ID: Date: Wed, 11 Feb 2026 12:50:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] iavf: fix deadlock in reset handling To: Petr Oros , netdev@vger.kernel.org Cc: ivecera@redhat.com, aleksandr.loktionov@intel.com, shaojijie@huawei.com, Jacob Keller , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Stanislav Fomichev , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org References: <20260207102245.812795-1-poros@redhat.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260207102245.812795-1-poros@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/7/26 11:22 AM, Petr Oros wrote: > -/** > - * iavf_wait_for_reset - Wait for reset to finish. > - * @adapter: board private structure > - * > - * Returns 0 if reset finished successfully, negative on timeout or interrupt. > - */ > -int iavf_wait_for_reset(struct iavf_adapter *adapter) > -{ > - int ret = wait_event_interruptible_timeout(adapter->reset_waitqueue, > - !iavf_is_reset_in_progress(adapter), > - msecs_to_jiffies(5000)); AFAICS, after this change nobody waits anymore on reset_waitqueue, do we still need such wait queue head? I think a bunch of additional code could be dropped. Thanks, Paolo