From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 022EE2BE642 for ; Wed, 25 Feb 2026 07:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772004084; cv=none; b=mMd6dtXZg6c8HS5UtZ+WwtyjjL9schwW7Abvh/lxed5/yAUcn7k01PAkMBPilANCZPj6Yo/hYiEGmPrxwIHxAFsqk/dbMo8mNsOmJm+wCIx9Ax46objgNAaG5rwaJ1GmJEAEsIITQ54bel/56SZhe9CDX3YEX97a73UjFYXZfJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772004084; c=relaxed/simple; bh=SXGrHfYGpnKlnB5cx1WRRimppH2xErUvy8ZajFe5uX8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JspD4I0amPBxa9INR+WIKDw9TLY0mn8PQsHklsmaDb4XJyYIDgyssQIq1ZCf5PIsgL+xZl0TKlIzAMFWyzJHK8GeNhio29pURu3BnquDJ/imYBFfz0J3ecz+TbeBg9LTtBcwwuC0YfmCUtfcQihIvikQMQgCR+otYmADHK4RGnY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=k+ckSWzN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AM72hXJH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="k+ckSWzN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AM72hXJH" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61P3oxMI3333651 for ; Wed, 25 Feb 2026 07:21:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EyqBXnvRENyJjfa/hP0ua/tVCf9aQxn3tn6/9tsNVKs=; b=k+ckSWzNiDBGpJdz TjcqYDz6mdxeW3144wHmT25KmFC6TEak3O1DiwY17BzkNh1WBBg+YZlM9uofuG9n 1nGvBoc1ywzujMzN6uYU7O5OO0hD7fPPT5VDd/Szr2XAHqcreKcnvEJtXjyfcaf4 1q00uBB1QLkML4xfN3NbEv5Y21i9eD8TGfB7qMm46EWFMWSoWlyJ/T7NDMjyD3yO qoL5AkHgLlFaaKji6+5tl2IzgRqKwyFsA5awyDPOBKOPIUjDCcDESnBhhsefy9WB bt1NXVcLmWYOkkU1xDlpJCAtvWTWKPAu9Cxx1ngfeHf63VQXxva/hMGa5Tvq9Y85 faEGCQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chh4721km-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Feb 2026 07:21:21 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35449510446so6418615a91.0 for ; Tue, 24 Feb 2026 23:21:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772004080; x=1772608880; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EyqBXnvRENyJjfa/hP0ua/tVCf9aQxn3tn6/9tsNVKs=; b=AM72hXJHzkSJlYwyQ4JWpYgYRuMi7wc3QE13BHyB9dtTsWZFkNZpZF6pnTUu1dw7Zn SFrAbNxk+CzYYe5kg4xVuex/ENfOlJLhy0hYBWrlvxmVMgSWlgRHKP1BvVDXGQVER8gP i87hCNT3iqszKWoyxJrKoogrOfVFEaIr55foKWpssrtWcQIqs7ZWkTtGld5gy8QvQIoA +5vztJ8HWLVaiZQfpMAg462lMWoIqJLYZkj6NsFHV8vL2xwssP3JfJekO63Ibqt0xBEs KfevOQ2wiolx/V32FopszHh6hdEe7Jc3rv0I09Pw6cTCshfDIqDZW+dpnyBJY1oicsbd MBQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772004080; x=1772608880; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EyqBXnvRENyJjfa/hP0ua/tVCf9aQxn3tn6/9tsNVKs=; b=TM9vQsiWyKMJlC3MJNAYMH8zzPkiRLHVtvpZ2Lrz/b28LIwLgHby+0f74IhLVyKE0b UpxGciIrnfRla77tkFOyKMUBnBcIkos3wPpAd5fozM5ljZhfa7W7T4r3HP9LItGUEz0H j1ZYuiLXPO3uVA8gx0bfwTGzw49MWlNRk+VQGFRZnMsM9R4ouS3Ss/6CimvxS2iDsm3H 8UOI7ss0igjFTjjRxymOnTT4f7c9erv+/4TiL8TzHFoh/EE2LMrF5/LQ9E6iYxnMQ+Qu 6PaGQyKRjrOikvaZD0vdgOPy8Tw1muAL+yrgMM6lOba/QhTFY8HPEFbFIKVNJabzHR+h aEPw== X-Forwarded-Encrypted: i=1; AJvYcCXx/9UlvJD5q5G8YK1MLXuC2Vx4gO3S/fXRTg3qhlkBYpaEagio97r3sQGztMZPtKUZ8kSR0WrKbjWLtNo=@vger.kernel.org X-Gm-Message-State: AOJu0YySXV/66mQfNM6BnblvAlIqx0ZZxqmgYhZhsG5j25bvHOjibGYY hOQ2cnk5oEdR/6iiW0bY3YWfcaR9ZxgZYfVnOn+Yy5xC30w01o7ryZ5Caz+nJZqew5G2siAETQU T7+pGx5dAAc5lbhLyiHaOuQR3Iww32+DQWpoUbyzKT55zb2vjayQGVsdkSpJkpsLFM6w= X-Gm-Gg: ATEYQzzBE3Ai03ivR12EdksHVHdzTWQGLjWg+FlABp/hSkyWo9/HwwTwIjRt0R+hzBZ RslKp+Ddagi6cqWhyZ/dad9aJpDBSuo8gpEiR5BhCw72srgsvc/jwXzGcU4WTqG9uXnpxIgp6gd yorl42Y7tW3jr9ST9B+YM6Sm9OzIE+eJlGgxIZDNqvMQvG9SFWw9rwnNGZFCptNvivu47tnpA0N Jj7Ec6ivceAaZw3lm8GL+nJNt6Er/DY/LdAkJ7qv6pYyNNjG4i7L3tKrB0wbXfHYNQ+xofIk26c 8XUx3AHs7I9BNfA9+uUvIIgCE6nHxL8IArhoiSWLJU3jdLx8SD7KDEUGCbvd7C6Emh9+e5+AMjN 5wUSrneIR+xSRPsS2H6OKQuOlhADPOgtIz39SmR0v/FYAKu7sICRgTg3X9HE5/KWV6nOVfoE6rL 39tiD0 X-Received: by 2002:a17:90b:2812:b0:354:a9f3:68bc with SMTP id 98e67ed59e1d1-358ae8e8390mr11691748a91.30.1772004080540; Tue, 24 Feb 2026 23:21:20 -0800 (PST) X-Received: by 2002:a17:90b:2812:b0:354:a9f3:68bc with SMTP id 98e67ed59e1d1-358ae8e8390mr11691731a91.30.1772004080064; Tue, 24 Feb 2026 23:21:20 -0800 (PST) Received: from [10.133.33.74] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35912e19c4csm739217a91.0.2026.02.24.23.21.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 23:21:19 -0800 (PST) Message-ID: Date: Wed, 25 Feb 2026 15:21:14 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] phy: qcom: edp: Add per-version LDO configuration callback To: Konrad Dybcio , Vinod Koul , Neil Armstrong , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> <20260205-edp_phy-v1-2-231882bbf3f1@oss.qualcomm.com> <200b055b-7221-45b5-aea1-2462e07a3c1c@oss.qualcomm.com> <8dbc18a0-6a64-491b-84b0-ba220c9050ac@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 8-l2UReHy-f14bxd4w2Lu76tdOFYz29w X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDA3MCBTYWx0ZWRfX0NzQafm+XeqQ QuXLIvLM3I7GrNv9o8TAqYDZPDTR6Wo5359HtQru1lmCAsYOJ+BTgqVWRgoMVBcqtVQMxozha7W uPbDon6bnc7U6Lf311WbZ/GSmohhgPKVceN7udEnwoUW/KYfOAn1op7kciejm2ycScYgdJqJoiB QcswWUfJ9JBJhDdFGUXAqOq8j0GnPB+i+ugwQLdnefMcs5kW9qnXG9hs5AOlu+CAoQZHfp8EJSz LEKlz8YdpjjWl6D6kCxR6UGffg54dFZBnHrqCo+/Ka9zWdVQKtzrZovDuXnDINsSk5rsBwIMCXk DaTgr78C8c7tV89OZGezpijfr/8fAjTMLmkbuutvqyeUGbGJa/ABB/m0ncopqYAYWT9G5ei6pHM leoIe76wzuThfxG22tWyfgWZfPORYunQDnkB8kyicTfqd0BXu+DTJBB6sHAb8bFV49FDPZKUwve udtk/1QIzzyyUCBnUcA== X-Authority-Analysis: v=2.4 cv=fvDRpV4f c=1 sm=1 tr=0 ts=699ea2f1 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=Ywmpiw0kLQgVKrmd7HMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: 8-l2UReHy-f14bxd4w2Lu76tdOFYz29w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_03,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250070 On 2/13/2026 7:14 PM, Konrad Dybcio wrote: > On 2/12/26 10:04 AM, Yongxing Mou wrote: >> >> >> On 2/6/2026 6:52 PM, Konrad Dybcio wrote: >>> On 2/5/26 10:20 AM, Yongxing Mou wrote: >>>> Introduce the com_ldo_config callback to support per‑PHY LDO >>>> configuration. >>>> >>>> Signed-off-by: Yongxing Mou >>>> --- >>> >>> [...] >>> >>>> +static int qcom_edp_ldo_config_v4(const struct qcom_edp *edp) >>>> +{ >>>> +    const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts; >>>> +    u32 ldo_config; >>>> + >>>> +    if (!edp->is_edp) >>>> +        ldo_config = 0x0; >>>> +    else if (dp_opts->link_rate <= 2700) >>>> +        ldo_config = 0xC1; >>> >>> lowercase hex, please >>> >>>> +    else >>>> +        ldo_config = 0x81; >>>> + >>>> +    writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG); >>>> +    writel(ldo_config, edp->tx1 + TXn_LDO_CONFIG); >>> >>> tx1 should be dp_ops->lanes ? 2 : ldo_config : 0x00, in all cases, >>> I believe >>> >>> Konrad >> Hi, here i want to confirm again.. In the HPG main link brinup sequence, it not say write TX0/TX1 ldo_config based on the lane count. Only when we switch the lane mode,  the LDO config will be updated according to the lane count. so here do we really need this condition? > > I don't believe these two cases are differentiated in your patch, unless > you're trying to say that the hardware is smart enough to turn off the LDO > for TX23 on its own as we switch modes, which I wouldn't bet it is and can't > find confirmation for > > Konrad Got it. will update next patch.