From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD0CC7EE23 for ; Fri, 19 May 2023 23:02:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230504AbjESXCS (ORCPT ); Fri, 19 May 2023 19:02:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjESXCQ (ORCPT ); Fri, 19 May 2023 19:02:16 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A60C99 for ; Fri, 19 May 2023 16:02:15 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2af2d092d7aso799601fa.2 for ; Fri, 19 May 2023 16:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684537333; x=1687129333; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7ICfQVhv0p58QRGm6Ofs09fgKjfcNCD6otbrYwwYRjw=; b=k9H9/XI3c4gYLXp82YhPCxKp/bDxz6SLs54kVqVsH58rAVBFtDinul2AXJ4edC47fj nKbery7wfrU4P9uk2IJgPBl3Fjdr7phb96CXmFwjNSPMLGxh1IVMXyRmqV31yuFyfZoM 7jc+hyKKcb3efWrPCnY+pwHfbjLrL8lYZAha27UWnTXjswT7u3SXRwa+yDiwxCJyXG5y FsnGNwxdnMS6EH1orrvTh6JDIUfouHrBU0mUd54t4lZcvgGwCcyNJ2VFo4E+SpxkHuSv KLF+Lp2TPkzxtmpmWsLk8N3ZCmFsRVTr3CJUN17MXA07WLu1RKvXM/Tol4dUd9C6ntbh A4jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684537333; x=1687129333; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7ICfQVhv0p58QRGm6Ofs09fgKjfcNCD6otbrYwwYRjw=; b=Zcy2OexLnQWY0tvlp8I5rLCYQwF1wJD9sGkyAbF4qDcqPz6jUGdyrisaTBWP5S/f2l x53ivrj7ujrXk2/mYPKe5xV7tgNq+Rc0FX78gMH3ALRFXcDEi2bwX+YTIAQjfSFmIo8Z BKI5UIJqMqQz1/ngMWJyZknOdzlsXC6y8LSm3BNChu3uaJ7Dfcy5ebrMpLnVPcwW0Wac 3B4kJ8c49N07T1de1nWWssLzNstCDO+BlJmxgN4lsB+8t6P0m0TNpBfCY9YBIqNrSVHo 6Pdq0OmD81t0LP4rphgOjApGXe1OJLE7iJaQDS+SKn8CAKZmwK77GHhX7HapXRI5HiHl nUuQ== X-Gm-Message-State: AC+VfDx5wlFbK4wBPESOlS5qDCk/u8PkTWcVfJ87Y7nirBRvIfXrFsJX QJuZOzZMzMIGtqqJnB/jqDpawIeTJefLEWaOcc0= X-Google-Smtp-Source: ACHHUZ7UMqHk5rENqq9JMQbX9ZqRDgPSQuGZy96/uT1vIZP+8fQjGpkcjjF1D/yArdvq6XYMW8UwDw== X-Received: by 2002:a2e:9117:0:b0:2ad:af50:6ecb with SMTP id m23-20020a2e9117000000b002adaf506ecbmr1397207ljg.14.1684537333678; Fri, 19 May 2023 16:02:13 -0700 (PDT) Received: from [192.168.1.101] (abxi58.neoplus.adsl.tpnet.pl. [83.9.2.58]) by smtp.gmail.com with ESMTPSA id k1-20020a2e2401000000b002a8c2a4fe99sm34178ljk.28.2023.05.19.16.01.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 May 2023 16:02:00 -0700 (PDT) Message-ID: Date: Sat, 20 May 2023 01:01:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] drm/msm/dpu: Set DPU_DATA_HCTL_EN for in INTF_SC7180_MASK Content-Language: en-US To: Abhinav Kumar , Rob Clark , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Kalyan Thota , Shubhashree Dhar , Raviteja Tamatam , Krishna Manikandan Cc: Rob Clark , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Marijn Suijten , freedreno@lists.freedesktop.org References: <20230508-topic-hctl_en-v2-1-e7bea9f1f5dd@linaro.org> <56ac76e8-e5ac-3712-1e07-ad6c5b96c77c@quicinc.com> From: Konrad Dybcio In-Reply-To: <56ac76e8-e5ac-3712-1e07-ad6c5b96c77c@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.05.2023 00:00, Abhinav Kumar wrote: > > > On 5/19/2023 11:49 AM, Konrad Dybcio wrote: >> DPU5 and newer targets enable this unconditionally. Move it from the >> SC7280 mask to the SC7180 one. >> > > You mean DPU 5.0.0 right? Yep! > >> Fixes: 7e6ee55320f0 ("drm/msm/disp/dpu1: enable DATA_HCTL_EN for sc7280 target") >> Reviewed-by: Dmitry Baryshkov >> Reviewed-by: Marijn Suijten >> Signed-off-by: Konrad Dybcio >> --- > > I have cross-checked all the chipsets affected by this and confirmed DATA_HCTL is present and those 3 registers programmed with that feature bit are valid, hence > > Reviewed-by: Abhinav Kumar Thanks! Konrad >