From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751268AbdJWHyg (ORCPT ); Mon, 23 Oct 2017 03:54:36 -0400 Received: from mail-eopbgr30132.outbound.protection.outlook.com ([40.107.3.132]:14708 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750746AbdJWHyd (ORCPT ); Mon, 23 Oct 2017 03:54:33 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=romain.porte@nokia.com; Subject: Re: [1/2] pmbus: added tps544c20 driver with trimming support To: Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171020103916.3309-2-romain.porte@nokia.com> <20171021162048.GA13173@roeck-us.net> From: Romain Porte Message-ID: Date: Mon, 23 Oct 2017 09:54:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171021162048.GA13173@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [135.245.212.4] X-ClientProxiedBy: AM0PR0402CA0028.eurprd04.prod.outlook.com (2603:10a6:208:15::41) To HE1PR07MB3499.eurprd07.prod.outlook.com (2603:10a6:7:2c::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 27b47353-fd4d-4d64-b123-08d519eb4a4e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);SRVR:HE1PR07MB3499; X-Microsoft-Exchange-Diagnostics: 1;HE1PR07MB3499;3:E3gz5VrDOK6zzjOCDB58u3Ebo3KMl0tE4pUKuxhRnYVd/e49Ea7v68gWxVjeXIU4bKGZuhwIwFoN+R6cHnfN7decWqgJwIcOT3Vo7rziZ1Kd8BZU3I32+XGOCvXkOnAx8S0ar0h4g7UJFBIQiKRaD/Qzpwcae0X5uctSfnztp92saOfU4hZAa7NK3IgIVwt91GNWfN0bA2ebJFwLFEdeh23SEjxEgNYxWnsrre7lzcVo4uKhyCypuwdjIXLTWUw6;25:AiiPf+vn2A4GfJ4eRf4rTUj/jS1itpxL9M5B/o2h8DNAPx8BManfW2Ab8QcR+9z53MuTfUgflkfubgfFTqeqkMasium8TqGJbbGDRR43l4dsf4mOpuoKTTzU/1eM5WaifkpWhbmXThfvMfAbRHiJ5bqJ94EIsT/LOeBCpOS3gE7uwdwXAkPUwcMDd6XuIiLabNMRCLpnW7hROGernoyvJbShvhKoCyOH89+NRY8/OOchQiwI5mX4vPiVfx/Yz7QkyNRhsKqhKZs3RGoLmxMph5XsMcze0y69ZDTgjZC5Zzp2y4+roA33r4tUylxpnXYkuwjKgcQ49CcvWxpg63MMHQ==;31:opOmddTaLm0dUurgNaxIFt2TMP681WwxgWu8QLe/JkW6/v+uB1D0fMjcW6SWmzFFS1GWT4aIJBGzSJcQDSsZEOkt6JA8xtlDEYU9H/sg6N8aC6ky7Xaxy0RQ69Dd/UYJw5lhHnopJN+2gXuZ8nJ2+m32iGZbNbqYTJTI0n6Bei+VHkExHySYPet7jU3rW7f94RMblUKRwKkWC7ncMKxJ+PGC2wtzhQg2OWEm2IX9hCQ= X-MS-TrafficTypeDiagnostic: HE1PR07MB3499: X-Microsoft-Exchange-Diagnostics: 1;HE1PR07MB3499;20:3hR5/WxWl/LFgDWqLco9qFwSoQNJQssAcfk2P4a62/OuEIkkbps5Qp+E1TcZMVDKaZ2tdfzvNYZiKsTgnOgIDAu+vk5avelv2BWeukMYJ5dVnk4d45FoXysJ5kHcuYC+mcr0qvGhVHEK+c3Wxpqa5otAMgLPWzqQIwocQgVTSXfwH2RzZt4r//BcHRllqFiaOtjRkYYHNHAmQDSDvjU00JCH+vqbKTKk0cpQUyEbMGs+wJOOEklX/Ai85em8av5VGI+Z9MCJW/5h8mI4gkZ9PP2JTiP7ogb4tOuXK8KSGU24q96YzAA/OMlXYguQclU1zbxInlCM4c1BNobzQlc0a+b2RqRO/nY4xhk3t322qWpTHdfZe1AOIxn8PRHmrZcU13S/3n1jpfigh4qNl2XWvtnSozR3uw9qbJxuNO0UrG3cQH7aIEAs85lSQ96/4HJxzv8eB0mkVgPgNatGnR4R6sWDS3zxHKtG/Y+ggvODhkJ54bEogFaNbWzZmejHOHOL;4:aDUx/L0VYiw6SMJQraJi5GjZKj08EQhTGIKX1UypebXZTMQ6mYFrJn8LV9grpWXByTxpGTwe2umIYeZGXEEUDPYr721pTP/mg5Ks4KsWXY/J2ezFuDmnPNNpgzalv5bBC7sONUD9RvbrMVx18HYMEw0l/5LdLD5P8KetwE0BcXSqShVxvLpE7uKqwyIy/1o3Rfy3UC1/zlBxW2s2qRTG6aaLCrP0v+m7L5clLVObwswGhL4Y2dzutDY9OYJFUc08cds5ZAf2ZOKiKCMHKqJGJQ== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3231020)(3002001)(6055026)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR07MB3499;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR07MB3499; X-Forefront-PRVS: 046985391D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(6009001)(39860400002)(346002)(376002)(24454002)(189002)(199003)(31696002)(3846002)(3260700006)(25786009)(68736007)(6116002)(86362001)(478600001)(106356001)(64126003)(105586002)(33646002)(230700001)(305945005)(2906002)(83506002)(97736004)(8936002)(6246003)(81166006)(81156014)(53936002)(8676002)(7736002)(4326008)(16526018)(76176999)(54356999)(23676002)(50466002)(53546010)(50986999)(189998001)(6486002)(229853002)(77096006)(36756003)(101416001)(5660300001)(316002)(65826007)(6666003)(6916009)(2950100002)(58126008)(16576012)(31686004)(65956001)(65806001)(47776003)(66066001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR07MB3499;H:[172.27.221.132];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA3TUIzNDk5OzIzOlo1SnM1b3ZhT1o1V0RHMTlKdjViMnRYYi9S?= =?utf-8?B?aGROUnM2YVVzU2twUndLcDIvcCs2bHRZamllRi9qbWcyMnQ3ZkxWWXYwV2Nx?= =?utf-8?B?Ynl3U2dTRVowUjNUdldwZDBxTmE5bmltMWtFWUY5MDJhbnEvVlA2d0VlaTMv?= =?utf-8?B?M3ZtcGZYVUJaMGwyQkloa0FTRlByZ0hFcjh1SCsxVlB0YkxONlQ5RGUxamc0?= =?utf-8?B?bXVscmkvQVJtY3I3dm1XVUI4ZlVwQ3MzcEdCRW9vb2pjWjZwOWdadEtCOERi?= =?utf-8?B?VUYrd1U0QWhMd0I2UENETzhlNGZ0a2dZUzgraDVsNDFBcE1jeVM4Tkpnd0Q3?= =?utf-8?B?R3ZFRTJ5QjhldzNuOUVkcEhkenZPQ3JYWC9sM05acUNZOFRMWW5zZW4vNklV?= =?utf-8?B?Wk5MdGpNMUtLNkFMR09VMlJuTjdoTmVxWW1Zd3QzZ0IvZlFYSFdPQ3ZlOFFv?= =?utf-8?B?UFg5S21Ha3J6cTFPUWJNWGl2TktzK0xEYlFCZW1RS1FhRDB5Y0w1dkZmbndn?= =?utf-8?B?VFZVVTJPZmpRL2JuL0xwVit6cU1MdVZaVG5QeEhzYWZsc0F4d2UzWHE4R1do?= =?utf-8?B?cldiU1daVzlVZTZGUHpCY092UTVyVm80MlQxN25ETEMrQU5yTFJFc0lGZkZY?= =?utf-8?B?SjBMVkk4emREbngvZmhnS0dXRVlRYjhLaDFsTmNSaVI3M1hVR2J1QkVBQWRE?= =?utf-8?B?UjA1ZHA4S3hMbko2bkJtTmJPLzFSNkc0THU1MHJpNUFvOXV0YzdEaXNaKzNU?= =?utf-8?B?MWl6WHFYQ0RtUEFyTDBnT0V1VUZ1aWd3SmZTajlSemNWY2NWMHdtdjJTNGdl?= =?utf-8?B?MG04Ynl1QU1FcE9sSWVnSWk5S1hya3ZKVnZmY3ZINkVvZWNRR1pyUHloSW9a?= =?utf-8?B?OXl3SXl2bi8wOUFkYjREUTJPZHZsdlJPVmdjQW5vM2E4UjI1bHV2SDNzN1Jl?= =?utf-8?B?TC9WUTlZVHYvTTlleEd0dnp1MDAybnRJbysrNFAyQkM5b1hHeGgxclgxR09q?= =?utf-8?B?WHFiTzNEMDZKM3pUTzhNclpxc3ZzeC8zeG1QMDJwMDM5dEJIZnVuc3k1Tjg2?= =?utf-8?B?dU9OSVBvMHlqR1JaZTJ1U1pzQ00rKy9sSFduWWxpQi9BLzR1NnVpOUNMcWZx?= =?utf-8?B?OVM3U1l1ek5LTUtRdVFEKzdPOG5yQmtqUG90SGhvVGNuQ0wwNDRJTnVJdTdS?= =?utf-8?B?L0dGOTN1bWlkek12N1Zha1FCY1pVRGMwcEVFaEFWTS82bUQvaTVHZWRUQStl?= =?utf-8?B?cktnc1BneU83MWJQYjh3cFdrUEZNOERMTFpXZkJXUlpoWkNpMWFkVDZLRUdN?= =?utf-8?B?TmszVHVKdnRtekRsWDhZNXc2Qi9iUzBVeCtmK1hYOWtLeUhndDc2R1F2UDNh?= =?utf-8?B?d0RDVVB1YnVKLy9DNmJxSnl3Q1kydW5SVU9HNFIzbHF0Mlp2TjFYanVldTUw?= =?utf-8?B?UWdtcTl1dUVGT2VsMmJSUjd6L1ltdkUxRHh0REllamU1V3hhMnJVV3BrNURQ?= =?utf-8?B?T29RMWZwV1dEcWZVcEY1alB1Tyt1WEY4WkR6anRCZ3VrQU9RQUQ3Ynl1WmVj?= =?utf-8?B?MDNhTi9rRjR6Y2E3d1JoY0ViaWJQZ1BqSDdwMktiV2hNY0hUaUVHdE4wamdn?= =?utf-8?B?VlJrbUlsc3JRVVRiam01MHVldVNUQWx2OFVoOFRMQWNyRWJFRjdSUjllRUNX?= =?utf-8?B?VVcxcm0zeVkzZXRVZ25jZk5xUnVaU25vWERnRVRWMURaNUZKU09GSHBnZ2RH?= =?utf-8?B?TDcvVVhDdTNwTENqaDZHeUV3YXVzNkpyWkEzK1h5ZGJVRE1BbmxZRnJVMXpJ?= =?utf-8?B?VWd4SUNVNmhscUM3WXJBbzhocHphaXEzNnBWYWgzc0N4bFE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR07MB3499;6:pqLX4lh4Ni5d4cdbqj06p7hTZ3sWRrkl/IGk4eoyKxAb8Pq7O97+qcM8bV3yah40KE12EEFGz7FOOYqXl/d6OaPLTH6EEqF2wLXpz7fnJNgJ83QWjBy3m7THT8fMlfUHM5UspSvRyqAye4QyqWVIztAV5p4sXr1eXtq4TFeeNvu9f3etV++liDVJtzZutC4nQEc1xPPkrf9y/ZmBpS8ilo1W0DIwKdoeSbPao0FbA1mV1yEnuZm3A1AiobhI3ysA/E159aevUCMpTV09Z+PCK7uAxO6OM0Vh5TTnfVmPo3WfyIX3Qm095q0Hn2wvdAtY/s2h6CpYl5pc5WMXQA3E5/qciOiKBXzFJr1b92sHZSo=;5:M2FcrxNTilbjOeiAKL5DMI8RGa1ix//QT3laZLwbLSGxoZ7Ee0IrjcLk6SqV4Rvw8XEEpVlAdjdnyj9/6geOg+G9SuWoMcqd6si0qHAqgG8JQ59Jrpzkr0/EnO77HUaHlIAYCVvZhJPXCNs7rmBB4K0zchjSQlUqVyecDvwQJz4=;24:gE/bl5X9LRF+XNRiOrKOiie6GVbNbOkeMd3qAS7YX2lXOI9MdCytx4hUn+EbURsN1+UCRKooNRWPEJjWDMp5IRjkl2XjenhdcXo2gpJL3pU=;7:w4K5GXlWg2o3u9pdIMqarfqt4oyyBaq3bgU8yBefysM1OE2Gq2HPxIDzCZ//U1Dlv4GYI3mZe8/u0wWpNfNhMvNanij6LorXBPJNKqDUgshvfkprnAztebMt1UAwou4LxFY945LR2RDfcexu1gdV6zuEhRfMTOh0IAzIqKGkhVFwfz+zB/hPKEPL3p/aEaNOXtM86UnU5hsNnSFEX+f5qwRBy3fvaMvEkyKe8QEjyA8ZKMHVbuIHe+3MM7/q00nq SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2017 07:54:29.4192 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 27b47353-fd4d-4d64-b123-08d519eb4a4e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3499 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/10/2017 18:20, Guenter Roeck wrote: > This should be part of device programming in manufacturing, just like, > say, current calibration. It should not be user programmable, even less so > runtime programmable. On top of that, we definitely don't want to make > STORE_USER_ALL available to user space. Both can too easily result in > a bricked device (bad enough that the register values are writable using > i2cset). My point is that I am exactly using Linux's pmbus implementation in order to perform a manufacturing calibration which is indeed a one-time operation. I agree that exposing these sysfs entries to end users can be dangerous. It can be useful if you actually want to perform a component calibration using Linux. Actually I am running an userspace application that does the calibration by writing to these sysfs entries. This driver is useful for manufacturing calibration and I think can be useful for other Linux users who wants to perform this kind of operation too. If this driver is dangerous for the end-user, how can we keep the features of this driver for manufacturing calibration using Linux? Maybe keep the generic driver for normal use and propose this specific driver as 'Advanced TPS544C20 driver [DANGER]'? Romain.