From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7508623E320 for ; Mon, 20 Oct 2025 15:45:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760975133; cv=none; b=PZufHRn67tOPzSeb2jTqinM7TZcqZ4nmZWlYlTHtJP9dKIcxnhudQX/qfMk2nv5mE5eEn6Evf00Q2fd57z5RYIBQq/9k/f6FmvQ6sXH1H4nUnV2HgRJRsdLLVXjVvxfH8hIRoRKqC64sZuuNBNupPbfe1mj8FeJtjYFdIUkbK6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760975133; c=relaxed/simple; bh=rWlIEOfLt4QSbEFCHlWSDOc4rlXWOXGgHbTI9+CTFCQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=giC6lP+m2osPfUzPsGvhA/wM/xBBqyhHlUNEW+Upb2UZsYpq3NGJQ2TEygEaozcjh2kn5MqZ92agv+q+Kjbxr2Gn5o7H4u6RAWiRxfijnhbXAnkCcv7cJuRaGkkQ0lRphJwMNTwTCvl2ViCiGARTYkk92uQImC4nbm7v5G4sGOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q6bdbHiw; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q6bdbHiw" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b404a8be3f1so103532066b.1 for ; Mon, 20 Oct 2025 08:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760975130; x=1761579930; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rLVd96XUXQkv2BukfYJUOUjTeSFa5/2WoKAq5E06sq8=; b=Q6bdbHiwrRq1zIGsJJWe2QJyedChhIdxEnYcqcecYhUr/u7zNukFYIRP/wSG8+p+Si vh/YBRGNZPu2iqKjLw5opnGX9IXUA6oIwVf83m+NB5Hz292YMSrSEgyUjYUweK9Q2icO b9Gk4/gpcJUEyn9KVR2Q5pe0QEitnb2nQdfeIghptNLusMdQEZ/mpPVSm81mTVb4jzeq 7wNwHiargEKo++DVi49ic1NpMWbFsCXlzXJi7oI11mtG7/+00aCx6BS5md952OKX/hmI uSeB5niviOsCIBxyj+LJcOhpEvLjKYhTH9wlQldit4KMuIGAnp8r406ks9uZvNWqkJGn Lcbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760975130; x=1761579930; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rLVd96XUXQkv2BukfYJUOUjTeSFa5/2WoKAq5E06sq8=; b=slfcNt2R4ppNCCYWiPRlk5Ye8Mb2M5zKDdczDiMSMdtj+LzztgSBK5pe6Ekc15daUt 6E5c5I/FRkRs5V/o+kBeVC6njpcNeIqUGJvfQGnf8BeBVorJG9USbObai/H0mfZPTh/b 8xN4O9GbfnZ997YVznM5bUOVvjDDbCEraWAMZ479uTcP7lVxp6KV3wHW7JK2Cyd0cYU+ pZe5nOuX/C1KRN8YNDclNODPfGlHAFZX2AZJAE6QRS/O7RDFubPKDQdlFkg/nvwinrT8 mpsx/DuNFwH/9scjcc6Meas+tNUHw2V1sMhpaagTtDcLfuZDAOGYGcPZ2OC/rpk98+RE trrw== X-Forwarded-Encrypted: i=1; AJvYcCWEe4JajecA+cI7/Q0MlW08YT7qe9uAUsE12UnTOIQY9O0DPHQDKx89BRIfioT8y5S+Mewb0ez4gIIm7Qc=@vger.kernel.org X-Gm-Message-State: AOJu0YzLzARsK1KfGabBhQUmhUq3o565LRsenNYGajgf9/FLNqQT2tDA BX5iNBPeykG6szDoGYELCjXOXKiGSUbSXCVHlEnzJ96jIuPSEY6UK69T X-Gm-Gg: ASbGncsOkI0z8teoOrr42p2lEL7CujDdJMNp9nvO5ijBYXNdQ+MwtDUoap1qoFH831F 8PwBRjITuJXERV50oKmFdC+3f2TZV6i6u8JU1SErexJrfJg5GxlVT4sP/O4dhlhSgmSfeZxv8dx vepkly05YR8feQto1O2tT6NnDsr7/u327BgO4tjZm9unJsh5UwTM4UzHs+k/J7Sx7Lxa50sp5wH fgihYWBxRw+MD78KgnI/5YUaDCnv2YO+8/ptOK2FDPgQENEp3xMKXPLLn16+hOBvQXNObaQvUeT NVpL+05/MiKBULLIRPcn4C7KUmBbRPhJyIWBXAz8lHBfefCam+WxdYaQp5kEg6rfwmQ6snrPtGQ M2tqAMSWO6T4yvjXSPusy/IULSaMT6TJKMqKw/20AfJFYRbZSx9wFARd6RlyEtk3Cb/HzaOBr0y o1zeIDli/uHL1L1/LHgbAuM2kwYCsKvA== X-Google-Smtp-Source: AGHT+IGbvK/f+EyST6/Ou/X1/Otr+t9j4IgsCu8YzzEolwEyyl33v0jG1ZAXlIIZiPmx169QmFhW2Q== X-Received: by 2002:a17:907:9708:b0:b04:2d89:5d3a with SMTP id a640c23a62f3a-b6475505d94mr884342366b.7.1760975129544; Mon, 20 Oct 2025 08:45:29 -0700 (PDT) Received: from [192.168.1.105] ([165.50.86.146]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b65ebc474c6sm808850666b.78.2025.10.20.08.45.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 08:45:29 -0700 (PDT) Message-ID: Date: Mon, 20 Oct 2025 17:45:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next] bpf/cpumap.c: Remove unnecessary TODO comment To: Alexander Lobakin Cc: ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org References: <20251019165923.199247-1-mehdi.benhadjkhelifa@gmail.com> <42b9b376-897e-4984-909b-218bd1e3214a@intel.com> Content-Language: en-US From: Mehdi Ben Hadj Khelifa In-Reply-To: <42b9b376-897e-4984-909b-218bd1e3214a@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/20/25 4:41 PM, Alexander Lobakin wrote: > From: Mehdi Ben Hadj Khelifa > Date: Sun, 19 Oct 2025 17:58:55 +0100 > >> After discussion with bpf maintainers[1], queue_index could >> be propagated to the remote XDP program by the xdp_md struct[2] > > But it's not done automatically, so not aware users may get confused. > > Instead of just removing the TODO, I believe you should leave a comment > here that the RxQ index gets lots after the frame is redirected, so if > someone really wants it, he/she should use . > Logical,I will send a v2 soon. Thanks for the review. Best Regards, Mehdi Ben Hadj Khelifa>> which makes this todo a misguide for future effort. >> >> [1]:https://lore.kernel.org/all/87y0q23j2w.fsf@cloudflare.com/ >> [2]:https://docs.ebpf.io/linux/helper-function/bpf_xdp_adjust_meta/ >> >> Signed-off-by: Mehdi Ben Hadj Khelifa > Thanks, > Olek