From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m49231.qiye.163.com (mail-m49231.qiye.163.com [45.254.49.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C84D23C4FF; Wed, 4 Mar 2026 14:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.231 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772633510; cv=none; b=JGvH42oE3QIRzZ4scEn6wUckTtL4KqgRBexl+g1QosOztJsUZauv7LhitQ43TziJsfCHIZKuPrpPALGZOD9s+K0J2PjZCPHc3Da04Wwj7xaFw7X+7kaiGUM5qq4H3qrYQ+D7L1xa/EqnHLNpNxaJLKG6jTIJEj286N8iXYLtEIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772633510; c=relaxed/simple; bh=9hfLEMLEjEMc8uZwHodU+viTGo92h6eeEPI7jhWM9m8=; h=Cc:Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=eAFetZKzvlB+6hpzJ69CPP+4sT1ZlCrU//ZQKFILb/KZ0EvErAjirbE3meqjuHt8S3DMY8990zVb+lgSB3ZbmeLhyjkuNY9Ai495nSCLtsmux+RHHwGhl1clY7IHdFQ5RHxzZiVEs4AauOqWVJw/cBOfXMU50jH2VUAD5i0jzgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=fx22D2kn; arc=none smtp.client-ip=45.254.49.231 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="fx22D2kn" Received: from [172.16.12.14] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 35bef961c; Wed, 4 Mar 2026 21:36:16 +0800 (GMT+08:00) Cc: shawn.lin@rock-chips.com, Martin Filla , Charalampos Mitrodimas , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Conor Dooley , Frank Wunderlich Subject: Re: [PATCH v4 1/4] arm64: dts: rockchip: assign pipe clock to rk356x PCIe lanes To: david@ixit.cz, Rob Herring , Heiko Stuebner , "elaine.zhang" References: <20260304-rk3568-bri-r2-pro-fix-pcie-v4-0-37abd7ba29d0@ixit.cz> <20260304-rk3568-bri-r2-pro-fix-pcie-v4-1-37abd7ba29d0@ixit.cz> From: Shawn Lin Message-ID: Date: Wed, 4 Mar 2026 21:36:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20260304-rk3568-bri-r2-pro-fix-pcie-v4-1-37abd7ba29d0@ixit.cz> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9cb91043db09cckunm56444db0122910c X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQxgYQ1ZIQkxLHxhNSUweTB9WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=fx22D2kn242RR6kXvU/2drBjn1X7G1r4J6WP3RnZQe9shUfVHmlNHN60ywYZG39crbVuIKrwgDtFYU4oIbfReugUOmgXdVdgWDFlSsGQJbth/rPtmlUigRHhfyk4mNFvhSQ/F3n1Dk9z5rfkpYnAu08yC8Gs6u66zvNO7SXT20w=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=p/5CjFN5DQLnwXu9X2kNfSbkWVbxCQkt3uDqFMTtaNk=; h=date:mime-version:subject:message-id:from; + Elaine ÔÚ 2026/03/04 ÐÇÆÚÈý 19:05, David Heidelberg via B4 Relay дµÀ: > From: David Heidelberg > > These clocks are used by PCIe lanes, but we're missing from the > definition. > These missing clocks are needed but PCIe still work fine£¬because the clk code for rk3568 didn't actually define them as real clock gates. So they are always enabled thanks to the default value and out of the radar of clk_disable_unused(). It's a bit suboptimal and probably need to be improved in clk-rk3568.c For $subject patch, Reviewed-by: Shawn Lin > Suggested-by: Charalampos Mitrodimas > Signed-off-by: David Heidelberg > --- > arch/arm64/boot/dts/rockchip/rk3568.dtsi | 12 ++++++++---- > arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 6 ++++-- > 2 files changed, 12 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi > index 658097ed69714..3bc653f027f1f 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi > @@ -155,9 +155,11 @@ pcie3x1: pcie@fe270000 { > bus-range = <0x10 0x1f>; > clocks = <&cru ACLK_PCIE30X1_MST>, <&cru ACLK_PCIE30X1_SLV>, > <&cru ACLK_PCIE30X1_DBI>, <&cru PCLK_PCIE30X1>, > - <&cru CLK_PCIE30X1_AUX_NDFT>; > + <&cru CLK_PCIE30X1_AUX_NDFT>, > + <&cru CLK_PCIE30X1_PIPE_DFT>; > clock-names = "aclk_mst", "aclk_slv", > - "aclk_dbi", "pclk", "aux"; > + "aclk_dbi", "pclk", "aux", > + "pipe"; > device_type = "pci"; > interrupts = , > , > @@ -208,9 +210,11 @@ pcie3x2: pcie@fe280000 { > bus-range = <0x20 0x2f>; > clocks = <&cru ACLK_PCIE30X2_MST>, <&cru ACLK_PCIE30X2_SLV>, > <&cru ACLK_PCIE30X2_DBI>, <&cru PCLK_PCIE30X2>, > - <&cru CLK_PCIE30X2_AUX_NDFT>; > + <&cru CLK_PCIE30X2_AUX_NDFT>, > + <&cru CLK_PCIE30X2_PIPE_DFT>; > clock-names = "aclk_mst", "aclk_slv", > - "aclk_dbi", "pclk", "aux"; > + "aclk_dbi", "pclk", "aux", > + "pipe"; > device_type = "pci"; > interrupts = , > , > diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi > index 68b48606f6010..15741acac6274 100644 > --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi > @@ -1020,9 +1020,11 @@ pcie2x1: pcie@fe260000 { > bus-range = <0x0 0xf>; > clocks = <&cru ACLK_PCIE20_MST>, <&cru ACLK_PCIE20_SLV>, > <&cru ACLK_PCIE20_DBI>, <&cru PCLK_PCIE20>, > - <&cru CLK_PCIE20_AUX_NDFT>; > + <&cru CLK_PCIE20_AUX_NDFT>, > + <&cru CLK_PCIE20_PIPE_DFT>; > clock-names = "aclk_mst", "aclk_slv", > - "aclk_dbi", "pclk", "aux"; > + "aclk_dbi", "pclk", "aux", > + "pipe"; > device_type = "pci"; > #interrupt-cells = <1>; > interrupt-map-mask = <0 0 0 7>; >