From: Hannes Reinecke <hare@suse.de>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Lukas Bulwahn <lbulwahn@redhat.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Hannes Reinecke <hare@kernel.org>,
Keith Busch <kbusch@kernel.org>,
Eric Biggers <ebiggers@kernel.org>,
linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lukas Bulwahn <lukas.bulwahn@redhat.com>
Subject: Re: [PATCH] crypto: Kconfig - correct references in config CRYPTO_HKDF
Date: Wed, 2 Apr 2025 08:05:09 +0200 [thread overview]
Message-ID: <d9885697-25c2-4f2b-822d-444a10f0c78d@suse.de> (raw)
In-Reply-To: <Z-vZKlqdAtvyeUjj@gondor.apana.org.au>
On 4/1/25 14:16, Herbert Xu wrote:
> On Tue, Apr 01, 2025 at 02:13:54PM +0200, Lukas Bulwahn wrote:
>>
>> diff --git a/crypto/Kconfig b/crypto/Kconfig
>> index dbf97c4e7c59..f601a4ec6d1a 100644
>> --- a/crypto/Kconfig
>> +++ b/crypto/Kconfig
>> @@ -143,8 +143,8 @@ config CRYPTO_ACOMP
>>
>> config CRYPTO_HKDF
>> tristate
>> - select CRYPTO_SHA256 if !CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
>> - select CRYPTO_SHA512 if !CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
>> + select CRYPTO_SHA256 if !CRYPTO_MANAGER_DISABLE_TESTS
>> + select CRYPTO_SHA512 if !CRYPTO_MANAGER_DISABLE_TESTS
>
> Why not just drop CRYPTO_MANAGER_DISABLE_TESTS and select the
> SHA algorithms unconditionally?
>
Fine with me. I was just trying to follow precedent here when creating
the original patch.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
prev parent reply other threads:[~2025-04-02 6:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 12:13 Lukas Bulwahn
2025-04-01 12:16 ` Herbert Xu
2025-04-02 6:05 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9885697-25c2-4f2b-822d-444a10f0c78d@suse.de \
--to=hare@suse.de \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=hare@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=kbusch@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lbulwahn@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®