From: Michal Simek <michal.simek@amd.com>
To: linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ZYNQ ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] ARM: zynq: Do not define address/size-cells for nand-controller
Date: Tue, 4 Feb 2025 09:34:18 +0100 [thread overview]
Message-ID: <d98b9294-32c2-4333-bda9-9d18cef35675@amd.com> (raw)
In-Reply-To: <7a3b9eb256b90ea19d35f8bbe3fd311890767974.1736233292.git.michal.simek@amd.com>
On 1/7/25 08:01, Michal Simek wrote:
> There is no reason to define address/size-cells without defining child
> nodes in zynq-7000.dtsi. Define it in board file instead.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> Changes in v2:
> - Update also zynq-ebaz4205.dts
> - Update commit message
> - Send it separately v1
> https://lore.kernel.org/all/37057526d8ee14416f61fb6e2b82bed65bde5d3c.1733920873.git.michal.simek@amd.com/
>
> arch/arm/boot/dts/xilinx/zynq-7000.dtsi | 2 --
> arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> index 4a29216a6d64..153b8d93cbee 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> @@ -303,8 +303,6 @@ nfc0: nand-controller@0,0 {
> compatible = "arm,pl353-nand-r2p1";
> reg = <0 0 0x1000000>;
> status = "disabled";
> - #address-cells = <1>;
> - #size-cells = <0>;
> };
> nor0: flash@1,0 {
> status = "disabled";
> diff --git a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> index 53fa6dbfd8fd..14f644156a6f 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> @@ -51,6 +51,8 @@ &gpio0 {
> &nfc0 {
> status = "okay";
>
> + #address-cells = <1>;
> + #size-cells = <0>;
> nand@0 {
> reg = <0>;
> };
Applied.
M
prev parent reply other threads:[~2025-02-04 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 7:01 Michal Simek
2025-02-04 8:34 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d98b9294-32c2-4333-bda9-9d18cef35675@amd.com \
--to=michal.simek@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®