From: "H. Peter Anvin" <hpa@zytor.com>
To: ndesaulniers@google.com, bp@alien8.de, mingo@redhat.com,
tglx@linutronix.de
Cc: x86@kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Kaehlcke <mka@chromium.org>,
Kees Cook <keescook@chromium.org>,
Cao jin <caoj.fnst@cn.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/boot: define CC_HAVE_ASM_GOTO
Date: Mon, 1 Oct 2018 10:38:33 -0700 [thread overview]
Message-ID: <d98d47ea-b639-8afd-2851-1f7ceaf66fd0@zytor.com> (raw)
In-Reply-To: <20180927204800.32210-1-ndesaulniers@google.com>
On 09/27/18 13:47, ndesaulniers@google.com wrote:
> Early prototypes of Clang with asm goto support produce 6 instances of
> the following warning:
>
> In file included from arch/x86/boot/compressed/misc.h:20:
> In file included from ./include/linux/elf.h:5:
> In file included from ./arch/x86/include/asm/elf.h:8:
> In file included from ./include/linux/thread_info.h:38:
> In file included from ./arch/x86/include/asm/thread_info.h:53:
> ./arch/x86/include/asm/cpufeature.h:150:2: warning: "Compiler lacks
> ASM_GOTO support. Add -D __BPF_TRACING__ to your compiler arguments"
> [-W#warnings]
> your compiler arguments"
> ^
>
> Since 6 files under arch/x86/boot/compressed/ include
> arch/x86/boot/compressed/misc.h AND
> arch/x86/boot/compressed/Makefile happens to redefine KBUILD_CFLAGS,
> which set these variables in the top level MAKEFILE.
>
The Right Thing[TM] would probably be to split the CFLAGS into those
that are independent of x86_64 vs i386. After all, there is no
fundamental reason we couldn't want to use asm goto in the setup or
real-mode code in the future. In addition to BIOS entry code there is
the EFI32 code.
-hpa
prev parent reply other threads:[~2018-10-01 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 20:47 ndesaulniers
2018-09-27 21:40 ` Kees Cook
2018-09-27 21:51 ` Borislav Petkov
2018-09-27 22:17 ` Nick Desaulniers
2018-10-01 17:32 ` Borislav Petkov
2018-10-01 17:38 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d98d47ea-b639-8afd-2851-1f7ceaf66fd0@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mka@chromium.org \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®