From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 663061E47C5 for ; Mon, 26 Jan 2026 13:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769434827; cv=none; b=LRsNvvxPv0BEXLoe+oupk75g4+u62Xf1LTN5plUDhN0LHgJzztZvfkAf1SUWz75Ee8DfMP4LY0ZgTu6d07CD6d4kaijCFhUVAa7XgAY7pFjkpzAcFxsiyyeDHaNTPb4qEOe8NFsl105eSpjbF53T96fb5PtavQc5W+/PkoRbpOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769434827; c=relaxed/simple; bh=hiV1mwptVE1X+TFGpR5nDlHhkXYVLOknuYGWaerv1DA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GvJcxCkYD2PL1yU2AGm6jhCxZSus/qklahgxtZ81dUmZM/hHPboDVXKEVT/ArKjrga1wOGLN5V4W/0IOSsY1eUGUC06XCS1bqGDlUlGc+5vVOnUkK0W9EnCWYLaBabCXvSJsqX8c+OnZBhUCH46prtVqDXxAwXM/MtROTC4rjUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Fn/fd2v7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=STVnBozX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Fn/fd2v7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="STVnBozX" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60Q9Oikt1062634 for ; Mon, 26 Jan 2026 13:40:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bZpoYSbwjt/zA/TbbfxQ54Cdd+ABBb+o46hdhiusmLk=; b=Fn/fd2v7fK0Ve8IR WYD7EY1KWXc6MYd2FeK2YRV52BNAqli2nZ1RoRSiUk8zPjLUPsmKjT3hXZUCjLkZ REVQj0ILe9T5COvrucrYE0YJKBnKEU1qPLJhzz7UlkCU5xc0YzFi2GcYLrogph8x nPmzYXS5LBkpOi5HyrY8uj4dlOGYA98DPI46dfLMwTDSLFRcrFW2jut2vOXIFNdM L/GH/1Qe+MLtrQ5w0BS+h3J5nnUToiHuTwLli2ggeQ6c94Btund7UVBzJSxFr/TX TDHCHWdizbIqy4Mr1TXgbJfBELt/eO+WZ9cxZPjrhbnAM6AzqMoYaYFy09Kh/Qvb 2GTjvQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bvq9f4mtr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Jan 2026 13:40:25 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c56848e6f53so2608877a12.0 for ; Mon, 26 Jan 2026 05:40:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769434825; x=1770039625; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bZpoYSbwjt/zA/TbbfxQ54Cdd+ABBb+o46hdhiusmLk=; b=STVnBozX1Jj0j1H9RTr0SVKI50OPHpSpq7g3zFTE016saquzP/b/DCkTZIBRLwDpiL XHVd//fhlwi0YIBas62WyDQV5eEXOhJWkA9+RdEHL4oVyznO5l7TeB6MEgitdgnXlz+q a8iZgVwYallhMxfTmXb1pIXezluJqSQ4ENtKdbRg0gYmdj5Cz9YqOi9m7xx95H+OAcOt W6YrjaUoinUmkw1tU87/tmpfqHDmpQKiBE8qAPy5RyBAJ6sqI2mMdS8odgD+gLXB5ZU7 NIP37VQtk4vAVx3D8JmWT3Muo/BIZjysC7PAuXGJIdZtOj8br/zQm7WE2XXHSFMqA8fo 7R3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769434825; x=1770039625; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bZpoYSbwjt/zA/TbbfxQ54Cdd+ABBb+o46hdhiusmLk=; b=tjXrwvUaLfoGGiAGAAUJdWdBvh44BismeYYs/kAaudjp11RRuAc3m8sBF4xQRnh9Wc V9FFvLPMrlAZr4Dm3A6jwnfk+T0vPHdFwxgHK/VvfbxHFhSuLVWqB7KbEX3c0vE7EcI/ +HGdrox/2sD3q2WXPJnOsq3PA5Hxxw4Gv6PtmI7KOCdsvkA/roWeVOiBtUZECdgX0EHc fORx2OW5t9DUAT5PSc08Xi2LV8Ca4Rb+lPi61JSxly6bXcsi3R5ejFTgknHIgvPubsXS uZ6rEg2UcymfDUJkKSpD5hOAG4YtPh7ERztk2mdNWS74UwBVzBc9fF7cIhf6Jt0RKQK3 RtGw== X-Forwarded-Encrypted: i=1; AJvYcCVqxSSz+CmgWB/3xPFSfqrVC8Os/wLwq4OIS6MUUHzgCDIzn7qWxteEskuVJJccVkr8KTWBy72xK+IhNiM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy99kR8lzOvNHx1tyvvIY2uH6aC89gJ3PbzaCIUCahbR0YQf56O wr1w5aU2NTnSbcF44K6/wlCJziFrUKNGGBD58TQVlpmVogI+op0FYfpQx/+9wvK6vjfuCUEra65 qDoJxRkSoYNdBekTH1ki+6QM6kLCl6btxRm0flLalwn/IsBlLunY4FJ28qJQcDfNBV2w= X-Gm-Gg: AZuq6aKknVrI9siZ6YG+vKdr6102C+NAFKa2FHfN1BxnEaq4fftuh7ZXCczGG/BCrnM 6XUGzcLGGahr2+WNuLmvHN2h1p6MJ7nwtoC0ogJ55CIAS0dOR8OvcCM1/irDVxixKmRQuKvQ9qp nHlSOH2FQaT5xKxdSfPgvqbGHsSANX90biQ/Nm+tw6eKpt9kzh6WcJdBw7UfaHNIeqfkuUUEfX4 EBi5eTe0hiuXz4aELaiHFAPoSa4HbtH7ol/xdlzI1rUPGoow+RpYvhpwPQ9T45wMPKNSMrSOxJy /eP2lOaW+L16L/giMBguBrRWK7X5zrw5Q3MEz/dvB8FbDJFVDAS3Te7khqJi7tgrvu1K1zn1bg1 tqSBv5MrHOMGDW6XNZOtM8XXjEj6d8i/Z0T1YlzsgF7HxHGKYcIcn X-Received: by 2002:a05:6a00:158e:b0:823:6d3:85d0 with SMTP id d2e1a72fcca58-82341317d38mr3196388b3a.67.1769434824790; Mon, 26 Jan 2026 05:40:24 -0800 (PST) X-Received: by 2002:a05:6a00:158e:b0:823:6d3:85d0 with SMTP id d2e1a72fcca58-82341317d38mr3196369b3a.67.1769434824326; Mon, 26 Jan 2026 05:40:24 -0800 (PST) Received: from [192.168.29.125] ([49.43.234.121]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82318666c16sm9429622b3a.24.2026.01.26.05.40.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 05:40:23 -0800 (PST) Message-ID: Date: Mon, 26 Jan 2026 19:10:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] interconnect: qcom: glymur: Add Mahua SoC support To: Dmitry Baryshkov Cc: Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Odelu Kukatla References: <20260123-mahua_icc-v1-0-bc82cb087f1e@oss.qualcomm.com> <20260123-mahua_icc-v1-2-bc82cb087f1e@oss.qualcomm.com> Content-Language: en-US From: Raviteja Laggyshetty In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=YLGSCBGx c=1 sm=1 tr=0 ts=69776ec9 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=y/Pne2EoOvGgihOE/QD3VA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EanYLttqG9bUWcn10CcA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: DCUajMrsiz_DSjjwrStaMobZB7NuHaww X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI2MDExNiBTYWx0ZWRfXy3vcEHdgxeQ2 D7/7webjZx3kYtgZHMyqnUlv3Du9T+Y4nUA4wOic4t331YMZZqPkIWQscf2NibWvkUjCO7qz8dG c3TddExELYCAOkhmka3ttPo9QrN/stMmQ1UBlux93MPFb56zxA9cjrOtYWuXh9Xj2N9GdB4ajSs o6PioT2jK9RqFszFGu1OBsouykwVs3Dk3LI/gua30vW6gqai6yy0TnxQ/god7S4JBBuzm6OMn5p ZbRqJ0VM0eY1dIrla2/ZoAFayYDfcIr1yIms0YDBhu7qjucP/Iysjmccwh0yyuuc8SX+yo/lTDn 44NMfyjFk9Sj+tFSKo06NQooGXQqMIwZqqpeJ/3217gAYJ66/2WW0L71EMdObzAiV0dJNLYlaxs xEU+RAAqiXUL1jp0pDIWGRjFFn+dmDfmdm/y8UGgZOFN8j6I3/4pEg7zOpbSr6moReM+hMggXMm Fc8m115t1PRYOq1II1w== X-Proofpoint-ORIG-GUID: DCUajMrsiz_DSjjwrStaMobZB7NuHaww X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-26_03,2026-01-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 phishscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601260116 On 1/26/2026 7:04 PM, Dmitry Baryshkov wrote: > On Mon, Jan 26, 2026 at 06:40:13PM +0530, Raviteja Laggyshetty wrote: >> On 1/23/2026 11:28 PM, Dmitry Baryshkov wrote: >>> On Fri, Jan 23, 2026 at 05:12:36PM +0000, Raviteja Laggyshetty wrote: >>>> +static int glymur_qnoc_probe(struct platform_device *pdev) >>>> +{ >>>> + if (device_is_compatible(&pdev->dev, "qcom,mahua-mc-virt")) { >>>> + llcc_mc.channels = 8; >>>> + ebi.channels = 8; >>>> + } else if (device_is_compatible(&pdev->dev, "qcom,mahua-hscnoc")) { >>>> + qns_llcc.channels = 8; >>>> + chm_apps.channels = 4; >>>> + qnm_pcie_west.buswidth = 32; >>>> + } else if (device_is_compatible(&pdev->dev, "qcom,mahua-pcie-west-anoc")) { >>>> + qns_pcie_west_mem_noc.buswidth = 32; >>>> + } >>> >>> Right here, set the node entries to NULL. >> >> cnoc_cfg_nodes is declared as an array of const pointers, so the pointer >> values cannot be reassigned after initialization. To change the addresses, >> the const qualifier would need to be dropped. To preserve const, the >> entire array has been duplicated instead by dropping the PCIE_3A related >> nodes. > > Why? Just drop the const instead of creating unnecessary (almost) > duplication. > ok, Thanks for the suggestion Dmitry, will post the next revision by addressing the comments. >>> >>>> + >