From: Andrew Lunn <andrew@lunn.ch>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Xu Liang <lxu@maxlinear.com>
Subject: Re: [PATCH v2] net: phy: mxl-8611: add support for MaxLinear MxL86110/MxL86111 PHY
Date: Thu, 15 May 2025 01:56:22 +0200 [thread overview]
Message-ID: <d994cff7-e960-41fa-9ce6-c35cee3a2560@lunn.ch> (raw)
In-Reply-To: <CAK+owoid1woDTiCxcGiEmdvKNHJeCnaKBjPEHyNrtHt_hKqi9g@mail.gmail.com>
On Thu, May 15, 2025 at 12:29:48AM +0200, Stefano Radaelli wrote:
> Hi Andrew,
>
> Thanks again for your detailed review and suggestions,
> I really appreciate the time you took to go through the patch.
>
> After reviewing your feedback, I realized that most of the more complex issues
> are specific to the MXL86111. The MXL86110 side, on the other hand, seems much
> closer to being ready once I address the points you raised.
I did not look too close. Does the MXL86110 not have this dual
Copper/Fibre setup? Removing that will make the driver a lot
simpler. So yes, submitting a simpler, more restricted driver is fine.
Andrew
next prev parent reply other threads:[~2025-05-14 23:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 19:18 [PATCH] " Stefano Radaelli
2025-05-12 20:02 ` Andrew Lunn
2025-05-14 17:35 ` [PATCH v2] " Stefano Radaelli
2025-05-14 18:49 ` Andrew Lunn
2025-05-14 22:29 ` Stefano Radaelli
2025-05-14 23:56 ` Andrew Lunn [this message]
2025-05-15 7:02 ` Stefano Radaelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d994cff7-e960-41fa-9ce6-c35cee3a2560@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®