From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ED4E49BD83 for ; Fri, 9 Oct 2026 10:03:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791540205; cv=none; b=QHjZCK2dS2VYnA2X8++h/PDmDnVSHHHlnFSQUfLk6dN+NU7/HlDNiVgnVqGZY7nc025dZLoayNzP4nC4+IYTetJBerMZUvvZvy7Tic4FE/OsYPP0kRM996hrhbNfbjZhyL9cjE1AVw2mdPG6+4Y2YDqvLbaK+HU2Rbpeh5+Cg+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791540205; c=relaxed/simple; bh=KPAFyUw7nX/MpchqdZD/H9rJtTKOPIWkCTHK0liR+yE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m1LQyOIuSvXg5Bu3rw2dup9x9at7TI6z26nKc+B8tYl1rUwPbQYNZu30S9fczsINehyPTzUSiFSSEJujvfg9C+Pxcdgbs49fEgTRFpZotiwAy5ZtO9N4u8XRe7gC7NsnSV8+8QoXip/fHNvudF+7H9j0SaG7khulTRyMsfpFMrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=X+gJx+86; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="X+gJx+86" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4a16aaf2067so70865955e9.0 for ; Fri, 09 Oct 2026 03:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1791540200; x=1792145000; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qPWJMeDyVSRIeJtDK0w7ULZSIZyQfconBMNDwO4cVgs=; b=X+gJx+86UR0wiJapCi7qYJfEeUAnWJx723oaYX2UjY8JGe38SiECpw65yTvFfitb2y drJYwVo25AZuQFWgsiQ8ca/vcIL9sQoBvMuhhQKzp9NmI99vthM0fSTEjRVc8/Vu9d9L L3INcs9Fd/MZXkrDMjUetbfWkSUm5LHPQuNsSjqca/BvaJW7yY4UWMJhc9zWeITJyaxp Ni446nAlJuF6+1buV0EmsonK9YDbSpYgW+RUYIVTtq/WtjV3Xk2ua/y6vG+Z9QJqw/Bt NTb3gNqQUChi27ieP0sKxK6XHRf4qno/OVrwOUg7IiWrLs2Z0sTIc7vZt7glZM/EG/vf diuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791540200; x=1792145000; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qPWJMeDyVSRIeJtDK0w7ULZSIZyQfconBMNDwO4cVgs=; b=jm4Ue/24KR9vaHL+mF4+7QwD9PvCX6dnz0s0dDpgq6Q3zq6uy+l6rFV3dLGKVxb4ON +q8vBnquhYmowo4cV2YBVVNCj2DF3OcUCkQVpT38NvfhjWJXucEGp7f0n9k3pALzgVz1 tpLVAdTULgfSrfkYx3hjbdiARL5KFUIWtRimuOlU7HNhQVg0/j1HSMTIOou/qVNsHAVx kFnvqa1I0zQDliEecZCBaT6WRVXCdmlth1jBaS4Bvuk7uJHaU33Ge4iYHWCAeiDg8N4z tt2pr8R9/e6oYnSbaTLUJ6pQsNbYg0UXPkMnnNAheCoEGOWOc69QL5JLaCr/Sbn81Vb2 9/lA== X-Forwarded-Encrypted: i=1; AKwUvBzKjKx3zLstyd+bKubrQNWPgL7KD2tM6WHi38SAryVWVMBzsotii3UgeMcOvpw9YMJOLJYmft9KVu5HzGA=@vger.kernel.org X-Gm-Message-State: AFuF++mH7WfGg/iWsliU55POIr9H8sBhbefCdiaqkCGANWohLwQC4GZF r7gTLdSO2VVS9gPBx1STP1j+I/wd58w02KBBUJU6bmUVgSl2ZiVAq+IMF9tQOXt6K3w= X-Gm-Gg: AYBFou2Th3zuv2MQ89wsMIWTyjy7vUZ591C1DfclmXrNvdr+SjzUe+6DmQhsNohDScL mPYVk9l65QeY/6mgJJAo3F/FAAip89MmR3gf70QqajueI22ntCxYaQdoyY2iNA4wvL+YN/dXEXm x/0iRjjHzxOq/lre6SS9DVNpuolDay1agAc0yILdVoFIMduvzSfPhj2/1/nvESg8F8hkxCDFGB5 qnJGGZ1+VOTCL5vwsrrk8iG1xkfMkkHrpStX8KIN2eDMcl231iIzWvlPXSI9/GsZRqmAZLpjbtQ o/YoWwxn66GVVA3VEphbxYeWxnhQyuhF86Vubhn/pjfpVg9MZEZqBgszBg6TsNK2bWad9kfhSJW oUQv46dnBuZlywtYywuIewU7U0Ri0lSzsLJdHLFBK0pIoBTd4QDNvR0fmOJBYcXwIxCFoN42Mja dbIBD7SxPFtWlIZzDJxKGIcnA6Zt2gAqnF/ipkIzEQA8kXnJHDOX57KYBLNLNeqQaAO3IE7JTCH CPf9c6BkC50 X-Received: by 2002:a05:600c:4ecb:b0:4a1:76c9:5408 with SMTP id 5b1f17b1804b1-4a18e4a510emr26609695e9.11.1791540198883; Fri, 09 Oct 2026 03:03:18 -0700 (PDT) Received: from [100.64.0.1] ([147.161.130.187]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a18eb4485dsm68317565e9.2.2026.10.09.03.03.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Oct 2026 03:03:18 -0700 (PDT) Message-ID: Date: Fri, 9 Oct 2026 12:03:16 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/7] riscv: dts: eswin: add I2C controller support To: Pinkesh Vaghela Cc: Yulin Lu , Darshan Prajapati , Pritesh Patel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Andi Shyti , Mika Westerberg , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Min Lin References: <20260814070007.1662455-1-pinkesh.vaghela@einfochips.com> <20260814070007.1662455-7-pinkesh.vaghela@einfochips.com> Content-Language: en-US From: Samuel Holland In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Pinkesh, On 2026-09-30 3:06 PM, Pinkesh Vaghela wrote: >>> + aon_i2c0: i2c@51830000 { >> >> Please keep nodes sorted (the aon block controllers go below GPIO, etc.). > > As per DTS coding style document [1], "Order of Nodes" states that > "Nodes on any bus, thus using unit addresses for children, shall be ordered by unit > address in ascending order. Alternatively for some subarchitectures, nodes of the > same type can be grouped together, e.g. all I2C controllers one after another even > if this breaks unit address ordering." > > Do you still prefer to change order? Yes. I believe the alternative option is allowed because a few platforms were already doing things that way, to avoid forcing them to change. However, for a new platform, it is best to follow the recommended pattern; simple numerical order is easier to understand, verify, and automate with tooling (which is on the way). Regards, Samuel > [1] https://docs.kernel.org/devicetree/bindings/dts-coding-style.html > > Regards, > Pinkesh > >> >> Regards, >> Samuel >> >>> + compatible = "eswin,eic7700-i2c", "snps,designware-i2c"; >>> + reg = <0x0 0x51830000 0x0 0x8000>; >>> + interrupts = <290>; >>> + clocks = <&clk EIC7700_CLK_GATE_AON_I2C0_PCLK>; >>> + clock-names = "ref"; >>> + clock-frequency = <100000>; >>> + resets = <&reset EIC7700_RESET_ANO0>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + status = "disabled"; >>> + }; >>> + >>> + aon_i2c1: i2c@51838000 { >>> + compatible = "eswin,eic7700-i2c", "snps,designware-i2c"; >>> + reg = <0x0 0x51838000 0x0 0x8000>; >>> + interrupts = <291>; >>> + clocks = <&clk EIC7700_CLK_GATE_AON_I2C1_PCLK>; >>> + clock-names = "ref"; >>> + clock-frequency = <100000>; >>> + resets = <&reset EIC7700_RESET_ANO1>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + status = "disabled"; >>> + }; >>> + >>> gpio@51600000 { >>> compatible = "snps,dw-apb-gpio"; >>> reg = <0x0 0x51600000 0x0 0x80>; >