From: Lizhi Hou <lizhi.hou@amd.com>
To: George Karagounis <taterraster@gmail.com>,
Min Ma <mamin506@gmail.com>, Oded Gabbay <ogabbay@kernel.org>
Cc: Koby Elbaz <koby.elbaz@intel.com>,
Konstantin Sinyuk <konstantin.sinyuk@intel.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<mail@taterr.org>
Subject: Re: [PATCH 1/2] accel/amdxdna: Replace create_singlethread_workqueue with alloc_ordered_workqueue
Date: Fri, 25 Sep 2026 11:34:11 -0700 [thread overview]
Message-ID: <d99bb6ed-7cff-6f8a-d5b2-23069fe0fcfc@amd.com> (raw)
In-Reply-To: <20260925124804.58808-2-mail@taterr.org>
On 9/25/26 05:48, George Karagounis wrote:
> create_singlethread_workqueue() is deprecated. Replace it with
>
> alloc_ordered_workqueue() to use the shared system workqueue
>
> infrastructure more efficiently.
>
> WQ_MEM_RECLAIM is added to ensure the mailbox can process
>
> interrupts under memory pressure.
>
> Signed-off-by: George Karagounis <mail@taterr.org>
> ---
> drivers/accel/amdxdna/amdxdna_mailbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index cc8865f4e79c..05c3786de135 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -481,7 +481,7 @@ struct mailbox_channel *xdna_mailbox_alloc_channel(struct mailbox *mb)
> return NULL;
>
> INIT_WORK(&mb_chann->rx_work, mailbox_rx_worker);
> - mb_chann->work_q = create_singlethread_workqueue(MAILBOX_NAME);
> + mb_chann->work_q = alloc_ordered_workqueue(MAILBOX_NAME, WQ_MEM_RECLAIM);
Reviewed-by: Lizhi Hou <lizhi.hou@amd.com>
> if (!mb_chann->work_q) {
> MB_ERR(mb_chann, "Create workqueue failed");
> goto free_chann;
next prev parent reply other threads:[~2026-09-25 18:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 12:48 [PATCH 0/2] accel: Replace deprecated create_singlethread_workqueue George Karagounis
2026-09-25 12:48 ` [PATCH 1/2] accel/amdxdna: Replace create_singlethread_workqueue with alloc_ordered_workqueue George Karagounis
2026-09-25 18:34 ` Lizhi Hou [this message]
2026-09-25 12:48 ` [PATCH 2/2] accel/habanalabs: " George Karagounis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d99bb6ed-7cff-6f8a-d5b2-23069fe0fcfc@amd.com \
--to=lizhi.hou@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=koby.elbaz@intel.com \
--cc=konstantin.sinyuk@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@taterr.org \
--cc=mamin506@gmail.com \
--cc=ogabbay@kernel.org \
--cc=taterraster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®