From: Jens Axboe <axboe@kernel.dk>
To: Phillip Potter <phil@philpotter.co.uk>,
Randy Dunlap <rdunlap@infradead.org>
Cc: hch@infradead.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, lumip@lumip.de
Subject: Re: [PATCH] cdrom: docs: reformat table in Documentation/userspace-api/ioctl/cdrom.rst
Date: Sun, 10 Oct 2021 19:36:08 -0600 [thread overview]
Message-ID: <d9a0177b-f6aa-c03b-0925-9858703d6607@kernel.dk> (raw)
In-Reply-To: <YWOC2Iyszh7WAgzf@equinox>
On 10/10/21 6:18 PM, Phillip Potter wrote:
> On Thu, Oct 07, 2021 at 04:34:13PM -0700, Randy Dunlap wrote:
>> On 10/7/21 4:17 PM, Phillip Potter wrote:
>>> Add extra space to the first column of ioctl values table, and also realign
>>> the text in the second column, to fix a documentation build warning
>>> introduced by: commit 67f1e027c270 ("drivers/cdrom: improved ioctl for
>>> media change detection")
>>>
>>> Suggested-by: Randy Dunlap <rdunlap@infradead.org>
>>> Fixes: 67f1e027c270 ("drivers/cdrom: improved ioctl for media change detection")
>>> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
>>
>> Looks good. Thanks.
>>
>> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>>
>>
>>> ---
>>> Documentation/userspace-api/ioctl/cdrom.rst | 116 ++++++++++----------
>>> 1 file changed, 58 insertions(+), 58 deletions(-)
>>>
>>> diff --git a/Documentation/userspace-api/ioctl/cdrom.rst b/Documentation/userspace-api/ioctl/cdrom.rst
>>> index bac5bbf93ca0..682948fc88a3 100644
>>> --- a/Documentation/userspace-api/ioctl/cdrom.rst
>>> +++ b/Documentation/userspace-api/ioctl/cdrom.rst
>>
>>
>>
>> --
>> ~Randy
>
> Thank you for the review Randy.
Applied.
--
Jens Axboe
prev parent reply other threads:[~2021-10-11 1:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 23:17 Phillip Potter
2021-10-07 23:34 ` Randy Dunlap
2021-10-11 0:18 ` Phillip Potter
2021-10-11 1:36 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9a0177b-f6aa-c03b-0925-9858703d6607@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumip@lumip.de \
--cc=phil@philpotter.co.uk \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®