From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46A9415098E; Wed, 19 Jun 2024 14:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.214.62.61 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718806175; cv=none; b=ENMkIGFQKhhOLZBa4i0uu8Fds3XGEZr1cmwycr98x24sHLBEyKwkd9GZtOBIv7XNoPbPg7sVs8klFa7kOMHOvYc7rjqeSsyorAMbdGXyuQdVag/DGhA7XmhOsf8L4z7xxvRlbPUMUDD70O+9xSTOMh7hg8bmuB6kxu2trncrAM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718806175; c=relaxed/simple; bh=Al0kBfLHssYAQy6/oy1Pf41V356seJgU3boW8IIW+OE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pG9fXU+bZ2biLx6EV3XOXHkQjD5GFdubTXcrmECIpYAUqHS4XAXUd/KsB7db7l9cvCGIXAP+l3NV/spb8ZbQUgH5yAEdl3kZoqrlyPoTzMctz9vepmo77/BPI3xyXvKXH24rGfPh+Y0j+Oy7Gr/hylAOqioRnBL7Pkh1Eij4g20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de; spf=pass smtp.mailfrom=denx.de; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b=We5TTLnA; arc=none smtp.client-ip=85.214.62.61 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=denx.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=denx.de header.i=@denx.de header.b="We5TTLnA" Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 3230488428; Wed, 19 Jun 2024 16:09:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1718806172; bh=2tFlSH74W8+2RQdC7szAY3eA9dHEvz08hbHTqrK0XfE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=We5TTLnA2KguroNAn1p/cOOT8Ip6tdK4hpfzcourjB0PUyH5Fgt1SPPYqmJbqBqjH xGXIw10XqFrHbZUbSUUuv7LyrSZ05nE/zlYPV9MY4YeiWAjunddTuP+xqf04ftW+qR 65IWkp3jHlIWMJbqrozS0WuaN6ghr4QakICIcjE8ouwm8vyU3DFDoEgYXSLzalrBpE KF+LkTJUBWYC94KASjOOutc5DFo3rxh8Gk/qgSauMai2SVVaIfaua9Xu25Zdi+37cw GofTAIEwLmX5W4DokVt+mawMYer9OImFVWZNl1gSEdQoH/f6DzTJD0Zo2osti/DYqo 1906YPkNSM3+Q== Message-ID: Date: Wed, 19 Jun 2024 15:44:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] arm64: dts: st: add ethernet1 and ethernet2 support on stm32mp25 To: Christophe Roullier , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Jose Abreu , Liam Girdwood , Mark Brown Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240619125815.358207-1-christophe.roullier@foss.st.com> <20240619125815.358207-2-christophe.roullier@foss.st.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <20240619125815.358207-2-christophe.roullier@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 6/19/24 2:58 PM, Christophe Roullier wrote: > Both instances ethernet based on GMAC SNPS IP on stm32mp25. > GMAC IP version is SNPS 5.3 > > Signed-off-by: Christophe Roullier I don't have an MP2 device, so I cannot provide much technical feedback. But from the DT standpoint, this looks OK, so Reviewed-by: Marek Vasut