From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ptr1337.dev (mail.ptr1337.dev [202.61.224.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 134EF38F80; Mon, 28 Jul 2025 08:54:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.61.224.105 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753692846; cv=none; b=oLVb76ssvwIWzv48PmCiJhVWPF4FeMXUUOLCB4Ko22GJw+T3vmJUfcCZYwN5PtGIUQwb3Lk2N4JTfcRIN2AV5qeTgLLlRrC49ILTvco1a31svC5rteHDs4NshKmWEdwkeDAZMuC6Fv6pz+WHZNOrTr8Ix7s/q6l1ruybOoDpL7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753692846; c=relaxed/simple; bh=B0IJjL98PhPeCgMKI5R+ISp5vmenYly7y+1rdHXxrI8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gMa6POZuqItSSWoDIS9tByhUJWoHNWPv/9y8C6p1cDK4yRdoMumT8AS9Iwxkju8mVPp9gJwu1zn31Dlh1BHGBffX0RiLweglkAutK4FJ6Asw+ubBaEHk9RGbKUIB68j+mwjLPAJA7s4Q+U/VaIIMt4wq7NgWo7bYnF34L1+J2VI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cachyos.org; spf=pass smtp.mailfrom=cachyos.org; dkim=pass (2048-bit key) header.d=cachyos.org header.i=@cachyos.org header.b=gL/9WQ/q; arc=none smtp.client-ip=202.61.224.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cachyos.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cachyos.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cachyos.org header.i=@cachyos.org header.b="gL/9WQ/q" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5403F284303; Mon, 28 Jul 2025 10:45:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cachyos.org; s=dkim; t=1753692331; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=hZAZQxcJny2MJlnbj6INcbeqX5pbA4FFdFvh2PmI64w=; b=gL/9WQ/qCqbdu8zR86gU47Fb4JEBykEZI3fYcn9RWlJ1FkRil9jRegxpKVtlMVHiuCRkvD eUN8qjcTZbRYiOkvX4mdgh/LxFAr5+8+kF7N59rXBpMN6Ij4pFM7K0toI9/17YaGKGKaib TRUqRWvjhzvFhphSevh08vs5VWbN3+rSK8oTR33/pl3tDKExtUZjXzo2iLkcAc7fqbskIw LuRqFnwnfmC9KGst5fDt6aVyRY9/lqAnz1lnsj7VqV6WWNJBP5H76boU0TjPx4UuuMwu9R DCIWav85qzoBaQQMN29prltn9IdsIgfcfFXvyThIPqE17s2r92h8R/Qfq6plxQ== Message-ID: Date: Mon, 28 Jul 2025 15:45:25 +0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/5] Improvements to S5 power consumption To: Mario Limonciello , "Rafael J . Wysocki" , Alex Deucher , Bjorn Helgaas Cc: "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:HIBERNATION (aka Software Suspend, aka swsusp)" , "open list:PCI SUBSYSTEM" , open list , Greg Kroah-Hartman , Danilo Krummrich , "James E . J . Bottomley" , "Martin K . Petersen" , "open list:DRM DRIVERS" , "open list:SCSI SUBSYSTEM" , "open list:USB SUBSYSTEM" , Mario Limonciello References: <20250616175019.3471583-1-superm1@kernel.org> Content-Language: en-US From: Eric Naim In-Reply-To: <20250616175019.3471583-1-superm1@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 6/17/25 00:50, Mario Limonciello wrote: > From: Mario Limonciello > > A variety of issues both in function and in power consumption have been > raised as a result of devices not being put into a low power state when > the system is powered off. > > There have been some localized changes[1] to PCI core to help these issues, > but they have had various downsides. > > This series instead tries to use the S4 flow when the system is being > powered off. This lines up the behavior with what other operating systems > do as well. If for some reason that fails or is not supported, unwind and > do the previous S5 flow that will wake all devices and run their shutdown() > callbacks. > Hi Mario, I've been running this series on CachyOS since 6.16-rc3 and have no issues. Feel free to add Tested-by: Eric Naim -- Regards, Eric > v3->v4: > * Fix LKP robot failure > * Rebase on v6.16-rc2 > > Previous submissions [1]: > Link: https://lore.kernel.org/linux-pm/CAJZ5v0hrKEJa8Ad7iiAvQ3d_0ysVhzZcXSYc5kkL=6vtseF+bg@mail.gmail.com/T/#m91e4eae868a7405ae579e89b135085f4906225d2 > Link: https://lore.kernel.org/linux-pci/20250506041934.1409302-1-superm1@kernel.org/ > Link: https://lore.kernel.org/linux-pci/20231213182656.6165-1-mario.limonciello@amd.com/ (v1) > Link: https://lore.kernel.org/linux-pm/20250514193406.3998101-1-superm1@kernel.org/ (v2) > Link: https://lore.kernel.org/linux-pm/20250609024619.407257-1-superm1@kernel.org/ (v3) > > Mario Limonciello (5): > PM: Use hibernate flows for system power off > PCI: Put PCIe ports with downstream devices into D3 at hibernate > drm/amd: Avoid evicting resources at S5 > scsi: Add PM_EVENT_POWEROFF into suspend callbacks > usb: sl811-hcd: Add PM_EVENT_POWEROFF into suspend callbacks > > drivers/base/power/main.c | 7 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 + > drivers/pci/pci-driver.c | 94 ++++++++++++++-------- > drivers/scsi/mesh.c | 1 + > drivers/scsi/stex.c | 1 + > drivers/usb/host/sl811-hcd.c | 1 + > include/linux/pm.h | 3 + > include/trace/events/power.h | 3 +- > kernel/reboot.c | 6 ++ > 9 files changed, 86 insertions(+), 34 deletions(-) >