From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E65540B6F4 for ; Thu, 4 Jun 2026 13:32:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780579926; cv=none; b=HWvmGa6MkUewVDfKXE9VFYyohMtuhXwZLsJtcXnafrqpPkpVZrYSwDOyyhWSwF5Bh+xMW4IzFZGiWIiDEFYlR8OWgdcNXEsNIhQ7/cE0JAUD7ljFgUZCFAXJM2ERmbU0RisfHZLnORdcf5vGTu03clBf6L+0rLLeKfCJHu+i1TY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780579926; c=relaxed/simple; bh=ZkQWGgFZCoFSBhFJf3coWEqHeUyuA2PzIM81IX4gGR8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DHnI2Y+5i6jh0L9ryFZZhZOe0CFBfiEYkjsXIsTDekarRydW8uLucfuZN6vF7xH3mo81rbxMOpFfdt3xhl45uG1uluIevRSMMHE4GQkJBFbBj9cZWrCMuNjsA3CoaJ9wij2Gw6w/ITY42mgxmJrkOjmyYtK8HH4x43ymkDlULwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ckkg1XPM; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=OkORXdCY; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ckkg1XPM"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="OkORXdCY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780579924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kP12h1LonZWRO930Aw/hrU8SVFS9Dh8cN/DqNFBNMzw=; b=Ckkg1XPMdsxMKa/UBG16FLs8x24bd73mcCcNJVIbh2bkopViat2hsRv266XEKl/FbeaDl8 9B1BEIuRnfM8df9/68jOR7zBbVgNasVqIIuJ/R0DwOYKxt4VBapYGYudqtOdvil5B9BhEB DKG8Xn3WUm90aUhVBeptgTNQG3pyYEk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-thIZ92EQOj64NVA1j37e8A-1; Thu, 04 Jun 2026 09:32:02 -0400 X-MC-Unique: thIZ92EQOj64NVA1j37e8A-1 X-Mimecast-MFC-AGG-ID: thIZ92EQOj64NVA1j37e8A_1780579922 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-49048e21ea7so12087305e9.1 for ; Thu, 04 Jun 2026 06:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780579921; x=1781184721; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kP12h1LonZWRO930Aw/hrU8SVFS9Dh8cN/DqNFBNMzw=; b=OkORXdCYvmlXpYgTipIP5dCBW9WeIweyG9wTvVyNsa4ti1trnBMuKoeI1YXcoVc9lp v/zuuzBEjShXNWG0ydz8sfLK4TWX1+PBOMRxClD4M/E83lyU311Nh7CV26RVlOyQ/WQe EmTt+XZCYzxXvRG9+wXQH8nj8OdBWj0DkHbDY5TglJQbBYWa6Pp86MpV8K0zL1PZi97N 4JgclbROIWua19OOASLxnARECcxQCJxIWbAT5FA1mGkYNuILivRjdTQwTFH/I7N+LAQs F82yrcaPuiHc55xy+SiVw1k04cPN1QK9RbHZDqkdKCGPuErfbmk8yp3TqgqFA6rYOHwP b+LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780579921; x=1781184721; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kP12h1LonZWRO930Aw/hrU8SVFS9Dh8cN/DqNFBNMzw=; b=TDaMtFSq2U9cvr3oy0q4buakGpSCA/EGWUNlVyLr/Md2KjoQk8GjJkFIvFTO2xDHMh 5EQVg8FRe1KeeMCNEBLK+XjZF8OSc/R9CLH52OaTAUhBLIjrg46jqLN28hDS+r12LOv8 bvETEcCBsr9iehc3oeJFJzwRR7ef7T/7bGVgKDrfirCYUifHMn71MP9IPtUX0El1l8zq B1/icODWgKcLNLeytiRZL+MayjH9QB2anC1WTvABV36eZjFJNItdun4A03+kJMcHOpja 2ekXJbqMi1xsxnFc+4y2Z7yRi8UCvk/J/lTWL8hQ+8NncKZJ0qelPPDZL8SVECBmJu5w y/GQ== X-Forwarded-Encrypted: i=1; AFNElJ8B6Zj5R8w/sk/PJHMhzg2TxsmlpPRZLV7ZFSve5D5ufwabZjHuaCsCRyWOU+DUM9JP0Plbc3e61pEeyco=@vger.kernel.org X-Gm-Message-State: AOJu0YxGuFrBdh6Cos4x2HPeDGKFQCXKq6NeZMy/VdrZ/1Szo4pgD/LY 4a6wTpXilXztVTszxxt8P1YRcSsTcVp//atkxVS2aJrHA9HxYuuA5h5pdIw/Pf5dqkv2p5wQXlS IsI0wvUmGDLSd2QPMSoWfsUCZJf5TfEIwOVWM8gUkxAQobP+ISdJ/ZDtscv1iv6g/mw== X-Gm-Gg: Acq92OFzLG0Bc+a4GxM/HZcD+/jMW2f7AH0CN9414Y82mUwmsHMEfCKOxT6dbSaoulr uRAaO+VkhpkqZ+OlezUx+ppVgTI3UuJBxARnfe65UnqujK+iKa8zIVCPjUm+JamPlq0A9oVwPVG YI8J+aufT2Tfy/kJAuE9cDOiTQ9y7pgvdFM4aWnQs9ieQjHkFdM3l+mt0AN94iQRwddFuEj4RlM FeZxYhy8zuYKCayGapqt1m0XKo/5o+uTH0DwDFtOfBSUkkeBnhjNxfG6lreIjWjG+rQzvs90kfO Q6o4sxh6EzIJPspb6E/2TYtzU8dVKKKYO4tXmLEqF3ojYF2tejaXb3nrvI2G9O9khtVHQVn48r0 acBD6h4anlgHqdfWNQkwKVYPI9unmL1R0FJZvWCs2fZPIAFdbLoG4EW07COCZ21ku/bY= X-Received: by 2002:a05:600c:34d3:b0:490:b26c:64ad with SMTP id 5b1f17b1804b1-490bc4cf867mr58229705e9.5.1780579921525; Thu, 04 Jun 2026 06:32:01 -0700 (PDT) X-Received: by 2002:a05:600c:34d3:b0:490:b26c:64ad with SMTP id 5b1f17b1804b1-490bc4cf867mr58229275e9.5.1780579921137; Thu, 04 Jun 2026 06:32:01 -0700 (PDT) Received: from [192.168.88.32] ([212.105.155.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bda4fd52sm61620455e9.0.2026.06.04.06.31.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 06:32:00 -0700 (PDT) Message-ID: Date: Thu, 4 Jun 2026 15:31:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/mlx5: convert miss_list allocation to kvmalloc_array() To: William Theesfeld , Saeed Mahameed Cc: Leon Romanovsky , Tariq Toukan , Mark Bloch , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260601193758.626537-1-william@theesfeld.net> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260601193758.626537-1-william@theesfeld.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/1/26 9:37 PM, William Theesfeld wrote: > dr_icm_buddy_init_ste_cache() allocates the per-buddy miss_list using > the open-coded kvmalloc(n * sizeof(*p), ...) form. The neighbouring > allocations in the same function already use the kvcalloc()/ > kvzalloc_objs() forms; switch this last one to kvmalloc_array() for > consistency and for the size_mul overflow check that kvmalloc_array() > performs. > > The semantics are unchanged: kvmalloc_array() returns a non-zeroed > buffer, just like the previous kvmalloc() call. Existing callers of > buddy->miss_list initialise each list_head before use. > > Signed-off-by: William Theesfeld > --- > .../net/ethernet/mellanox/mlx5/core/steering/sws/dr_icm_pool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_icm_pool.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_icm_pool.c > index 7a0a15822..fa4d24b3d 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_icm_pool.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_icm_pool.c > @@ -239,7 +239,7 @@ static int dr_icm_buddy_init_ste_cache(struct mlx5dr_icm_buddy_mem *buddy) > if (!buddy->hw_ste_arr) > goto free_ste_arr; > > - buddy->miss_list = kvmalloc(num_of_entries * sizeof(struct list_head), GFP_KERNEL); > + buddy->miss_list = kvmalloc_array(num_of_entries, sizeof(struct list_head), GFP_KERNEL); > if (!buddy->miss_list) > goto free_hw_ste_arr; @Leon, @Tariq: the patch looks obviously correct to me, still an explicit ack would be nice, I think. Thanks, Paolo