From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57FCCC05052 for ; Tue, 15 Aug 2023 20:32:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237968AbjHOUb5 (ORCPT ); Tue, 15 Aug 2023 16:31:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237982AbjHOUbd (ORCPT ); Tue, 15 Aug 2023 16:31:33 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1C581FC9 for ; Tue, 15 Aug 2023 13:31:30 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3110ab7110aso5331290f8f.3 for ; Tue, 15 Aug 2023 13:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692131489; x=1692736289; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KyN9mbwaXCeD9ddt8BwKaPHZBpIm4dW+EkteSoYWyH4=; b=xrrg1Lm+rYDLYBzWIRiSdaxZjhV1XYNCjktJ68o3hygAEtXIZQFxlCYG+jRKyxoz05 2+vwpNjU4cBXfpgO5uLL4CNwSB2jwyhpVzYhYukSX/KH0HkiLLYteYbCJAYJZ7h5vyao ksUw59ES/NyBAbS1jh3IZsGAeOaeAKylI5LhyttanlDC6SCKOkeRaE73Cw0tAjVIgM+o 344GyuIR6zYHzAZ5sRl40FTtAEJSuVlYX+YFoLGcL1Hp9kKd0y/Zuxbo0u1loQNJPsnE 7tRIFjWxzsra7bTkYejBdpbz7qs4IStP+YM9NGBKyaQqRym0wdlL4WkIbeBd6l4SuWM0 nEsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692131489; x=1692736289; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KyN9mbwaXCeD9ddt8BwKaPHZBpIm4dW+EkteSoYWyH4=; b=C/t2Eoj5n639O28ijzaD87MiWAcFEHfTNn5F0dGO7OE9Q9isUaG9flv+lto7yArqR6 KnbiKLbxOS+c68RKv8OM69RhetXc7hbLufCyh5l0hodgtQ0VX8g6vPyK/sXTUhn4cTWG M/DDlMSKecJrCTrkfhZrK3zUFDQG2Bo+xX0OFPcwdRMrSATUr1lV1rF3Q8YN/XIIgbV5 ilaifQIpvrWomZUljxcranEU6V3hxalRb51Ax/TOYbtJBp3cP6DzrNJtUVcnFTqTr6LH nlWztt6AJEHpfhkpDJWHNkbaBfnXlvJQ6XMfyN6ZZih1ThNVurC9g3TOxk3R9ltcHKuT Z6WA== X-Gm-Message-State: AOJu0Yw4YOZTbzyIFmvLEE3d3GEUtj9C23A9wOZhbcBqwCK+VvEI+gF/ j5pomkLKGYUIGfQ3cjW/vDRlGQ== X-Google-Smtp-Source: AGHT+IGKfKT6v7xAX9eRrfeVce0AfRmSoHeqv6qYSAYqLe+fP7lNSELrPG7WvUwsiJxHDSPObqPb+w== X-Received: by 2002:a5d:6889:0:b0:319:8161:ecc6 with SMTP id h9-20020a5d6889000000b003198161ecc6mr3432297wru.63.1692131489426; Tue, 15 Aug 2023 13:31:29 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id o14-20020a5d474e000000b00317f3fd21b7sm5490315wrs.80.2023.08.15.13.31.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 13:31:29 -0700 (PDT) Message-ID: Date: Tue, 15 Aug 2023 22:31:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 2/3] dt-bindings: leds: Document pull-up supply for interrupt and I2C Content-Language: en-US To: Stephan Gerhold , Pavel Machek , Lee Jones Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nikita Travkin , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, "Lin, Meng-Bo" References: <20230815-aw2013-vio-v3-0-2505296b0856@gerhold.net> <20230815-aw2013-vio-v3-2-2505296b0856@gerhold.net> From: Krzysztof Kozlowski In-Reply-To: <20230815-aw2013-vio-v3-2-2505296b0856@gerhold.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/08/2023 19:21, Stephan Gerhold wrote: > Since the interrupt and I2C lines of AW2013 operate in open drain low > active mode a pull-up supply is needed for correct operation. > Unfortunately there is no ideal place to describe it in the DT: The > pull-up needed for the I2C lines could be described on the I2C bus. > However, the pull-up needed for the interrupt line belongs neither > directly to the interrupt controller nor to AW2013. Since the AW2013 > driver will be typically in control of the power management and > interrupt masking it makes more sense to describe it inside the AW2013 > device tree node. > > Add it to the AW2013 DT schema together with a comment that makes it > clear what exactly it represents. > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof