From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678E92F25FD for ; Mon, 15 Dec 2025 13:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765804924; cv=none; b=RdZg08lSGWVSUilDHBQPMCsSBDl4ar0KDN9h8BqhXQBKJayXyFvmP196l60wuIP4tSw7VymTUrpagOLtY/hQd3ZzBFSx8os9h9+80h74qupcX9q0CEHnWFT0Vif5tVCufVtB7aT3PjpWK+UkvuJ6GDwMF+MBZvnnZLH7wH/4Xn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765804924; c=relaxed/simple; bh=Onw8Vj/aDi3C22Ax82mPzLYQUuwXBUMjVocKxST25sU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VIDdNUgRqkHDTBkLDO6eI7W/9Hle1qdWQAh1zupVqdte19ldS8KzEBFt1ODMaXcJQsGwa+G86dytaZSsUJU2bITsUT0VU6PbvB3f8KIA1Ff4xs2WXWiLaDzpzY7Ukay3v25M1Vt6MD6+8NHdn1B/DUxm9SDedgpAPeStH8rhdgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CZI+sL+1; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CZI+sL+1" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-34c868b197eso1043201a91.2 for ; Mon, 15 Dec 2025 05:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765804923; x=1766409723; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XFQclEnkXOaGEQB1i5aZAavoFZmjLHt34fVvrMxQ7/0=; b=CZI+sL+1ovOsqaLU2+bZVqGF+P0/VNFjhDxkMZXxxzi0uHIHRqmYYVOYp6MHrIGkFe uK4XHR+y+qhRGFON8pfgW6/30AR51K2jaXCuDH3R1PsdmxeEgT/yjmUjrH5BbIDm8BOX 4e9HDdyQ0H5KzgCxXpsvUCHnvnqfsxICEkGXr17bqPbjwTI/kuhJ5Y7A4x7QFldRhhJd 5aISL252WWDBR0CJxWBxk/JKo84b5DGYcYK1LfEWZaloiIxMf8q0Pn7mfokNOLDA2d+S ai6UKWKpyjf+3N0Ui5r7IPx/YzYwg6nUJ5fOFihMATHkpaJAgzXs63Ly2/Fh8zFbynJB eXxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765804923; x=1766409723; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XFQclEnkXOaGEQB1i5aZAavoFZmjLHt34fVvrMxQ7/0=; b=bFxoV6RgluHja8yC7RAD6qlVbqzVXonu5fA36u0Z9vjuU4eXHT9LBSFYtniUQKheC0 OMAWHKF2qw5VvQQoUyrQl+vleBzSFbs87myQKo6GchKsf7sXeG2F/PEITVDjDCulqvWy Ku0uMQmdhf9rCgrCKtb2EXAItVyVww7PbM0PC1GaQda5BqktZ1QlxNkLy3IE1GmFoV+W towCDtM6oxfNMHC/jO9zXP1F4UN1/7knZGPdUX9z86zTHhnobAXT3tdfPJeHuWkmVMoE IxgPC6GnHgrZ9MLO82mr+yNNFqibuq/rgQm5MDQ/4bg0I69gPwCVBMSRu1u6nHXbRieE ns/Q== X-Forwarded-Encrypted: i=1; AJvYcCUiOO9yapWbFEF/63BLYkvoyHOtCedIwL000yZBwEHfV68ucTf41ADMjP6YaEOUKyv3oKzZ/WnTUzG4Cng=@vger.kernel.org X-Gm-Message-State: AOJu0YyfGoLek5w5zsSeZfe6GDg5h99em+j6+iNtjsl/IGICidJDlmrH 8yEsFP+uVdIuSJGeGnSuJz0RZ5w1eY5NuQdFxp0DBOYuiaVeNJ1ZaUWF X-Gm-Gg: AY/fxX5u0whcmNLzc9/QopMgR5psisXM9bX7a71HoqGrvXM3KjoqqYHKy936D5ANKin DMfXVXk6ep9GuYiQFkxF6rm+m0jfmlfloshu08AMC166EIInMR9kY87I4knr20MYtPSLJWCpC+0 dAu9suCedx2PirM+kNfCzpHJ3d609xhs5VnTRILxzVLvF6iST2MfwRBizIMztkH84VU7WjEob/q 8CcfCzNDyX7VamHycaKoqbrxzceIoeTNJy5vnwSzH7TRBoSFsjCQYe+0e5s1CFdO6gm1F7IRlum rdpTSYBjeLdbQnbdi3Wa1LGpCpZZWlxhtd1v61ZjXKvFlOMvM3Y0ADJk6sFZ6Z8EaJ09g/k52UX D09YbN6xOlSLToY/93uJ9D1lwzAK/DTL3lPtpr70mID0u9wuR2ksuOgEud3/OaNsXRmNg2zxxQ6 31w0JLh/wyaJPpckJxKQ6bi9jUBZh7QjJM80M= X-Google-Smtp-Source: AGHT+IHbaYhxvypHifIExhwZd3l2/ucRgBsyGvQHV3xb8nXjQoVtyds84IM8xW/n7EfLN2sBoGgpmw== X-Received: by 2002:a17:90b:28cd:b0:340:d578:f299 with SMTP id 98e67ed59e1d1-34abd6cde3emr8712572a91.3.1765804922630; Mon, 15 Dec 2025 05:22:02 -0800 (PST) Received: from [172.16.20.12] ([136.226.244.245]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34abe129a87sm9137934a91.0.2025.12.15.05.21.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Dec 2025 05:22:02 -0800 (PST) Message-ID: Date: Mon, 15 Dec 2025 18:52:30 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board To: Dmitry Baryshkov Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251107105735.1491273-1-tessolveupstream@gmail.com> <20251107105735.1491273-3-tessolveupstream@gmail.com> <9b0c7cac-3577-4190-883b-7de26790b8bc@gmail.com> Content-Language: en-US From: tessolveupstream@gmail.com In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06-12-2025 08:13, Dmitry Baryshkov wrote: > On Fri, Dec 05, 2025 at 10:58:56AM +0530, Anusha Ajithkumar wrote: >> >> >> On 03-12-2025 02:36, Dmitry Baryshkov wrote: >>> On Tue, 18 Nov 2025 at 12:16, wrote: >>>> >>>> >>>> >>>> On 14-11-2025 01:38, Dmitry Baryshkov wrote: >>>>> On Fri, Nov 07, 2025 at 04:27:35PM +0530, Sudarshan Shetty wrote: >>> >>>>>> + >>>>>> +&uart0 { >>>>>> + status = "okay"; >>>>>> +}; >>>>>> + >>>>>> +&usb_1_hsphy { >>>>>> + vdd-supply = <&vreg_l5a>; >>>>>> + vdda-pll-supply = <&vreg_l12a>; >>>>>> + vdda-phy-dpdm-supply = <&vreg_l13a>; >>>>>> + >>>>>> + status = "okay"; >>>>>> +}; >>>>>> + >>>>>> +&usb_qmpphy { >>>>>> + vdda-phy-supply = <&vreg_l5a>; >>>>>> + vdda-pll-supply = <&vreg_l12a>; >>>>>> + >>>>>> + status = "okay"; >>>>>> +}; >>>>>> + >>>>>> +&usb_1 { >>>>>> + status = "okay"; >>>>>> +}; >>>>>> + >>>>>> +&usb_1_dwc3 { >>>>>> + dr_mode = "host"; >>>>>> +}; >>>>>> + >>>>>> +&usb_hsphy_2 { >>>>> >>>>> So, the labels are usb_1_hsphy, but usb_hsphy_2? That's not logical, >>>>> please fix one of them. Then please fix the order of nodes here. >>>> >>>> The node names come directly from the included talos.dtsi, where they >>>> are defined as usb_1_hsphy & usb_hsphy_2. >>>> To avoid breaking inherited definitions, we kept the same labels >>>> in our board DTS. >>> >>> Please fix them in the base DT. >>> >> >> The inconsistent naming originates from talos.dtsi, which is >> outside the scope of this patch series. Modifying these labels >> in our board DTS would break the inherited node references >> from talos.dtsi. >> However, I will reorder the nodes so they appear in a logical and > > Please fix the base DT. There is no such thing as "out of scope". > Okay, will take care in the next patch. >>>> consistent sequence. >>> >>> This is a prerequisite, no questions. >>> >> >