Re: [PATCH] mmc: sdhci-cadence: enable probing from ACPI

[Adrian Hunter <adrian.hunter@intel.com>]

On 04/11/2026 16:38, Paul Cercueil wrote:
> Hi Adrian,
> 
> Le mercredi 04 novembre 2026 à 16:30 +0200, Adrian Hunter a écrit :
>> On 03/11/2026 11:35, Paul Cercueil wrote:
>>> Use the device property API instead of the OF-specific property API.
>>> This way, the driver will also probe from ACPI.
>>>
>>> Note the change in the core's probe function for SD6HC. We can't have
>>> named clocks in ACPI.
>>
>> Do you mean in the future?  ACPI does not provide clocks at all
>> at the moment does it?  Otherwise, clocks registered directly by
>> clk_register_clkdev() can have names.  Maybe I misunderstand,
>> but perhaps clarify the commit message.
> 
> I sent another patch in parallel of this one, that adds basic support for clock
> resources introduced in ACPI 6.5:
> 
> https://lore.kernel.org/linux-acpi/20261103084718.8222-1-paul.cercueil@bootlin.com/T/#u
> 
Would have been worth mentioning that in a cover letter.

Seems like it gives the clock a name

+		snprintf(name, sizeof(name), "%s-clk%u", dev_name(dev), data->idx++);
+
+		err = devm_clk_hw_register_clkdev(dev, clk, name, dev_name(dev));

 but clk_find() doesn't look like it would match then - the comment says:
 *  An entry with a NULL ID is assumed to be a wildcard.
 *  If an entry has a device ID, it must match
 *  If an entry has a connection ID, it must match	<------