From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751924AbcDZMvl (ORCPT ); Tue, 26 Apr 2016 08:51:41 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:12130 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbcDZMvk (ORCPT ); Tue, 26 Apr 2016 08:51:40 -0400 Subject: Re: [f2fs-dev] [PATCH 1/7] f2fs: avoid needless lock for node pages when fsyncing a file To: Jaegeuk Kim , , , References: <1461629220-16280-1-git-send-email-jaegeuk@kernel.org> CC: From: Chao Yu Message-ID: Date: Tue, 26 Apr 2016 20:51:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1461629220-16280-1-git-send-email-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.571F6443.0292,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 6b44964ef5ae68d70ab98976ab5eb1ad Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, On 2016/4/26 8:06, Jaegeuk Kim wrote: > When fsync is called, sync_node_pages finds a proper direct node pages to flush. > But, it locks unrelated direct node pages together unnecessarily. > > Signed-off-by: Jaegeuk Kim I've reviewed this patchset, it looks good to me, please add: Acked-by: Chao Yu