From: Marc Herbert <Marc.Herbert@intel.com>
To: Junio C Hamano <gitster@pobox.com>, Andy Lowry <andy.work@nglowry.com>
Cc: Jeff King <peff@peff.net>, git <git@vger.kernel.org>,
Christian Kujau <lists@nerdbynature.de>,
josh@joshtriplett.org, michael.w.mason@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: BUG in git diff-index
Date: Tue, 26 Sep 2017 12:46:13 -0700 [thread overview]
Message-ID: <d9b4725b-3204-03af-1bc2-6469bb815c63@intel.com> (raw)
In-Reply-To: <xmqqwpoil6vt.fsf@gitster.mtv.corp.google.com>
On 31/03/16 13:39, Junio C Hamano wrote:
> Andy Lowry <andy.work@nglowry.com> writes:
>
>> So I think now that the script should do "update-index --refresh"
>> followed by "diff-index --quiet HEAD". Sound correct?
>
> Yes. That has always been one of the kosher ways for any script to
> make sure that the files in the working tree that are tracked have
> not been modified relative to HEAD (assuming that the index matches
> HEAD).
Too bad kernel/scripts/setlocalversion didn't get the memo:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cdf2bc632ebc9ef51
> scripts/setlocalversion on write-protected source tree (2013)
> I don't see how removing "git update-index" could do any harm.
This causes a spurious "-dirty" suffix when building from a directory copy
(as Mike learned the hard way)
----
PS: I used NNTP and http://dir.gmane.org/gmane.comp.version-control.git
to quickly find this old thread (what could we do without NNTP?). Then
I googled for a web archive of this thread and Google could only find
this one: http://git.661346.n2.nabble.com/BUG-in-git-diff-index-tt7652105.html#none
Is there a robots.txt to block indexing on
https://public-inbox.org/git/1459432667.2124.2.camel@dwim.me ?
next parent reply other threads:[~2017-09-26 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <loom.20160331T143733-916@post.gmane.org>
[not found] ` <20160331140515.GA31116@sigill.intra.peff.net>
[not found] ` <CAJxkE8SVF_ikHqDCh6eHExq=seitHPVpxW2GmPo40jtqWvz1JQ@mail.gmail.com>
[not found] ` <20160331142704.GC31116@sigill.intra.peff.net>
[not found] ` <56FD7AE8.4090905@nglowry.com>
[not found] ` <xmqqwpoil6vt.fsf@gitster.mtv.corp.google.com>
2017-09-26 19:46 ` Marc Herbert [this message]
2017-09-26 20:11 ` Eric Wong
2017-09-27 21:06 ` Wrong -dirty suffix set by setlocalversion (was: BUG in git diff-index) Marc Herbert
2018-05-24 23:03 ` Mike Mason
2018-05-25 3:50 ` Marc Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9b4725b-3204-03af-1bc2-6469bb815c63@intel.com \
--to=marc.herbert@intel.com \
--cc=andy.work@nglowry.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=michael.w.mason@intel.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome