From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Joel Selvaraj <joelselvaraj.oss@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: arm: qcom: update beryllium compatible property
Date: Tue, 30 Aug 2022 13:00:23 +0300 [thread overview]
Message-ID: <d9b5e312-4999-4410-03be-299e95bbe8b2@linaro.org> (raw)
In-Reply-To: <20220828205723.20834-2-joelselvaraj.oss@gmail.com>
On 28/08/2022 23:57, Joel Selvaraj wrote:
> There are two panel variants of Xiaomi Poco F1. Tianma and EBBG panel.
> The previous beryllium dts supported the Tianma variant. In order to
> add support for EBBG variant, the common nodes from beryllium dts are
> moved to a new common dtsi and to make the variants distinguishable,
> sdm845-xiaomi-beryllium.dts is now named as
> sdm845-xiaomi-beryllium-tianma.dts. The board's model and compatible
> properties are also renamed to distinguish between the variants.
> So update the dt-bindings to reflect the new compatible value.
>
> Signed-off-by: Joel Selvaraj <joelselvaraj.oss@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index fb1d00bcc847..e465ca45c07f 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -666,7 +666,7 @@ properties:
> - sony,akatsuki-row
> - sony,apollo-row
> - thundercomm,db845c
> - - xiaomi,beryllium
> + - xiaomi,beryllium-tianma
The board compatibles are not that important for ABI yet this creates
precedence, so I am against it. Simple renaming should not be a reason
to change compatibles.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-30 10:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-28 20:57 [PATCH v4 0/4] Add support for Xiaomi Poco F1 EBBG variant Joel Selvaraj
2022-08-28 20:57 ` [PATCH v4 1/4] dt-bindings: arm: qcom: update beryllium compatible property Joel Selvaraj
2022-08-30 10:00 ` Krzysztof Kozlowski [this message]
2022-09-02 5:20 ` Joel Selvaraj
2022-09-05 10:08 ` Krzysztof Kozlowski
2022-08-28 20:57 ` [PATCH v4 2/4] arm64: dts: qcom: split beryllium dts into common dtsi and tianma dts Joel Selvaraj
2022-08-28 20:57 ` [PATCH v4 3/4] dt-bindings: arm: qcom: Add Xiaomi Poco F1 EBBG variant bindings Joel Selvaraj
2022-08-30 10:00 ` Krzysztof Kozlowski
2022-08-28 20:57 ` [PATCH v4 4/4] arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce Xiaomi Poco F1 EBBG variant Joel Selvaraj
2022-08-30 10:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9b5e312-4999-4410-03be-299e95bbe8b2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=joelselvaraj.oss@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®