From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753341AbdK1QTE (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 11:19:04 -0500
Received: from mail-pf0-f195.google.com ([209.85.192.195]:41132 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752860AbdK1QTA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 11:19:00 -0500
X-Google-Smtp-Source: AGs4zMbL4TW5bUccl52H03dmBWJUUIZEWtjNpBpH3h6ToVxHd5kvh02y7JZ/11gjiQejRRCFDtzH/A==
Subject: Re: [PATCH] bcache: Use PTR_ERR_OR_ZERO()
To: Vasyl Gomonovych <gomonovych@gmail.com>, kent.overstreet@gmail.com,
        shli@kernel.org, mingo@kernel.org, axboe@fb.com,
        gregkh@linuxfoundation.org, kstewart@linuxfoundation.org,
        linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
References: <1511823900-3151-1-git-send-email-gomonovych@gmail.com>
From: Michael Lyle <mlyle@lyle.org>
Message-ID: <d9b8fd4b-cb38-0bc9-cc27-0029cfe0a936@lyle.org>
Date: Tue, 28 Nov 2017 08:18:57 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1511823900-3151-1-git-send-email-gomonovych@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/27/2017 03:05 PM, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/md/bcache/btree.c:1800:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>

lgtm.

Reviewed-by: Michael Lyle <mlyle@lyle.org>

Will carry in my tree.