From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6D230B520 for ; Wed, 7 Jan 2026 13:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767793769; cv=none; b=FH10esBZpoUjIteXH+iNFp9M72xVkJI6aal1hZoeQqHDRi9sn08gMN9l1bo2RACVsaPqbZfnrmBEhOyiyqJRf2MolmQmTFVpw4OVh1g3TFMYLS1fOqztbPMIOx8rISqj/HwwPmkBO/R2mjD7KzcoB7Khyfd/AqzyRPaWek4xicQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767793769; c=relaxed/simple; bh=CjBZ6lpm/gluwaBs/urTg3hBTAY1XEL5b8Dl7uWZqKQ=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=AEkHmNctUhRcIwWy1jbnYFfD0FRQhet1fEach7lougzpg/pdU/f36IW44D4rHvoUmHZg8tLSvByPBt9cSoobVjeNSx2aT/MOwQZ4UW+irkzF/84q83psTfykExN85H1B1p2ebcZtn7VsmXW4LuXNHMPGpsoZdDJCZbP9L5zEzB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jX4fLLAF; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jX4fLLAF" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4775ae77516so23026345e9.1 for ; Wed, 07 Jan 2026 05:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767793766; x=1768398566; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=muR3VLqqfejkmv2BmcAcvMLZuPKZEAOQ6QGoVQtHG9A=; b=jX4fLLAFoqL82f68N5Xst6N/zJRAKnxfYuXMb53ih6WlEptdRgfTHlOMYCPOPBfl4N cVQM6mI0JqsPLdOs6eo8/CNRvVDENyN16xely5r+CSex9I9yCA9/7H2y+tWsnQd3KOaG +Y5kEwExOweCBKCOOjHAbwOoOIovY1PMKT1t302YB8b+I1HOAZacOuTG7L/9XfGN6by2 AiUU3vTSbrL067EoQIrJzzVsaK5xo4GSMKXUGhW4EnOeqvsvB42T65E8OxSb0PKHDi7j Xv9en/C3rhZe/U1kQnpAD5cC38TKJyl5qpbNAGLmzm3wxnjIRNDKuSwARg9WE3p0QPSm EaOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767793766; x=1768398566; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=muR3VLqqfejkmv2BmcAcvMLZuPKZEAOQ6QGoVQtHG9A=; b=vdmHUfCMJE3vK1oMxJiPwbwdXi2ZD+QrU28wKHDYXcUb2flhJUuM84Hp2nMKrIIh/t QF/SD2+3xe9vd4itDntGhNnjvgal1+IFCjvX9/4DRVR3t7d3L32oNKY35NGQi+/XEx5c tDdFiYFf0w/wg1A0etK4X+MnC7o0wx4VCoAJb+Koqr8al+mF7/ggcXoUQnenpMY+pYfi 2DRJ5S9NNsR0Lvn26IHFXXQGbVj+B9LsUqsvrvUjPjcIXhqQmPRUmP3GR+5x8JkdMoLw ozJk4fHVjEAG2KWP09jvoBIGPNlvECh4MDXUXhkiw5iz1ECWKOFtjdGDU8UiORcYHY+C 6pJg== X-Forwarded-Encrypted: i=1; AJvYcCUG2LPb5B4bDI3KMhTUxmf4sFbLGV5xtq9WGmNdJ7PGVRMiZb8km1MvuzO+f9ngFsb41EuzXE9QkKO1UHU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxj4z1hH9rPcOeDkYA5pkXjImUalVPp7baOfIdW6+xgB9T1IdsR pYmXiwiua9XaI1uPlU/qnznLweiIH7mRSnxUR2wjX2OYCaeN8kcpTLTu X-Gm-Gg: AY/fxX6Z1IJUePYCa+yNNKlq9E6xtGSsuaa7ne4MYlzcoBtMlRBF9Qe4yZhYkQlrnZx 7hP2tP8imi9A+P7Kron3d0wlkFFF5g85ui9dtDbUMT8JXyEG+9Pz0xcTutrAi+Wo1s2tkKBV2i7 64szy6j9rbfQMX1q+zWVr9XBS6DvBmEitNV8C5nZK9Jphbin7uvwgIircWXz2dCvg68QSrhMn2K HwglqSt2zdqJHTAn+/0+BNAhaMpGcNd4drCGIKaM32ixLarrhjqJ3/Di8dqOKjXliq2L63/4L/O uuMxJiOO9T9I6xBU73GE1VJmOWr7VWG0KsJ8OnzIhcgzgACGYwGYj/afTwaLt9uiCUW2g/XX6gQ 8s2KKkNzjJA2Kv6G2nnl1qC0y3TmWABJ/QG3Um7jb7xrd7K5i2QybfPawsGBx71USa0W2Rxt8YT OXrdf/iOTiFUbzUi+rbBw= X-Google-Smtp-Source: AGHT+IHOSGN4Xv5l08m8bU8YN5bcOmKa/WR6M2fI+vb5Ei/oXFAOWRuxZEJSEMIFXdnp5vzFKC7ZKw== X-Received: by 2002:a05:600c:3b28:b0:477:9b4a:a82 with SMTP id 5b1f17b1804b1-47d84b41152mr30263045e9.35.1767793765458; Wed, 07 Jan 2026 05:49:25 -0800 (PST) Received: from [192.168.1.187] ([161.230.67.253]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8719e695sm12067035e9.17.2026.01.07.05.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 05:49:25 -0800 (PST) Message-ID: Subject: Re: [PATCH 1/2] iio: accel: adxl380: Store sampling frequency index in odr struct member From: Nuno =?ISO-8859-1?Q?S=E1?= To: Francesco Lavra , Ramona Gradinariu , Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 07 Jan 2026 13:50:07 +0000 In-Reply-To: <20260107123518.4017292-2-flavra@baylibre.com> References: <20260107123518.4017292-1-flavra@baylibre.com> <20260107123518.4017292-2-flavra@baylibre.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-01-07 at 13:35 +0100, Francesco Lavra wrote: > The ADXL380 driver assumes that acceleration samples are always retrieved > via the high-performance DSM signal path; as a result, the sampling > frequency value depends exclusively on the decimation filter settings in > the TRIG_CFG register. > In preparation for adding support for sampling frequency values that rely > on the low-power SAR signal path (on which the decimation filters are not > supported), use the (currently unused) 'odr' member of struct adxl380_sta= te > to store the sampling frequency value, and when userspace requests the > current frequency value, retrieve it from the struct instead of calculati= ng > it from the decimation filter settings. >=20 > Signed-off-by: Francesco Lavra > --- Reviewed-by: Nuno S=C3=A1 > =C2=A0drivers/iio/accel/adxl380.c | 13 ++----------- > =C2=A01 file changed, 2 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/iio/accel/adxl380.c b/drivers/iio/accel/adxl380.c > index ce3643c5deb8..bbf1f88ca781 100644 > --- a/drivers/iio/accel/adxl380.c > +++ b/drivers/iio/accel/adxl380.c > @@ -417,17 +417,7 @@ static int adxl380_read_chn(struct adxl380_state *st= , u8 addr) > =C2=A0 > =C2=A0static int adxl380_get_odr(struct adxl380_state *st, int *odr) > =C2=A0{ > - int ret; > - unsigned int trig_cfg, odr_idx; > - > - ret =3D regmap_read(st->regmap, ADXL380_TRIG_CFG_REG, &trig_cfg); > - if (ret) > - return ret; > - > - odr_idx =3D (FIELD_GET(ADXL380_TRIG_CFG_SINC_RATE_MSK, trig_cfg) << 1) = | > - =C2=A0 (FIELD_GET(ADXL380_TRIG_CFG_DEC_2X_MSK, trig_cfg) & 1); > - > - *odr =3D st->chip_info->samp_freq_tbl[odr_idx]; > + *odr =3D st->chip_info->samp_freq_tbl[st->odr]; > =C2=A0 > =C2=A0 return 0; > =C2=A0} > @@ -500,6 +490,7 @@ static int adxl380_set_odr(struct adxl380_state *st, = u8 odr) > =C2=A0 if (ret) > =C2=A0 return ret; > =C2=A0 > + st->odr =3D odr; > =C2=A0 ret =3D adxl380_set_measure_en(st, true); > =C2=A0 if (ret) > =C2=A0 return ret;