From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2AF5377A89 for ; Fri, 7 Aug 2026 08:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786091637; cv=none; b=P5ztg7D1sTyZlxJzg0RMR9hHz2K/xkHodGV2grpvzUrGC+luIltkMoqx4nJBUAPwmOLQP64yDIji+RgusVCHZTxvG3o5aGmxTrX52kPkJg8mK9+MgeZp473V9obVX8pk6LzOrh7rv+KLkJwjbuNDqY0Qtj87yT01w1tGUDCDmQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786091637; c=relaxed/simple; bh=x1vVKhvudq3tk61eX99pQTPKqzE1dzS9VLqLKXITMPw=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=C+iA9sc3K68NpW1q3d4MVM6iEkTKYYhzgF4oBkA+pCiAFQ+Sae2vYZE6exvDP2gOjLzp4ZWJGKItzrg7LqKmE0bpQhn/0gmAxf8yJriEDjFtKCNx0PIgCrbcGk7CmuiURbHq5Nj0TFDTsipoAtZB3fMIoDKufKt4ObeAj8pM1eE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H7axpo+s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZKNzoahm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H7axpo+s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZKNzoahm" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67782Dur4063176 for ; Fri, 7 Aug 2026 08:33:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= L3wO87GXdMZGUsWi3XJQTeTTHtW11dI5D+jHGfKjZEU=; b=H7axpo+sdS1G5PPS ud7SqW8n1iTiZBW5B+oRtcscyfCrcuVUE3ZcTxKNTNBEE/HTK5LE0p6wLOnuPTfQ AsYRNoXudI5w1fKkCNSP9+aRhs35FfUEWl3DTkphXz0a+TZ+qaCmCxwhXeMm8aZf OwUHnqS7PQl4aHXHYoPPV+Zg4kTlwFBN4aqpScxyjVTvKU5c2SUi66KzHin9NPQN ChVByH73UJIBlyg/EcGFygITRq0sTQ9wO0vTshGm35KHBtsX+RI20k71trcCTg0s 6sY0cvgufheIJvbLhaJIqyyXIRTqOTmGmLGFEPNyDlO5MSXAhWWbHpk2MMWEp1FC 2VJAxg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fvy6haxua-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Aug 2026 08:33:54 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84865f326efso3794451b3a.0 for ; Fri, 07 Aug 2026 01:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786091634; x=1786696434; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=L3wO87GXdMZGUsWi3XJQTeTTHtW11dI5D+jHGfKjZEU=; b=ZKNzoahm0II56mC5HubHshdaUqkXpYtDDEessXphn05jvYMLzGLDk/7t6ZEbDhifvZ hdqG0mhV7woMtPcQrtyonkL8Zr7y3Hi5UyNnrSqwloH6OaPtDP+gpOWQ2tHs70gIDU1Q GCnmqYQZSphGaHn3E9TDKBoVCP73t50WaOUHqo3obOdRMTh0vSyEL59gP3edpK/50wY9 AXmK3iaL7hylPCgOf5FxdH4kFVUS7irc4ESwQU22b2+Xz3eHTXLW3PhzEa6UHmfyOBZU j2ns5cHBI4xRe49HSuGyZtSjjkTo3KYxS8SVgL1q/axQinIaW+tuRl6MGOTlBLl6Dv3t G9lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786091634; x=1786696434; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=L3wO87GXdMZGUsWi3XJQTeTTHtW11dI5D+jHGfKjZEU=; b=rA8k3TycLn6m9Kkz9V+jGRsvlEdatbccJISCmKRxQ7KUrl+hoWuBG6W6Z55gzEFg+g q9mw41hdafnCvJmW+d5lleIRZPSyxsg/UdQ8ilTFQudUCWD3dJ9kNUr1XLNaU1dpRaOY N54eOe1VGN9TXXDAmSnrsjyt79aqkgQicBsxk5Oiss8Y4SDEhU0kHzGZIUsDH18G3hLH oFSG/u7egNowpYPMx81IOU51kKufTHLKNKnY3dqQkcu2B4bsYaL3TpcGmamAUL0pzwP2 iuw545e7/LByZRMfFb5fRlAvdt/A987dZtXRDaIlAGpDMMEzvJ3fHSM1QIOG1PV8l4Sv poWQ== X-Forwarded-Encrypted: i=1; AHgh+Rqnw/gGG+JpI4RIj1IViv9CbKI+e7wuhpcH2ZkTrqVI9XcAEyFFgc2RkpyWA3d5vr3AaYNvPA5lEs8NoRc=@vger.kernel.org X-Gm-Message-State: AOJu0YwnKgwTRp0n8Rexgf/cYLNqy6HmuuZkulUP4mqSkVFP7XLh4EaK +tmZ89lf6kTh1fepKb0NYGeGs3K2NmKiSQ9P4HZhg6Zy5YjVgtl8ozHT3wce6C21c1sYML24Wap UQGGjtXEjhuav8Xb9RbdfdKEAHOuRJZD1AMghIFEIBGXXE+YFNvtuxs/1cNjJT+rFm40= X-Gm-Gg: AR+sD10gnwv74vXcsVDFnodOFalfc7l4mZfGwfvum6yIgAuwhEFNiPRpIvXQDBpDQb2 mRRif4N3OCbJr+iTex0VPKEXsv1M3EWtM2TrdmlYDXFflQTatbsvJQ6qwKEKEGAtJMSaBa2BE+A ZFezhtYqO+hx8v7n/VHgi65udITn6txmedKeP1jhuDGCcgfO5jURwkX17Jkvq1vhbeKudS9og5v floVopM1n8h5IXpt0xfW9QY4KLI8aXir2bQZe8pdjVpNsL63zDSgeNmZhVF/SGVErHLU+3M2+tZ MhBBs2J/Pd+LPQfl5KN2ieOr7geDS5GTV7ElWBntrHTYTagD0GXY4Z0mBRKaJOMrCQrImEMeDb6 9IZ5Y/JFiCeIfs60pQxJKcteMzgvaebGvTA== X-Received: by 2002:a05:6a00:a116:b0:847:439b:ae30 with SMTP id d2e1a72fcca58-84f2e04b336mr22951204b3a.20.1786091633781; Fri, 07 Aug 2026 01:33:53 -0700 (PDT) X-Received: by 2002:a05:6a00:a116:b0:847:439b:ae30 with SMTP id d2e1a72fcca58-84f2e04b336mr22951163b3a.20.1786091633331; Fri, 07 Aug 2026 01:33:53 -0700 (PDT) Received: from [10.217.219.96] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a3a2173sm649751b3a.1.2026.08.07.01.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2026 01:33:52 -0700 (PDT) Message-ID: Date: Fri, 7 Aug 2026 14:03:49 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i2c: qcom-geni: Simplify PM resume error handling To: Mukesh Kumar Savaliya , andi.shyti@kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260805070013.494426-1-mukesh.savaliya@oss.qualcomm.com> Content-Language: en-US From: Viken Dadhaniya In-Reply-To: <20260805070013.494426-1-mukesh.savaliya@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=G60s1dk5 c=1 sm=1 tr=0 ts=6a759872 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=6z8TwaGRFWoLiM2ZyNYA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: TM9nbqFnb3Caq80hj-2_k0_4C7t6eOEi X-Proofpoint-ORIG-GUID: TM9nbqFnb3Caq80hj-2_k0_4C7t6eOEi X-Proofpoint-Spam-Info: AW1haW4tMjYwODA3MDA2MyBTYWx0ZWRfX82RO32+4AwBI 6bwabE/9Ur5QMq5ZgMgVB0y4FjUTEiepdQTnlgXlo5bclPUywExAI2awfpiYkM/wTXUCPA3CCxt ZAu2eipM0ZJlpM13OZ8evpD31ZOs9As= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA3MDA2MyBTYWx0ZWRfXy1FMR+HoDqoP hiAVlHNyYajupnHnIjB3NaOgLVsN6pZ0KQwqWTureDxaNj5nMDl7yqZ+I5/SelhavZ5Fk55T+pM X3dH6YRcJuN4putiqb70K8fBvCKBsgegETNSxWwH270J1OXK82TXJsu+g/jLtYPrP4giCvKaUsO 6yX0i7nFRGhZg6Omnpazt0p+rXUzN4GCVui90TEKd9zKYVkiYKfSm47EHK3l5h5hhQN9k879ege OksFv6qESluZo58JGQFa/HPY6MeT62LfiNSYaP3vLRxWxErzkOXSKOU8MBp1bswkZDlEgbS/XpK NcQRFjEl9vLjw1eDwihFztfrLPZctKvbmjEcIErpa56FgUzIxTPOVT9DJUsRAi/sBjZmsKL6AzI 2v+jAXL+LAmjcMy7kIcHMgz5sKZBtyKRBsP4FDZM5CLcyyk6QbGuf2i4cr56cpdozFdyTyNBPKo ro6DVaI1vNU3tuaGV6Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-07_01,2026-08-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 phishscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608070063 On 8/5/2026 12:30 PM, Mukesh Kumar Savaliya wrote: > The driver currently logs pm_runtime_resume_and_get() failures with > dev_err() and returns the error code separately. > > Replace this with dev_err_probe(), which combines the dev_err() log > message and the return value propagation into a single call, consistent > with how all other error paths in this driver already report failures. > > No functional change intended. > > Signed-off-by: Mukesh Kumar Savaliya > --- > drivers/i2c/busses/i2c-qcom-geni.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index d5c977e34994..96015e077b69 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -994,10 +994,8 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) > int ret; > > ret = pm_runtime_resume_and_get(gi2c->se.dev); > - if (ret < 0) { > - dev_err(gi2c->se.dev, "error turning on device :%d\n", ret); > - return ret; > - } > + if (ret < 0) > + return dev_err_probe(gi2c->se.dev, ret, "error turning on device\n"); > > proto = geni_se_read_proto(&gi2c->se); > if (proto == GENI_SE_INVALID_PROTO) { Reviewed-by: Viken Dadhaniya