From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85DFE3431E3 for ; Fri, 10 Apr 2026 09:25:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813104; cv=none; b=Oupvxx9FPQiOFg7A6UzFGDYzPD9TeY8J028hvYfoTh2/S08p9BX+fogHo0GJYlg27T0XNy7dXDzLdlRQAzrwELCh1o3irLciJH+Xplfek9RxERTYS6cwxJLZ1re4Zelki37TqqSQ7Hxi0Bajel7u2IopUQLoz+RKfYkTduYAahc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813104; c=relaxed/simple; bh=uAoFiXQldyDKMQPKhMx3P5oajVo9oIWg7TC1U+INyCc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tyS2EUjfvWxybNKiqi5rQPcKkMcdgMnzZ8aSmpa+OBRMWr6ExVI5zHi0fWk7pi0f//tNOpQOCBMBzSc6ZfBEvLNx77LQPTJMXqlPnCzcDPxiEVuVwZaBrYGJMOslNKhxup1ZIUEKpapemZxcevafYXTntGi15nc4OHTimijzSYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kn20TnIu; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kn20TnIu" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488aa77a06eso28488685e9.0 for ; Fri, 10 Apr 2026 02:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775813102; x=1776417902; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EaqDywoj+uSpm9uhbUsCqEBrRoto0iCeBK1SrvtZ+mA=; b=kn20TnIuQeo09A2DeFBHRFrJqzN1xPdznRiyv0y4oq+3zRo5fThW8ia0BrqM+79UOE 8kbFOESS995/74O+iX8gOsLsB1cX9Me0lJS0VSZ0z4bJ15vE+CUVbGA3oMe4pvkaY7nf ClzimLxgz7xjolWe+ZYKZCr0tL5auKBvQ9GPjB0b/1aQqdHS72ktkftBnBZBbfkdZqLP 4sEPDdUrqqprF7XHSJnIsDVqUyuTYphC6BCUa7NyTzuXt8EeOscdGoktzQ0Up1f5eeFO 6fnl9UF/wSLEv1lwC6a3LInmz46OVTZQEr8lGrCxqYBzv7kH2v7uENaFRqY9snv6aaaq K5Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775813102; x=1776417902; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EaqDywoj+uSpm9uhbUsCqEBrRoto0iCeBK1SrvtZ+mA=; b=DxKqTTEW+R1I3vgPXmoIfY4/JdyzqkAsPBR4emZjazRK3TfPYa04kaL6z2JPXqwK2J 3dWWFIsO9XQ+aWpiOqpzFdaNZyVnSFQGu5CUTh3y4XTJyntwXkxVttsRxY9EzM45Ug1q I+WV9x1ke97PBScd0lReQ6v0SWpZhuHG6QkpqqrBzEff9JJ/NTjrm1bWrtKbBVKCfkdZ mbm9ouRKUYWuOiD3KaUUvUncNPvbtq2mnXUn36AlhnSkCYYp3Fxon/aRvwwfzg0Ai5CQ zTm8b7CzZuXVMSZCF4KCYpI9VFahj3nGd4z0NgH7V8YvxBlNhpPq06t1h+1/FtX+/NaW FNMw== X-Forwarded-Encrypted: i=1; AJvYcCUEBusXK/hqn2R1ZBRL1IBagBtZTIJiFgLQpq4R80/EP9OJIwDRqBgcr347sSjvSJ1lmb4C/v4mrHqRcaM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/s1RJxh35uWKi7OsaU0bnn+ZiDDh3WAG2kVlzhuvTXBxU065x bVWIGptDqtLbGdM6ulQjMVugewO0Q9++UqPQP2PxiXaGkfhw4BANBWfSBT+jj0FoQks= X-Gm-Gg: AeBDiev0Q0xUvBMv9g8nPHPWSt0tvDKcwaneVPmifGN15B64H/IIMAh3X9WmJU1LgJl 9OkmmTyL6vmIYp9Vs7ErZkFBysh40zPtx2zVi5GBFr8btwTeFHRO584UjlsiAyrP15x03snEMUq shh64jxvwNnJDo+/6zkSd+TZoO6Q1K5wZhxSQK/AaLcj1+ETC4nsqcyG84OL+sGLhOO53IyMqoH IceXXajpIF/2AYc1HPZGqZS7LaXDPBDCqEUp2FdFmQsLlgun/nqgHNc4SqxhooYyiUonScW94WI H7AJP+0rd6YKxK5Hu9nk4ost7nsTiT9Be/fggDfGV01d4WaPPhJSP80yqKuVEzvValtIb8DXozE OWXvr/0laX0Y81kxq2bthriPUOC9Y6GBNJZTji9SSdDGB3Zo8biBGkHJUUJhqTkRV62PN5uQeME nDFsSSfp9C4AdnzWp33lQDV71V7h2S X-Received: by 2002:a05:600c:a411:b0:488:af48:af11 with SMTP id 5b1f17b1804b1-488d67c749emr22931015e9.1.1775813101910; Fri, 10 Apr 2026 02:25:01 -0700 (PDT) Received: from [192.168.1.3] ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d681ea59sm16117725e9.14.2026.04.10.02.25.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2026 02:25:01 -0700 (PDT) Message-ID: Date: Fri, 10 Apr 2026 10:25:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] perf build: fix "argument list too long" in second location To: Markus Mayer Cc: Perf Mailing List , Linux Kernel Mailing List , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter References: <20260409221418.185343-1-mmayer@broadcom.com> <20260409221418.185343-2-mmayer@broadcom.com> Content-Language: en-US From: James Clark In-Reply-To: <20260409221418.185343-2-mmayer@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/04/2026 11:14 pm, Markus Mayer wrote: > Turns out that displaying "RM $^" via quiet_cmd_rm can also upset the > shell and cause it to display "argument list too long". > > Trying to quote $^ doesn't help. > > In the end, *not* displaying the (potentially long) list of files is > probably the right thing to do for a "quiet" message, anyway. Instead, > let's display a count of how many files were removed. There is always > V=1 if more detail is required. > > TEST linux/tools/perf/pmu-events/metric_test.log > RM ...634 orphan file(s)... > LD linux/tools/perf/util/perf-util-in.o > > Also move the comment regarding xargs before the rule, so it doesn't > show up in the build output. > I'm assuming this is just a cosmetic issue so it doesn't need a fixes tag? And "upsetting the shell" doesn't cause a build failure? Otherwise looks good to me. Reviewed-by: James Clark > Signed-off-by: Markus Mayer > --- > tools/perf/pmu-events/Build | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build > index dc5f94862a3b..dc1df2d57ddc 100644 > --- a/tools/perf/pmu-events/Build > +++ b/tools/perf/pmu-events/Build > @@ -211,10 +211,10 @@ ifneq ($(strip $(ORPHAN_FILES)),) > > # Message for $(call echo-cmd,rm). Generally cleaning files isn't part > # of a build step. > -quiet_cmd_rm = RM $^ > +quiet_cmd_rm = RM ...$(words $^) orphan file(s)... > > +# The list of files can be long. Use xargs to prevent issues. > prune_orphans: $(ORPHAN_FILES) > - # The list of files can be long. Use xargs to prevent issues. > $(Q)$(call echo-cmd,rm)echo "$^" | xargs rm -f > > JEVENTS_DEPS += prune_orphans