From: Joe Perches <joe@perches.com>
To: David Laight <David.Laight@ACULAB.COM>,
"'joelcchangg@gmail.com'" <joelcchangg@gmail.com>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gregkh@linuxfoundation.com" <gregkh@linuxfoundation.com>
Subject: Re: [PATCH] staging: octeon-usb: Fix 'should not end with '(''
Date: Sun, 06 Feb 2022 11:50:30 -0800 [thread overview]
Message-ID: <d9ce0f60350b867e65bb0a05f961c42d6c20d4db.camel@perches.com> (raw)
In-Reply-To: <8536ca17c2945cb77c506d99eff5ccc42e71f2f3.camel@perches.com>
On Sun, 2022-02-06 at 09:17 -0800, Joe Perches wrote:
> On Sun, 2022-02-06 at 14:16 +0000, David Laight wrote:
> > From: joelcchangg@gmail.com
> > > Sent: 06 February 2022 07:46
[]
> This _might_ be better with the return type on a separate line
>
> Something like:
>
> static struct cvmx_usb_transaction *
> cvmx_usb_submit_transaction(struct octeon_hcd *usb, struct cvmx_usb_pipe *pipe,
> enum cvmx_usb_transfer type,
> u64 buffer, int buffer_length,
> u64 control_header, int iso_start_frame,
> int iso_number_packets,
> struct cvmx_usb_iso_packet *iso_packets,
> struct urb *urb)
As this is a static function only used by this compilation unit,
it's maybe even better removing the unnecessary cvmx_usb_ prefix too.
Maybe a bunch of unnecessary prefix removals...
next prev parent reply other threads:[~2022-02-06 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 7:46 joelcchangg
2022-02-06 14:16 ` David Laight
2022-02-06 17:17 ` Joe Perches
2022-02-06 19:50 ` Joe Perches [this message]
2022-02-07 1:57 ` Joel Chang
2022-02-07 8:09 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9ce0f60350b867e65bb0a05f961c42d6c20d4db.camel@perches.com \
--to=joe@perches.com \
--cc=David.Laight@ACULAB.COM \
--cc=gregkh@linuxfoundation.com \
--cc=joelcchangg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®