From: Jijie Shao <shaojijie@huawei.com>
To: Simon Horman <horms@kernel.org>
Cc: <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
<salil.mehta@huawei.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<jiri@resnulli.us>, <shenjian15@huawei.com>,
<wangjie125@huawei.com>, <liuyonglong@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5 net-next 4/4] net: hns3: add support to query scc version by devlink info
Date: Mon, 11 Mar 2024 17:55:36 +0800 [thread overview]
Message-ID: <d9d10da3-5b13-4a48-9236-d29fdf48220e@huawei.com> (raw)
In-Reply-To: <20240311091904.GA24043@kernel.org>
on 2024/3/11 17:19, Simon Horman wrote:
>> +#define HNAE3_SCC_VERSION_BYTE1_SHIFT 8
>> +#define HNAE3_SCC_VERSION_BYTE1_MASK GENMASK(15, 8)
>> +#define HNAE3_SCC_VERSION_BYTE0_SHIFT 0
>> +#define HNAE3_SCC_VERSION_BYTE0_MASK GENMASK(7, 0)
> Not strictly related to this patch, but FWIIW, I suspect that
> hnae3_set_field() and hnae3_get_field() could be reworked to use / replaced
> by use of FIELD_PREP and FIELD_GET. In which case I suspect that the
> *_SHIFT #defines would no longer be needed.
Yes, using FIELD_PREP and FIELD_GET is a better option.
But I'm not going to modify this patch.
If it's necessary, I will send a cleanup patch later to
replace all hnae3_set_field/hnae3_get_field in driver.
next prev parent reply other threads:[~2024-03-11 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 10:00 [PATCH V5 net-next 0/4] Support some features for the HNS3 ethernet driver Jijie Shao
2024-03-09 10:00 ` [PATCH V5 net-next 1/4] net: hns3: add command queue trace for hns3 Jijie Shao
2024-03-09 10:00 ` [PATCH V5 net-next 2/4] net: hns3: move constants from hclge_debugfs.h to hclge_debugfs.c Jijie Shao
2024-03-09 10:00 ` [PATCH V5 net-next 3/4] net: hns3: dump more reg info based on ras mod Jijie Shao
2024-03-12 3:03 ` Ratheesh Kannoth
2024-03-12 3:42 ` Jijie Shao
2024-03-09 10:00 ` [PATCH V5 net-next 4/4] net: hns3: add support to query scc version by devlink info Jijie Shao
2024-03-11 9:19 ` Simon Horman
2024-03-11 9:55 ` Jijie Shao [this message]
2024-03-12 4:29 ` [PATCH V5 net-next 0/4] Support some features for the HNS3 ethernet driver Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9d10da3-5b13-4a48-9236-d29fdf48220e@huawei.com \
--to=shaojijie@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®