From: Tony Battersby <tonyb@cybernetics.com>
To: Christoph Hellwig <hch@infradead.org>, Keith Busch <kbusch@meta.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Kernel Team <kernel-team@meta.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2 11/11] dmapool: link blocks across pages
Date: Fri, 23 Dec 2022 12:08:54 -0500 [thread overview]
Message-ID: <d9d58b20-5ce5-ebfd-bcfa-523086b66739@cybernetics.com> (raw)
In-Reply-To: <Y6XeJ2mzd8p73J93@infradead.org>
On 12/23/22 11:58, Christoph Hellwig wrote:
> On Fri, Dec 16, 2022 at 12:16:25PM -0800, Keith Busch wrote:
>> unsigned int size;
>> unsigned int allocation;
>> unsigned int boundary;
>> + size_t nr_blocks;
>> + size_t nr_active;
>> + size_t nr_pages;
> Should these be unsigned int like the counters above?
I previously recommended that they should be size_t because they are
counting the number of objects in the entire pool, which can be greater
than 2^32. See patch 4 "dmapool: cleanup integer types". However the
kernel test robot has complained that some of the printk format
specifiers need to be changed to match the size_t type.
Tony Battersby
Cybernetics
next prev parent reply other threads:[~2022-12-23 17:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 20:16 [PATCHv2 00/11] dmapool enhancements Keith Busch
2022-12-16 20:16 ` [PATCHv2 01/11] dmapool: add alloc/free performance test Keith Busch
2022-12-16 20:16 ` [PATCHv2 02/11] dmapool: remove checks for dev == NULL Keith Busch
2022-12-23 16:27 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 03/11] dmapool: use sysfs_emit() instead of scnprintf() Keith Busch
2022-12-23 16:28 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 04/11] dmapool: cleanup integer types Keith Busch
2022-12-23 16:29 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 05/11] dmapool: speedup DMAPOOL_DEBUG with init_on_alloc Keith Busch
2022-12-23 16:29 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 06/11] dmapool: move debug code to own functions Keith Busch
2022-12-23 16:31 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 07/11] dmapool: rearrange page alloc failure handling Keith Busch
2022-12-23 16:31 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 08/11] dmapool: consolidate page initialization Keith Busch
2022-12-23 16:35 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 09/11] dmapool: simplify freeing Keith Busch
2022-12-23 16:38 ` Christoph Hellwig
2022-12-27 20:21 ` Keith Busch
2022-12-16 20:16 ` [PATCHv2 10/11] dmapool: don't memset on free twice Keith Busch
2022-12-23 16:39 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 11/11] dmapool: link blocks across pages Keith Busch
2022-12-17 2:39 ` kernel test robot
2022-12-17 3:49 ` kernel test robot
2022-12-23 16:58 ` Christoph Hellwig
2022-12-23 17:08 ` Tony Battersby [this message]
2022-12-23 17:15 ` Christoph Hellwig
2022-12-24 14:55 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9d58b20-5ce5-ebfd-bcfa-523086b66739@cybernetics.com \
--to=tonyb@cybernetics.com \
--cc=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®