From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938C9C433E0 for ; Mon, 18 Jan 2021 18:26:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65DA722CB1 for ; Mon, 18 Jan 2021 18:26:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393626AbhARS0h (ORCPT ); Mon, 18 Jan 2021 13:26:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34102 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407587AbhARSZ4 (ORCPT ); Mon, 18 Jan 2021 13:25:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610994270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eWykzve3UBcllvD35C3br937OB5w9uaX2YUqimi9UUM=; b=fnlVnZzcBsOiXj54EWwRekcqk7zeap1rtFVNs72K0Dfy6KdiD5LMBpPudHSJ2uCXE/wWcF tYy5p0wkylwyj/n12uk34ELoyel2v8HTy4XW+jrAly7XiDsQPwBPMdE8LNMeSD6VEQWeEu 3/0qt2CPldkS101vZd86q5eB/yuhKfc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-491-aY5xt19lN-2g_liRevRARg-1; Mon, 18 Jan 2021 13:24:26 -0500 X-MC-Unique: aY5xt19lN-2g_liRevRARg-1 Received: by mail-wr1-f69.google.com with SMTP id z8so8740564wrh.5 for ; Mon, 18 Jan 2021 10:24:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eWykzve3UBcllvD35C3br937OB5w9uaX2YUqimi9UUM=; b=eLk2m84Xpf0POJhTVHgRnjvsTWmsXQttbWbFCVxct6nFM54/fGAKV9vnx83J02pfB/ PpSLNjrelVEx/6/hHzn7ke64mmQ9ice7RdehpL67hISTF3Yn6Mp5vWUbAIKMUDUBiLdT ZSssG2B9dT10nQ5bGbQcvugmbxv5jBmfqUcVaUe3rEWh8SkAeSdqQgy9lPFiOq1kAbXn /UloJbaOkIYvi9mPsZuwDQE/TuRLZvFxvdDsVlzC/KktmDXMlPvixiWbRwEC3FcYPpwF wL17M/3gA2AWknG6CEJ/XvLpHyyinOQcr10NPY1HueOu/pNq3hmyHFI4BHq6pp4dbIDx 1RLw== X-Gm-Message-State: AOAM530sieq9Cys4XRvqqsTugb1WVchJoM3qbryrSK4aeqJus/XMwN2n 6ntmmaX7PkG3D8UiLTh6ePoZu21+mWkBrxx/8dsI80Z+BS0fEQkpWKjzjyPPmcExF2o+aOc7A+X DSDL9hoSEmrGvVIN+OUso8QE1 X-Received: by 2002:a05:600c:618:: with SMTP id o24mr625760wmm.82.1610994265119; Mon, 18 Jan 2021 10:24:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJx49lMoWqrOmyl2CbqcL+DnBsCRYRP77yi3LtDI3+61TNIpnRPHLY/Tm082FtK8UnGCy68ymw== X-Received: by 2002:a05:600c:618:: with SMTP id o24mr625743wmm.82.1610994264945; Mon, 18 Jan 2021 10:24:24 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id h9sm286767wme.11.2021.01.18.10.24.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 10:24:24 -0800 (PST) Subject: Re: [PATCH 0/2] KVM: VMX: Avoid RDMSRs in PI x2APIC checks To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, luferry References: <20210115220354.434807-1-seanjc@google.com> From: Paolo Bonzini Message-ID: Date: Mon, 18 Jan 2021 19:24:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210115220354.434807-1-seanjc@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/01/21 23:03, Sean Christopherson wrote: > Resurrect a patch[*] from over a year ago to avoid RDMSR in a fairly hot > path in KVM's posted interrupt support. Note, in my response to that > patch, I suggested checking x2apic_supported() as well as x2apic_mode. I > have no idea why I suggested that; unless I'm missing something, > x2apic_mode can never be set if x2apic_supported() is false. > > [*] https://lkml.kernel.org/r/20190723130608.26528-1-luferry@163.com/ > > Sean Christopherson (2): > x86/apic: Export x2apic_mode for use by KVM in "warm" path > KVM: VMX: Use x2apic_mode to avoid RDMSR when querying PI state > > arch/x86/kernel/apic/apic.c | 1 + > arch/x86/kvm/vmx/posted_intr.c | 6 +++--- > 2 files changed, 4 insertions(+), 3 deletions(-) > Queued, thanks. Paolo