From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3DB03976A8 for ; Fri, 17 Apr 2026 08:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776413039; cv=none; b=GxBMK/eDw8LdZ4Mqk+cDeuEcsNeoNZXNCYdFqjtk/inqrvuUjG73xoop1wlNzM4qw5Obv6urCRDoDJhoj/lUyhMXZuCe55Ua1dyirfs+M4cBg2zZy8++vmw9FFpMjkKF97LatxxrJqNvWyiy4vP23vSzZLB73nvSTxnbPVYKsVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776413039; c=relaxed/simple; bh=dVf0tDRfYV0EzjitgKHGt/ACv6OrCSUpDY8gGVmdRyE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=pRtloLcwQ1mvqVeryLxO5SkAWrTESha855wCaBx6PB9gbUsjuMnTPOGZmPV7SFqSSYgyOVN1ilpCWGdFN040E+C2Tmrs6MjdaKZU/+N+CrBfh4FRTl9HP00UUAjAOLsMjg2d5w8o3hwDtKsQ+S+Haq6jQ5LQdHwsJUNQp0nUZ1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=h318rwtT; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h318rwtT" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43d64313c39so312374f8f.3 for ; Fri, 17 Apr 2026 01:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776413030; x=1777017830; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=XE6xfSRuXBnGz4oHPzb9Vsu04Db0wF2janEZQn/5PfE=; b=h318rwtTmepgFUKyZ7xccdbndwCLdWiZq/nG9kiDSQsVerghhyK+2XQAJZjw0cHK3U 2ZHnrsaNvwFaIcEouwvcJwi+cqBUty8rAjCEZjHPNvnIUDkh9ikfosDhrqxbz3IUxJ/+ XhE0SYGDmHsB0/grHlBtfjV8RWtozx27nbFPrPSh5XDj1sI4awT+eRNLtlSWMdcuPZr1 7mmzn89NQD3mWDv6Pz/cF3fUn/FZGIi0CHO8EVN6okaEG4RlAr9p/VphaeMC/vYZSSJP IVMsEyIKxc1Gc+eFXKfvbYMMx3f2NjHSNzbTAmjvtrwd2qGtyYZbydsLwtuPeZOMKl3y i2vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776413030; x=1777017830; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XE6xfSRuXBnGz4oHPzb9Vsu04Db0wF2janEZQn/5PfE=; b=Lea60FZh+0KOKQ4/qWYS73ScmnFFZJeubg3rIV/H7GAFCm3q8dadjmYPwf4OEeURYA RmP/rEzEax4YdzhfO/dns0t0cRXmHdxZtcfxk3SSxVU8snqfkDz/qHMiLUa1UsGIEBZ3 GJjaS5iva1JP643wlsPGarKUVecAvZxtInDgLj307gEzYkp4T/dpDI9BIrI4aDIIQv5m 3T9weeVw3kfCrTgeD+LzTqMWlqkc2Uqh653MOngqdR7JouMlEBVIeFiLc2CWIZaKHsNM ZoPNuaatNoz73Fw5PZcVDZHzNa8zUXCUsTvV0VRRX7FgwGgRXrm/uo3wDGzc1ePRFS9k 0MmQ== X-Forwarded-Encrypted: i=1; AFNElJ/kmhRKve5zZEg5LGHo6rIaqqQpVJL/i13AGUULu4GgfUeHp9bI+D8hVqvK3chUMm6UN6Gt7pEAnhQl4rM=@vger.kernel.org X-Gm-Message-State: AOJu0YzGY1PLTlq3jMro4uLAHap2AgdJdIPfAm3Gewo01H9e9FWNHdi0 ggLRCteMovj1MzMF+Y64ChzvD6oNDmNEmOBIRKVC832QZMGx9updJPn/ehRjDBobfGo= X-Gm-Gg: AeBDiev2kw89+BCYlhjtTYeBQ5XfCAS+eVEuhhmLtMbggZWCbxjbX7BzqcGDBzWBeD1 Jn2uhErbscSY/EqOBmtCDZVOvMpfWDw4gzLf3NR6kQ4bjlC9swtJ7m01p75ITMzJ5mD9mDBK72e NJNyNzbiQhRgwhboT/FbHp9DSdwQVAkAWeFJwB3Uf0MNc00oukjiCvXBkTEX2HtOpiQ1e+5M0WU 5K/cPin3XwYLDWTpe7mzOfbFqVGEvN/fg5n6ZKsvU1RsNfv2kj6T1PQOWZfDW71vK9Ntdd5hcEP FHQetu3axzUjCA1xxKQQGGEcmL8PqI01sfeVrPK8AUhx0+Mzqx6JSXM75iMQSt6xqXKSaLq1WnH nCbw767z8wSD9B+OVQ9PakTEhmWdBevdnrc8sZm65OD4HErsJeDC452jG6l3TFUOy4184dot4Bv uP34ItsWnaqUt2oEtdNWpJ1eJ+eBQWdR/2l1VrxLJ8BDAuWf/ZWkUheFjEXP+VXUOXb4ChTeuiH nVzGMAehqHVepLA+eatenBPrw== X-Received: by 2002:a05:6000:184b:b0:43f:e231:6721 with SMTP id ffacd0b85a97d-43fe3db2c4emr2537875f8f.2.1776413030314; Fri, 17 Apr 2026 01:03:50 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:b416:50ee:20e:8775? ([2a01:e0a:106d:1080:b416:50ee:20e:8775]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4dc24cfsm2599457f8f.16.2026.04.17.01.03.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 01:03:49 -0700 (PDT) Message-ID: Date: Fri, 17 Apr 2026 10:03:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH RFC 3/7] media: qcom: iris: add helpers for 8bit and 10bit formats To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260408-topic-sm8x50-iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org> <20260408-topic-sm8x50-iris-10bit-decoding-v1-3-428c1ec2e3f3@linaro.org> <7ca67466-51d7-0003-47c6-9d0e6518745e@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <7ca67466-51d7-0003-47c6-9d0e6518745e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/17/26 09:23, Dikshita Agarwal wrote: > > > On 4/8/2026 10:13 PM, Neil Armstrong wrote: >> To simplify code checking for pixel formats, add helpers to >> check for 8bit and 10bit formats. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/media/platform/qcom/iris/iris_utils.c | 12 ++++++++++++ >> drivers/media/platform/qcom/iris/iris_utils.h | 2 ++ >> 2 files changed, 14 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c >> index 26f51a0ccd04..c75dcb8e671e 100644 >> --- a/drivers/media/platform/qcom/iris/iris_utils.c >> +++ b/drivers/media/platform/qcom/iris/iris_utils.c >> @@ -40,6 +40,18 @@ bool iris_split_mode_enabled(struct iris_inst *inst) >> inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C; >> } >> >> +bool iris_fmt_is_8bit(__u32 pixelformat) >> +{ >> + return pixelformat == V4L2_PIX_FMT_NV12 || >> + pixelformat == V4L2_PIX_FMT_QC08C; >> +} >> + >> +bool iris_fmt_is_10bit(__u32 pixelformat) >> +{ >> + return pixelformat == V4L2_PIX_FMT_P010 || >> + pixelformat == V4L2_PIX_FMT_QC10C; >> +} > > A similar check is required in the current first patch of the series. So > you can move this patch earlier in the series? Ack > > Thanks, > Dikshita >