From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbdLHSLM (ORCPT ); Fri, 8 Dec 2017 13:11:12 -0500 Received: from mout.web.de ([212.227.15.4]:51620 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbdLHSLJ (ORCPT ); Fri, 8 Dec 2017 13:11:09 -0500 Subject: [PATCH 2/4] serial: pch_uart: Use kcalloc() in dma_handle_tx() From: SF Markus Elfring To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Fri, 8 Dec 2017 19:10:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:xFV+m/1mBqnvbs6dUnGCDKgbpT0E/3EtLu7C3GOUCbPcplGix1M 7nTTYSYy/d+32hO/+WCPx7AsYYdI8uZdXcqM2962R91XmEmS+H5EkTyNAhcGaC7TSDRSq4+ MnsiIirKj6XYVydQC1r3alAfZAujAq8OVBpt7XkzymqGPhSVl4R2TcqOc/rwjsszdHzNk8p suO7SGRSET1ZQPcofvJ9A== X-UI-Out-Filterresults: notjunk:1;V01:K0:isd/fekF4uQ=:yx31CjQvqI+K7AQQehxwsl xQaD8fbbJqrp5YtPK3elu2oDX32eNftRHgg627pktYj/j1w0DD/mb745SBKS7Rpif4ynDourH zwsWrIfD83poT6cVEUMXa9+RjxAQF3iixQ6AMaK9YqdiK26+0S07pxc0NvbRPVbMSOLlTdjZL css93MBXPn7HFVvGj3Wc6USGqViWhDAACVoOSdaYiwtjrxzWCj+i93sflrT+mgdx+XAYmdyu5 /u3V5Iwkpg403/nvxtFQD6U1q9dJPrP9vPI1khs7DWatNsuC7F2pYfz04kjWTtXjefuFyw1os jyl6t08GwC14PyRNoYoAMob0NwBcZf/VYT6MUMrIeFofzUuSpmcSX6GrI/jTflidpp5wC3+1c id7QmXePxJIrvpkHWGH9UzJQUpDjrnoMECZknahHBk+FuQbJa3bSIpZPetLZhJFnLSnVXJ2/e SZwM9GjKOZTGv7FDACdKh/Waf6IH7fDccA5ec7M1W565gdzhED9y1Ap9GULLBwfaAAF6Xp9pX tZ8o+zvOWRR4khWEceGjjwEB/HHFmynP9fSVQoxjv+kEm+I+ro2pDrqVFPgnV7DjRfZ0LKJsb LOmOSNwPhqGhG/uUJONC7o7bwp7KPJHbCGvFJ8HlX58Fz0cUl1wPnRcqV48sLQ1TdvH06fqRg /jUGy0fxJuNhDx5ausbpc+Y2mpqErtYuu+m2MXUvwHR8vH5wSM9u2oU67B/sxK+jee2BuZNsE G3kk/BLz89AO5nSTQiXUBKSZw/AQeLqkp+mA0/6e3VMH+4d70zg5ONj/3y8W3myh6Op+v1KP1 UCwqBsYZqw+iuEGrWb+YK0VARUPjcHyLAz+MJ84jvh96wsuDHY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 8 Dec 2017 18:38:15 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/tty/serial/pch_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 0fc72c491c9b..53cdf23b83c6 100644 --- a/drivers/tty/serial/pch_uart.c +++ b/drivers/tty/serial/pch_uart.c @@ -991,7 +991,7 @@ static unsigned int dma_handle_tx(struct eg20t_port *priv) priv->tx_dma_use = 1; - priv->sg_tx_p = kzalloc(sizeof(struct scatterlist)*num, GFP_ATOMIC); + priv->sg_tx_p = kcalloc(num, sizeof(*priv->sg_tx_p), GFP_ATOMIC); if (!priv->sg_tx_p) return 0; -- 2.15.1