From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9548271A71 for ; Thu, 18 Jun 2026 08:49:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781772555; cv=none; b=sxMx4x9bVqbc8DbPfKNc0+X85nCbqlNN2z7wPuraYOmdunyBN9RpvfuiMCtUVgZqB3ROGkbDBG/XObDCoOMGGqGD89YIUWmnt10UaNVCoQErUpSaup0YOgvqbdAXjovdgqmexE7XHp41xB6EPVpexk4/1wrLwr+rJIcDyb71mBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781772555; c=relaxed/simple; bh=vwZ3ox+S8EieIsKYJeZmQbcya6G6wNYQsljtLPXCGxg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SBOc/PGE0voJHMUR2wX9bNlmONF4UUuvhYU6LMdBiEHPiN1H9OJZ8Q4cVgk9gluePVJ/mbLTnrKXMzNtlZ6yZBCKXi+c7/ctitL+jDeFXrg7calqkKmXlMoL4pVVM1NcknRV3iuKXVyT2jAeyTcwRBYfd2Y8IK+eN89fCdB9Lfc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K7/9yTiB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eLaoBEDe; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K7/9yTiB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eLaoBEDe" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65I8FRNd975760 for ; Thu, 18 Jun 2026 08:49:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +bHBfnOAx1pzFWwgZXfmA4+mbnnhL+GXgdNbrmQVFYI=; b=K7/9yTiBl5cqHQg5 fvVraopTRGu2bBf6exdrN6Q7F9Fewv2IYgq2+73Jjjit2s9x5kQtkAt4wsxSL0E5 RmAwUof+CnqpAOVBuQx5P71IDfIrK4eGaza1dGlDUYlpY/vYvXj7C3mRNSeDexNG XrtdMpLDxPJt9I5XhfTNRO+si8a+LumH2ska9EZNN4339ySmmwcAoV+f8S89yXgF TdcmVzq0gHX8+yCEGvLrK0JiFuDdoFXunCj9w473ozI1NnK4n/kPDU3MEOs2jL3c qxdZyGf4ZtqbkCjdg7HPuCHOzvk0rCIzJLmGGRNP7EggezpZxXWuJClP1r8stgm6 Mz/WjA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ev1wc2d68-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Jun 2026 08:49:13 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-915a4ca0a4aso22452685a.1 for ; Thu, 18 Jun 2026 01:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781772553; x=1782377353; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+bHBfnOAx1pzFWwgZXfmA4+mbnnhL+GXgdNbrmQVFYI=; b=eLaoBEDe1w4x6U2m/1h+ntxHFwnG6AZwiB/Cgdkq12aC6TvFE6V2JAXXqXpAOGJ9M0 5tBrSKytprmobrr/gct5dddaywFh1Jd5BeWd/Xxev2BgaBN1ZWBZ70bCCYAO07xiSxuW RpmNd7QHGzCQjUdvGQOfhrZXNYDczsQb9S+jvLzyMtfBRfJ2zYcj7PonXVfKMjAQHysX 3+arkQ2UpssZltjpo65Q3j5+fNeEUvf5/E46LnrKZSyx4pp7XZgH0bw7k247hXqwFN7e c8QdfO3LGSZjbM0aMCeUdRgFyV7kZFWjCEVe+A3T2MWD3QWvwu3yosXEP+c4KExtML53 ufww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781772553; x=1782377353; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+bHBfnOAx1pzFWwgZXfmA4+mbnnhL+GXgdNbrmQVFYI=; b=fV6ytxprXFHHqn4JqEgV0yHGDTz/3//Wwcf+ZiuIKUUM5kuooVM3yIQYwKDD2nWmw5 djGZEo4OaokIXdkLcBR+Ha5VQINFcd620467dk5sP5euq0voIqfdg+cgwC4zwh0skXPC R8VWFnJE5jDdMPC7slOlfcEMUVQrczgy4cFxLhJwkUKFhUVQweA3M1F8nSWsSeHAZwRj 4hG5AOUF85EIQ5/Bfh+r1gUPGdcAQ9aDDKvRvYuRXe9v2KOIZVsDJRF4dzKdp/YGdT9b 6UkhqFulBIKq5UcP5q8NgkzjBcy+eFi/gsuj4VsSjMtyxKfwQPFpiVa7O9SSdDmBNCII d+4A== X-Forwarded-Encrypted: i=1; AFNElJ/ANRvlhXtxUz8k1YHjVfnJ0XVC466u/OVvNENk8xMFaPhoHTn2lOMGfK8Z9ZwNYIhkHm+lO25IkRcHrXk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5QUs9Dj1Q9BoQADWFQRreDtJcu7QmekQ6U6KWNWRaStYw6WeE lsmx8AF64GgowMeDJjf3B22YRVYgLMGppCjib19Zo4QRc0i+IOCS23kPPvqA7GCRNfRhI5VufHh F3ojd/AJ5i+UgR6hcA1EPTYdx2tCUD/Tm1WSsnSfW3eJuBVuB4an3B+66X1EyX2EVDdU= X-Gm-Gg: Acq92OH2fkcOw0CVoKfjvqmAR4C0V11M7CT6R/Y42d5AYX3b5a6XbtXLCAPSZ5hsFfa Q/IbpI5F4sjPuykB+o4buiJuXfUb2xThLixvqhS8TsglaJgr6HsqKiPFc/aKhLXIm4zZIxTSjNv rEMLtVVwKa4BMMXhAc1BHEPp9GpxjBmy4qamntWM6O1voQEOFVlhHUa5Fcp85ls3jN8lnUQQhri 2gdkwRt90N9qe15j4MXI9I7FtRRxHM91pUFg6ampfk4/3dbxCQEbich3/Z5jgmqLcWTEzS4p6vG G7oHS9HklAAY27NdyOoh49crXBFnrx8Xy+b6sQRYWwwFnQH25Nw7t9ueK6BL965R3GA/Y1ZUt6d rj72cFs/2/M1YVq0K+6wy+qWeTb/AA/Sr32A= X-Received: by 2002:a05:620a:3910:b0:915:fad5:9096 with SMTP id af79cd13be357-91f2ba5e3bbmr276505585a.7.1781772552886; Thu, 18 Jun 2026 01:49:12 -0700 (PDT) X-Received: by 2002:a05:620a:3910:b0:915:fad5:9096 with SMTP id af79cd13be357-91f2ba5e3bbmr276503885a.7.1781772552496; Thu, 18 Jun 2026 01:49:12 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb4b22544sm897196166b.14.2026.06.18.01.49.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 01:49:11 -0700 (PDT) Message-ID: Date: Thu, 18 Jun 2026 10:49:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] pinctrl: qcom: Unconditionally mark gpio as wakeup enable To: Sneh Mankad , Bjorn Andersson , Linus Walleij , Neil Armstrong , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Maulik Shah References: <20260616-enable_wakeup_capable_gpios-v3-1-fb59647d89cb@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260616-enable_wakeup_capable_gpios-v3-1-fb59647d89cb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=TMt1jVla c=1 sm=1 tr=0 ts=6a33b109 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=rd1qytcpxr8NqP3Khf4A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: IUzGeiHC_p-YHQ8LknnAmenswvenqmLG X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE4MDA4MCBTYWx0ZWRfX4UWVLKc6nqyg lZsB0RJvbBiNN3jzZFCmN2rsg+lFyfqQ/kVyhifJRcbVhZnkNzgE6fneJGDVlE/tm6t7t10GYli pJNwKjFa3qgn/kO8GmOsLtiVfOeTRos= X-Proofpoint-ORIG-GUID: IUzGeiHC_p-YHQ8LknnAmenswvenqmLG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE4MDA4MCBTYWx0ZWRfXwX4rDrZElaTA emIKk4Afxm1PjYfxK3iwI7AzevX07dddKhb83OOOXVSKsYA8lBK891SpJI0aZa3uinO96Rs+o0u 5TsiXSWMI3oYUCGzO6E2vozOEoUFRX0GMd3xal23ux6sG3CS5mNSufQwtayVl+AlH0zRpEDASdZ k533u0npkzX0qxnoDjIIOjyvNjXL2PPEmhvwi3NNQ8B4c33jYrjosJTW5RRNL+bF7Btz99OEguC GRpz06f/vXL1iV/AjzcOKUdRyKXwlD2RoxjIyViBYOgz+pkXij93rFcmOncetpQzgjZz/KCk/Xz rP3Pi5kJ+tSx9rcfUvPgYUpqVn0fN1fCNIbxeur9u+hxbzaTdCh7e2s7eBDH1ZtxYwRz6YRLiIt a7nS2gVRWHuOcduN1jUi/fWRQYyWhxLp4+LKda6nBbY/pK5zSCNUZmWRzkCfPsud437d2wcMPF2 bXtN4cI9V28wVEQx+QA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-18_01,2026-06-17_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 adultscore=0 impostorscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606180080 On 6/16/26 1:54 PM, Sneh Mankad wrote: > GPIO interrupts that are wakeup capable need to be forwarded to wakeup > capable parent irqchip. This is done via writing to it's wakeup_enable bit. > > Currently the bit is set only for PDC irqchip by checking skip_wake_irqs. > skip_wake_irqs is set to differentiate between parent irqchips MPM and > PDC. It is set when the parent irqchip is PDC to inform pinctrl about > skipping the IRQ setting up at TLMM. > > However, the functionality to forward GPIO interrupts during SoC low > power mode is needed regardless of which parent irqchip it is. > Without the functionality it is impossible for MPM irqchip to detect the > GPIO interrupt during SoC low power mode since for MPM irqchip the > skip_wake_irqs is always false. This is a much better commit message, thank you! One question remains - should we set skip_wake_irqs for MPM too? My understanding is that no, since the MPM HW is simpler and doesn't have a register for acking IRQs, so we need to do it from the recipient (TLMM). Is that right? Konrad